From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 867DE386C1E for ; Wed, 12 Aug 2026 19:53:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786564403; cv=none; b=r5nS8qmQ4WRg5APxUZxRnAX/hIalIB8UDwt7y9Ff+TGDN7AM9Q5ikXxq998OedFkmeG5j/LQlUDxtYlKjgT6vpcNdeFGtjQykxj05440u+ez5X9Ol8hdBih+warMu6rhAe4piLEi3/NFbFFfMJtHJPWkioHQXC1M+sOoTGp4Y/g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786564403; c=relaxed/simple; bh=gpPLws1+h9xHPMVtLM8Mj1+gP9xwwHEe1Vdib5Sfixg=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=LtcPMGsgkL0IbJFN6E+QCOXVRnNQ+NgbjJAMISaIKH4sAmCClGygnBc8gex5ombLXox55zLjf0Ny/rgbDzgHzeVa4opX7M+7RBUWG53TLQzq3qO2pZdOmlQNYA+idJbYZQsLtGxkoip2lNszVfFs0LUMr7ZBQWt17iMJRsqkSuQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Yu+MunGk; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Yu+MunGk" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-49557167508so10354595e9.1 for ; Wed, 12 Aug 2026 12:53:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786564399; x=1787169199; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Q4GDf4yjh9uyISnUKMYp4de1+6HkxuZ50urGemRxIzI=; b=Yu+MunGk/BlWOCXVzRC85/+SBs06mJsZD6PGyRSa93htFTIHzBC6LCE1+2DCmrsOus OyfwUvPRjbcP1VSEj751n19ExxKCF5D6AXLwHz07oarzDJgB9Ow53KVzgxwnd3LbnN6N q4Z+Ny47h3e+hTk8+MdqCTdzmEaMiA4L9Zq/1xZ+JzrN7gSChOJIJtButvc+SZu6Anw9 9j+RyXfAZb3qPxLzU1uNDDF/P01rot6OEbHBcEalTs0c4gqgIb97sPX0PfGQqRiNUUo+ X9EPR56F1Qg2ClQdsbNsGP+8zB2hTdbWgDcyJpl4iIJxSDM329AJrdbT32MW1SC2z9mY iEkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786564399; x=1787169199; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Q4GDf4yjh9uyISnUKMYp4de1+6HkxuZ50urGemRxIzI=; b=Pkgdeu1ScGc+2ruCf2JZpDHLLg8URrpYQUVg+DDAma4AxWXLxEKy980EGSQrmGpiEi DHpP3bGoURYTM09fCSP2Ian757PWYsRkFAxzVwSIwSG/qfwgdXqQf8axmkLNyK+SwlS8 ou9Ox31QfcqD2DWnZQhzlJ+L9cWsZNIv7doRoX98IEprqt1ZOxTzZHJ6LMoVz1Ef/0LV BwrD0FtUJYlPu4X+3dWwnGapusHwhkytBxxZ7NNDD7s6uk7hg998kkscAOB5ZQGJ2Ayv Bm5+9Q835pUum9IkpFZcTUB1GNApUhS5Vk5MJmNV5yPRk/EOoUFgxVd3YWTmCPFboBuk eqgg== X-Gm-Message-State: AOJu0Yw0hAtD2xFg1KmGr9a7EeGBp0MNXjaEDikxVvDPoio6ODjps4TM xNBS/EzhgQ+b+bGcRNOmIvjlmSmFQvKU7c+oiE0irCuq0aUmAGnXTc8YhgIZ6mHW X-Gm-Gg: AR+sD11LDe+PWC8zd3mOvyF2DmPxh8/r5+ohq8CTKkKQt5EVfUEmyk1kA5yFU3GpSBm MobcAZ+eAt0wmL9RBSUFPvVGhKp4MObQ+V4c6x1QfO8uwAa9Y4QHHhqO/32aLzRvgTDX3kt+xoU J3YQ+pFKzB7vwsZiNIkoLGKu1uv1kEJk142QPBap5yxrI9pfK5/Atv4n13Qg/fNCtB7PoecWhdf QH4F0yCJeAMAyQwtbhexJMEyDYg7rtZyMJC51U5F8vrcbmzeeCCQ7SJ7ZjXYGIXb5TPFdI/hxYn OuQfPZyKNoWCjNkzfwD1YTE0aHFI98qxwIT+tO2zxEBB0i2JjPqYRGz2oCr6yKVJPKqP/Cz6eRh QYnAr0XTjq/YF5ErObC1AMNGnmY+otNqBu1NvUwyd/tkYKQiKqniIWXJgoG41WykGGwDN/4zVEv qkQ+sdFHQNf3uLveacmY/ldf1lQu2n2KSmSpex7aP/CGtISac2c5gPnwgKUJQ35IPRxf4zbJ1wv 40Iz/BDuSA4/XvAUtz4fU0AoPAO4m7rxp18GPvNLBA/EUk1gw== X-Received: by 2002:a05:600c:c054:b0:499:7aa7:eaa7 with SMTP id 5b1f17b1804b1-499821fa293mr503345e9.15.1786564398538; Wed, 12 Aug 2026 12:53:18 -0700 (PDT) Received: from karin-metis-desk.tailaea490.ts.net ([2a06:c701:c1f7:3500:4c98:e58c:bdb:6080]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49981abd6desm13145665e9.0.2026.08.12.12.53.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 12:53:18 -0700 (PDT) From: Tomer Pomeranc To: linux-kernel@vger.kernel.org Cc: gregkh@linuxfoundation.org, arve@android.com, tkjos@android.com, brauner@kernel.org, cmllamas@google.com, aliceryhl@google.com, stable@vger.kernel.org, Tomer Pomeranc Subject: [PATCH 0/2] binder: fix TF_UPDATE_TXN supersede cleanup bugs Date: Wed, 12 Aug 2026 22:53:14 +0300 Message-Id: <20260812195316.259136-1-tomerpo@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Two bugs in the t_outdated cleanup path of binder_proc_transaction(), both introduced by commit 9864bb480133 ("binder: add TF_UPDATE_TXN to replace outdated txn"): 1. kfree(t_outdated) is called without binder_free_txn_fixups(), permanently leaking binder_txn_fd_fixup entries and their fget()'d struct file references. The refcount never reaches zero; the leak survives process exit and accumulates until file-max exhaustion. 2. binder_release_entire_buffer() is called with is_failure=false for a transaction that was never delivered. Since binder_apply_fd_fixups() was never called, the BINDER_TYPE_FDA handler reads stale buffer data as fd numbers and closes unrelated fds via binder_deferred_fd_close(). Confirmed on mainline Linux (6.8.0-124-generic, binder_linux module) and Android (Pixel 8, kernel 6.1.124, /dev/hwbinder). Tomer Pomeranc (2): binder: fix leaked fd fixups on TF_UPDATE_TXN supersede binder: fix is_failure flag for superseded transaction cleanup drivers/android/binder.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.34.1