From: Hongyang Zhao <hongyang.zhao@thundersoft.com>
To: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Daniel Drake <drake@endlessm.com>,
Katsuhiro Suzuki <katsuhiro@katsuster.net>,
Matteo Martelli <matteomartelli3@gmail.com>,
Binbin Zhou <zhoubinbin@loongson.cn>
Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Roger Shimizu <rosh@debian.org>,
Hongyang Zhao <hongyang.zhao@thundersoft.com>
Subject: [PATCH] ASoC: dt-bindings: es8316: Fix supply property constraints
Date: Thu, 13 Aug 2026 19:53:34 +0800 [thread overview]
Message-ID: <20260813-b4-es8316-binding-conditional-fix-v1-1-6cd56aa1370c@thundersoft.com> (raw)
The DT meta-schema requires a `then` clause when an `if` condition has
an `else` clause. Invert the compatible check and move the supply
property restrictions to `then` so they remain allowed only for ES8316.
Fixes: e9966d450b46 ("ASoC: dt-bindings: es8316: Add regulator supplies")
Reported-by: Rob Herring <robh@kernel.org>
Closes: https://lore.kernel.org/r/20260812194234.GA693895-robh@kernel.org
Signed-off-by: Hongyang Zhao <hongyang.zhao@thundersoft.com>
---
Fix the conditional schema added by commit e9966d450b46. Invert the
compatible check and move the supply restrictions under `then`.
---
Documentation/devicetree/bindings/sound/everest,es8316.yaml | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/everest,es8316.yaml b/Documentation/devicetree/bindings/sound/everest,es8316.yaml
index 276c73bb4790..f4ff23120c5b 100644
--- a/Documentation/devicetree/bindings/sound/everest,es8316.yaml
+++ b/Documentation/devicetree/bindings/sound/everest,es8316.yaml
@@ -33,9 +33,10 @@ allOf:
- if:
properties:
compatible:
- contains:
- const: everest,es8316
- else:
+ not:
+ contains:
+ const: everest,es8316
+ then:
properties:
avdd-supply: false
cpvdd-supply: false
---
base-commit: 79a883d53960fb2eaf02f72a37182078b4fc938e
change-id: 20260813-b4-es8316-binding-conditional-fix-0bbc9151fef2
Best regards,
--
Hongyang Zhao <hongyang.zhao@thundersoft.com>
next reply other threads:[~2026-08-13 12:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 11:53 Hongyang Zhao [this message]
2026-08-13 16:49 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260813-b4-es8316-binding-conditional-fix-v1-1-6cd56aa1370c@thundersoft.com \
--to=hongyang.zhao@thundersoft.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=drake@endlessm.com \
--cc=katsuhiro@katsuster.net \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=matteomartelli3@gmail.com \
--cc=robh@kernel.org \
--cc=rosh@debian.org \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®