From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5AF63822BB; Thu, 13 Aug 2026 16:46:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786639598; cv=none; b=sI3o6DylF+MZBbXAOoNwPX1HQ5BamSpADoH9XXGf3Ek6rmWbgXTP17sh3r1oezGEdmpH+MF4oGxzF7G7O9GQ68zMnnJNDEGal+x2taF3Z/jgvOHG+zf/iqSIxDIV+29cKPL+ZvUNa07zxHj8mUze4Biz5WYEmkP7hqVX5O8enzA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786639598; c=relaxed/simple; bh=HuS4pE0PYf0J2cImG7jatZ0GCEXiLfI4xqRu6kS6BRo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mzycGC1JxIOFc4S5+0FNZtHkS57IA1Nm0XAdcifQARVmjE1MWDhiQf59sBy59KCHpQalSaLh2Pk+lS7VVHDcTYPwLIeY38+a7z+kCc9k/JczoBZQV5awf2PwVfAEua+Lwr/atSrWjGEyLV1JoUhZ4oAL4ViJYzHoNzjL9yJNTkQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WZbAJXrZ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WZbAJXrZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B70081F000E9; Thu, 13 Aug 2026 16:46:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786639597; bh=FB6WjC6V8WgzoH3BfkjMLBjleZvuxw4y6S8vLrv6/4Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=WZbAJXrZ49ltFgfZmedw3FJLqQOd0m1gHTqClg+czOxMht/OwnCGxxXDig4rfRrgI oW4bQh6iVRyV4YTV4/j5CXTHpPLjw7xqzWMXnawdrK1MG/YfblPmu57x+YBzeueaV8 L+XWEVqUXLgL8fI8yWJ7KKoYT8m1J1YeBNT3nx8sI9h6l75Ic9VBG/AI6979REKHVO Xm6cv2OAVQOnWrVLREMWzG+TZJ2Beqsr1KQuJ5jJ/mT2TSXXfbV8n7w2kbDxyIlQJx dIhEDU5Xn1Cnfw9Ny+MkpO7+l7wNsQn4pT3odXqDFwni5bEjtVrdIX4Mx0/+a9gKSs f+k4bOSItLdrw== Date: Thu, 13 Aug 2026 17:46:31 +0100 From: Conor Dooley To: Changhuang Liang Cc: Michael Turquette , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stephen Boyd , Brian Masney , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Philipp Zabel , Emil Renner Berthing , Chen Wang , Inochi Amaoto , Alexey Charkov , Thomas Bogendoerfer , Keguang Zhang , "linux-clk@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-riscv@lists.infradead.org" Subject: Re: [PATCH v4 7/8] soc: starfive: Add socinfo driver for JHB100 SoC Message-ID: <20260813-presoak-scarily-b6cdecfcb7cc@spud> References: <20260809015054.210577-1-changhuang.liang@starfivetech.com> <20260809015054.210577-8-changhuang.liang@starfivetech.com> <20260810-caress-rack-45615c8d9747@spud> <20260811-populace-afflicted-40a40e0f484c@spud> <20260812-snowplow-punctured-28d19616f707@spud> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="u3IBUAeGtjz87z4y" Content-Disposition: inline In-Reply-To: --u3IBUAeGtjz87z4y Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 13, 2026 at 08:10:12AM +0000, Changhuang Liang wrote: > Hi ,Conor >=20 > Thanks for the review. >=20 > > On Wed, Aug 12, 2026 at 10:37:16AM +0000, Changhuang Liang wrote: > > > Hi, Conor > > > > > > Thanks for the review. > > > > > > > On Tue, Aug 11, 2026 at 05:36:19AM +0000, Changhuang Liang wrote: > > > > > > > > > > On Sat, Aug 08, 2026 at 06:50:53PM -0700, Changhuang Liang wrot= e: > > > > > > > > > > > +static int __init starfive_socinfo_init(void) { > > > > > > > + struct soc_device_attribute *attrs; > > > > > > > + struct soc_device *soc_dev; > > > > > > > + const char *machine =3D NULL; > > > > > > > + struct device_node *np; > > > > > > > + struct regmap *regmap; > > > > > > > + char rev_char; > > > > > > > + u32 rev_id; > > > > > > > + int ret; > > > > > > > + > > > > > > > + np =3D of_find_compatible_node(NULL, NULL, > > > > > > > +"starfive,jhb100-sys0-syscon"); > > > > > > > > > > > > Remind me again why this is not just probed as an mfd cell from > > > > > > the syscon driver? > > > > > > > > > > > > (Hint: please put this info in the commit message). > > > > > > > > > > The discussion result with Krzysztof at that time is recorded her= e: > > > > > https://lore.kernel.org/all/20260405-strong-watchful-marmot-fdfad6 > > > > > @quo > > > > > ll/ > > > > > > > > > > One register should not be treated as a separate device node. > > > > > > > > That's a different question. In the case of an mfd cell probed from > > > > the syscon driver there would be no devicetree modifications > > > > required compared to what you have now. e.g. sg2044-topsys.c > > > > > > This seems feasible, and I can introduce this modification in the next > > version. > >=20 > >=20 > > In fact, you don't even need the mfd cell, because your driver is going= to be in > > drivers/soc/starfive anyway? You can just bind directly to the > > sys0 syscon I think. >=20 > I suddenly realized that I missed one issue: starfive,jhb100-sys0-syscon = is already=20 > bound to the PLL driver by default, I can't use it to bind another device= anymore.=20 >=20 > which is why I used=20 >=20 > np =3D of_find_compatible_node(NULL, NULL, "starfive,jhb100-sys0-syscon")= ;=20 >=20 > in jhb100-socinfo.c. >=20 > So it seems the MFD cell approach isn't really feasible either? You could, in that case, probe the clock driver using the mfd_cell like sg2044-topsys. What else other than the pll controls and the soc info register is in this register region? --u3IBUAeGtjz87z4y Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCan305wAKCRB4tDGHoIJi 0tqCAQDnOCdXow5y4UEH9HN1Ayp7UyioUDwiF4QVHavs/q1R7gD+K6A9t/cRtwyI EoWcCEIq5L8aEecNUZlO9dJJ0Tt8PQ8= =jzed -----END PGP SIGNATURE----- --u3IBUAeGtjz87z4y--