From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02701184 for ; Thu, 13 Aug 2026 00:04:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786579487; cv=none; b=mNrBPwVW9pLoUEaXbsnR0h2UJHr2kjUJsDCGcQR2nO0FyK1hF4iCfIK2/xRfIkdFtkcExZHflINkmE8WQ9i8PoPN6wKBRZDVe8pB81Izp1dS+Gk2qw0J+gIhehMATAefFD3rbDcQnyaTkvVYG/8wwK1VKrInXD8g/TI89izNJCI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786579487; c=relaxed/simple; bh=g4HtTFFBCpsZ2yZqmD5tEAaIDJO0KZJTVcRmsaFAbdc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Zlf+ccRhd4QUEg+aSdR1h3zV7U/kzLhXPXZXpGOYC4bxEdQLvEIeQs0yPh4WjuViOuEAB/Iz+MblF3WePViOYdO+kHMHXrec2D53dLuobbGncc4fwikMNFzwCSkFwMJ016pucuN/R4Oa++qX6sXpeL0EP8tFHSi7gt+F7VPsC9M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=TN689U0i; arc=none smtp.client-ip=209.85.160.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="TN689U0i" Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-52d37b65926so8708861cf.2 for ; Wed, 12 Aug 2026 17:04:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1786579485; x=1787184285; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Huqb/QDFJHPd43BLlvXmf+t2XVv+CLdxYkB2sOTYE/M=; b=TN689U0iD/14dDbDXV5w+03DR8ewTkz/sbpRXyig+VsHxgqyq92tW1yX0FMC1MFtVV ctCdyctAw73hxHQwQEJFeN46CQ7Gq8QH1KslCiMjHl4bEv30AVzX0SSMztZGAN8tiWNc GDQC0p4uvzT/8gCNVCeIqTk/tz8JXsL9ewh75Ahe1FI85U3kSo43Lrwt3hA94r2jSpqd AErP9H2zzvDql6sHsO2s2c2uam1/09uMMNG2PJL+0mEii4yU51wqILgQmBejuRwg36o3 RuESPrZP0TQKnGaY4iuCRUjL6OcCSmxE1kv0FDdFJE2GwoktTe7tNae36bDQFDuh01ar d/+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786579485; x=1787184285; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Huqb/QDFJHPd43BLlvXmf+t2XVv+CLdxYkB2sOTYE/M=; b=FRjBYf9XZgO9ugOGjVc2rc1Y2Gf7J07MjmqGAKJe4KJVzoLH/XPstUd1+CMy83FMgB vllD4nFl1k6wG2XUuTVrrGR6MGloo8fv0UzAlAZXl85BpV4ykM3dNlHeVFviOwO25gB6 Er3vYA1zk5EfnTUJ6MMEA+Q+TykFumovYIqa3VHrKR8oM91uUSfh5znW3lb7vjLrdznp 1HjalKndx9Afn0cTw/M7E4VDOfzs8aSGmqWmeBp12Qxr6hTB596DDcecEyuCsYxThOGa VViMEkkHx/C5BrHmPZT5d9rXfUhCjk4VjtAvGb/MoRQhCIyNbsBXqf6f2bvYahVCsv0F QhQw== X-Forwarded-Encrypted: i=1; AHgh+Rp+tiX2QopO7nDLDWnjwDgoMj7YZEX9d53cb2nxczQC9klE1HUSGFGZXZ/O2NZSAsdVSGa7wLit+0DvX1U=@vger.kernel.org X-Gm-Message-State: AOJu0YwWZ3wDkwq2Ct1MVdbP1FMzi0kYN1NRMLH/HyHlT6LVPDPi+iai mhKfpAdbEfuvyedcQjC41nNtVm9NytnRAArbJ1QjdUJ1ACPnw1lmktcOJum3h6CZZuA= X-Gm-Gg: AR+sD13sJyFzjrlDqIBQzmbQIl90SrAzgvJUcSv32VnaicST/GnNOXP983Q4ofb4M/P I039x0yMjy0PiXoC3drie23tH0RUevibBD5iouEeSIpB1l002vBNuWvg4YRAMMNKolcjtr9tI+r +w+KKDEaHHRVMvIBfLzDu+lBG95LAimGZ654XUaPSRKMY1olPU9CTCiWF+wGHbx+Df0kkmyXcbP F+wGKG/I7dGuEoN8faedZFL+QrMiRPlUexTdc9M9M/5eIAGBC7G4Z5LR3Zph7J1sf9aSw/gjDny PzoWuuHIW/ftcgfDaEeKxIJrqCShgsV1Ctq1j0VovzWfB7ym8P3RWjV9hvGLgZDVYt3W4Swznun W99oT/DK2s0E2xnwtA/1w8R5J7CS0v0SOLxkvo78QxkIhat8YXnXDt2ZNcAabdg/RXjm9B/X9gH A2wafAZs/GYbQc5R3vC4nuEjsxH0FWbmplQWn/lw== X-Received: by 2002:ac8:59cb:0:b0:51c:164b:b240 with SMTP id d75a77b69052e-52d73c373e6mr18467781cf.4.1786579484642; Wed, 12 Aug 2026 17:04:44 -0700 (PDT) Received: from ziepe.ca ([142.166.156.215]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-52d73fb8c7esm5203891cf.19.2026.08.12.17.04.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 17:04:43 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wuIw6-00000003c6P-1lNw; Wed, 12 Aug 2026 21:04:42 -0300 Date: Wed, 12 Aug 2026 21:04:42 -0300 From: Jason Gunthorpe To: Yili Zhang Cc: leon@kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org Subject: Re: [PATCH 2/2] RDMA/nldev: Guard against NULL ucontext in resource dumps Message-ID: <20260813000442.GI662699@ziepe.ca> References: <20260811141909.GF544626@ziepe.ca> <20260812123249.44247-1-zhangyili01@baidu.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260812123249.44247-1-zhangyili01@baidu.com> On Wed, Aug 12, 2026 at 08:32:49PM +0800, Yili Zhang wrote: > Hi Jason, > > Thanks for the review. After re-reading your feedback and re-examining > the crash log, I think I mis-characterized the root cause in my original > patches. Let me lay out what the log actually shows, because I'd like > to get the fix on the right track. > > The crash is a three-stage sequence, all from the same host > (6.1.52 + MLNX_OFED 24.10): You have to provide an analyis from top of tree upstream kernel if you want help from this mailing list. > Stage 1 - a create_qp failure: > [24805924.400] mlx5_3: create_qp:3323:(pid 2758615): Create QP type 2 failed > > Stage 2 - on process exit, ib_uverbs_close() could not tear down the > process's CQs and fell into the DRIVER_FAILURE fallback: > [24805924.747] WARNING: ... rdma_core.c:945 uverbs_destroy_ufile_hw > Call Trace: > uverbs_destroy_ufile_hw > ib_uverbs_close > __fput That's not supposed to happen. > To be concrete about why it persists: under the current code, once the > DRIVER_FAILURE fallback runs, the leaked object's restrack entry is > never actively removed. The CQ case: And I think this was just fixed recently. Jason