From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F2A23FA5CC for ; Thu, 13 Aug 2026 05:34:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786599270; cv=none; b=RJBOjs6Ljnw/4NCDqw+2t1O1V9UXUsZnDn8CbaMqpCkMnfSbIqUloFf+duHyWXeTxqXTmB5vDBcKATEoQdHQwNyYeJg28QHgIevXniXEMYrldeTDfmL9EaNfrZFsKQsOHB9oJPpHvIjYcbW08U5Vqzv4lnJyUHhKFiS5uWgLbfk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786599270; c=relaxed/simple; bh=Mhj3jWYbiVdYMnI3fvWRvTxrfRl3RdIu2H/JxIENP4k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XzKiZ/FLXwF1aQnWOiq0nHIDEWifa9j/wbnb1pmaN9GPEFE6kZ98xbSBEV4C6RvKDrWyYfhQfVfsgANapqM2PTIZqVdondbXJQWnP5NLJ90qRjhPRg8+JlrorL+sXRha7EsMR5PLZJFFJ26cNw53Le/QWJQhKt1CzvIVH9Fdaxw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BUPuLKOD; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BUPuLKOD" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-3811f512167so2274863a91.3 for ; Wed, 12 Aug 2026 22:34:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786599265; x=1787204065; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Sg48OebW8O5DYM3I5rKP0/NygxmXw5dDjKnd0RIjz50=; b=BUPuLKODAaPmgjLsr7zfA8+I8jTgKDiqW9sS+gl1leplmc6MFmiIg2lew2BBTKRmOC iaUOtRNyrJaHfUL2oiVdJ5oSngJT5HYaS+Ey2jPvzWozH3415Ui6ViGhevEzlV3hnLY6 SVoeyya3HXarsFJJjo1bMr/8iYSyg2t7AacAn+EmZkv+3HDRoAMX5hbzSmigC1vCR4Dx xyVpr2VmYHhKy+RCLbmsAgFre5c4rKgA+VaoCFLRkjPbotggvKoSxRlEXQv37jLzve9u 8giV6Zi/fuUVfgOAlSuEqPANMH/K9WfhM+l8c9uhcZ4ksJwBiZ8h2NEmRVeaAe3vb3V+ 1nYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786599265; x=1787204065; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Sg48OebW8O5DYM3I5rKP0/NygxmXw5dDjKnd0RIjz50=; b=Djkz/wIKn+IAlivR8knTOpt2hKJ/R9MdDKkeYK0xo5CJUZP4voefzPXOg9vnLtsN6k MR//j6i30Ugw8Adk183uxHMUPH2UvFhP/27btw658ZQ2cdTCCSaSLOOlkb5vOq/vtjKy KDuBRaZswYJMreEmhfKbtnSAF9EjbMJgRyqQvnWmZV/nEH4l4dFCmwzfv3It1FF7+TeS rdjfyMRP8zpeW0bjtDsQ/ZrLxtF3P7We+O+jzlytAxIiZG95G1rZfmU/RNiINzDYxXAJ 7Hr9zKA7MJ6rwDhk8Zt4Hh9bMwmZd3K89QFqlZln1sjesrhHWC5FrbL3uGmtjR/M36C3 aszQ== X-Gm-Message-State: AOJu0Yw9O9a8ffOzZFVBG+2fEoZ9oLgc5NtxP2eMES68ZMj1MRN1LhgK TSjMDk5UFX6cWJlzLtGoNFiRwSFk9wuVE2fb0/+AcNl9yxCAc69GPhOG X-Gm-Gg: AR+sD138zIkkkRIkG4VofvCTPwVvuALJtVDEHQXYTiMI/oMrLHdi+hrOqmxDM7e7OJT T1PcPvXJoWMJjnHUVioNXeOCfgTGqaVprosdllyozmSLqdB8Tyuw8UFINqUsDnCParYniBw+fLr PgZkFojtiZ1rbbzdRO2872qc2SM26FRW1z34WYEX+I/qw1xd2+Pyvhu8W+jDH8Qx23otDdCA3Ve +JMoylidifKcTz1JYSKiibzWmNQ1ucTdoOViEZrLqRmnESwj4+2ITD/KPUIvFwGCZZpUzzLnkuC BYmkiWbT6U4mAyRD6zx356wIK8zNKTnevS3wJp3PTIeamqtX2k1eRuN59GrwK9Chq8WDBXbmZvS 9eNrLbXAFKuntICpLR4ZlAM5WtNN+81FydjXrD2Zg5WWktYLmnz5IQqFxUQU5eK30yup57AwkXj I29KYL6wgzJBhrnkb88OC1YAuHQDYGw0J0iXmUkNYjrEldXASg/8PdPD92FrhqtR0wt70kby9Go Uk6rdW+HAgltYjhSrFSt6N8EAXegBZFDx5iQzzeCF2a2Yb9jS32KFTOPyduu09NKBe0fedl7oi0 E9uaLx5o/A== X-Received: by 2002:a17:90a:d40b:b0:393:19a3:4f1 with SMTP id 98e67ed59e1d1-3931e058763mr3777372a91.6.1786599264874; Wed, 12 Aug 2026 22:34:24 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3931d872ec5sm594734a91.0.2026.08.12.22.34.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 22:34:24 -0700 (PDT) From: phucduc.bui@gmail.com To: Ulf Hansson , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jisheng Zhang , Stepan Ionichev , Colin Ian King , Pedro Demarchi Gomes , Osama Abdelkader , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Cc: linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 1/3] mmc: meson-gx: Handle errors from optional IRQ lookup Date: Thu, 13 Aug 2026 12:34:02 +0700 Message-ID: <20260813053404.21553-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260813053404.21553-1-phucduc.bui@gmail.com> References: <20260813053404.21553-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc platform_get_irq_optional() returns a positive IRQ number on success or a negative error code on failure. For an optional IRQ, -ENXIO indicates that no optional IRQ is available. Other errors, such as -EPROBE_DEFER and -EINVAL, should be propagated so that the caller can handle them appropriately. However, the driver currently stores the return value directly in cd_irq and continues probing. Propagate negative errors other than -ENXIO, and only assign the IRQ to cd_irq when a valid IRQ number is returned. Signed-off-by: bui duc phuc --- Changes in v2: - Initialize cd_irq to -ENXIO. drivers/mmc/host/meson-gx-mmc.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c index 694bb443d5f3..d2903e3dfd6f 100644 --- a/drivers/mmc/host/meson-gx-mmc.c +++ b/drivers/mmc/host/meson-gx-mmc.c @@ -1141,7 +1141,8 @@ static int meson_mmc_probe(struct platform_device *pdev) struct meson_host *host; struct mmc_host *mmc; struct clk *core_clk; - int cd_irq, ret; + int cd_irq = -ENXIO; + int ret; mmc = devm_mmc_alloc_host(&pdev->dev, sizeof(struct meson_host)); if (!mmc) @@ -1185,7 +1186,11 @@ static int meson_mmc_probe(struct platform_device *pdev) if (host->irq < 0) return host->irq; - cd_irq = platform_get_irq_optional(pdev, 1); + ret = platform_get_irq_optional(pdev, 1); + if (ret < 0 && ret != -ENXIO) + return ret; + if (ret > 0) + cd_irq = ret; mmc_gpio_set_cd_irq(mmc, cd_irq); host->pinctrl = devm_pinctrl_get(&pdev->dev); -- 2.43.0