From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44E133F44F4 for ; Thu, 13 Aug 2026 05:34:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786599274; cv=none; b=JcO/OQEWWn2IwOxbmRaMej/jKtlfoZDz348OPe/aLQZqU7+AVdqITHz3QukWLZukDFawrkBNfryMadlSKcj2fr6ZHjcyUz6WN+6Ij4os7SS8eNUC45FHvXWaia46lfE83ag9D8oh+63t5oYdKrhqUUCYqoPEAZN9fVsFp0RIfwA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786599274; c=relaxed/simple; bh=NLgdqVpvj8F7Pc9lFCCGOBeSdXFVDC7SLYvEkF+P6DI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aUsqc4wbqgFX1BHE+7kv+Sqbj26A0sucjq/aZt0DuIk/M0fFGoEInzuMyBabVI/y318qi2LG1u8eWP/ZuBFW58p4Kbd+aUte3cr/UBL3u5fxL2In49rJXFjliZJz8ZosRASqVduK9wkjUnvdGNjHvDRm+TryJM7yxsHRcKao74k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fdpp+R5p; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fdpp+R5p" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-38101f85591so623677a91.1 for ; Wed, 12 Aug 2026 22:34:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786599269; x=1787204069; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6xzFkArDiYUJVrphFijlWZtDKj/k87XskzGvkdFKreQ=; b=fdpp+R5pOdizxM/gpWSXoFzMol+JHK25dXtq9Pvbff/y9bSwm6Jhle5vYUqdvENkAa ciOKFBmQ39yY0Cu35hrCJl1TAVRTQlCL++rq96pbpNravcV2AC6dL1RyWFKFklo35GIc SViRvMkUoZdhISEWZO4NDlzd+dbVQCo7LRGJrnSQDGGE/vCAWxUZPZmXE0P/JDk/9Ikc hIReSxJeu9faoov/jwRc48EPBbRZXlzI9iGPOYi0aTvJmsnVgCACZWkRPSiy5xRCJql0 0zq9fNRRQcfPo+/ES7v9pJ4TSUfOMf2qxUEecC3tySp70R+p4OB/dqzBlxeGWrNtTuN5 XQcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786599269; x=1787204069; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=6xzFkArDiYUJVrphFijlWZtDKj/k87XskzGvkdFKreQ=; b=llfSQNAZxtL7fnM97Tmlb0rlPVlFEu3dnFcge/NVZ0hxOM9RJdwcoRx5a5DHB4f40z XdIwmbHVlkbuyub8+g7IukmzO/z/KcOYFe+PMeWqpW7RwpyP0G2tBg+eRK/OXlnR31k7 BY7+m8H18wWlYJy4eO3rAunQtahRnIOtzPseK7bPKs2tlS9WNhdMji/tySdDLAw94e0g 0Jt4WDA5ISf0eweia/waSvl82W65VH1ksq2X8tAG5a+pl2z0blLEufR5aWeYMbOBQUo6 4d9a3qAfB/5aM0Z/7RRf2+bROtaUu/LbcRzi0rPpnDFJXxXLX0rMi/Tr7L1/SUUL8KYG tsWw== X-Gm-Message-State: AOJu0YyNP/+h5rl2BGaOGVhOl2R0TennpsSOaEJnQsunVSJ3AoIglAsl fVim1DYq4Aia2r/ZLc6ohDzi+bcWZcYU0zZ7X6c+1+aGuDhhgvXk6xVS X-Gm-Gg: AR+sD1273PpU20Ec0sFQD/jRKfZDYUkdh9rj4jlbKMA3MsTxa6ye5O1QEg5S5Bjv0Dj ZYCFLqiJJtlK2vUUyuvrQce5MgpBL246l0fgfw/Ip+Iqv1zYV2v9RcHFdKLZ1DwfD4C4JNNS0EL GzjuFsFmPwU5V8Oyr02ry6DWZpY3On9KUzjk+zUNIF0wEoCvTIqc6wtrydOY4DGenrzSxNNzxHV imku/7/JwmIk69Uum+yjSZCobQehBLTltu3c6edwCN/GsQWwj4ozBE/RjQiIA9U6WaBEQOoHYcB TFJDDui1Q3hIBYQcjXZxRpslURM1I2rrOtJYIRU93pGOqQgVbxc+p4l0wlqaSkEIYv7DrmhdJ4b 1sKpwfGBRrdV6oB+gihgz3evbEJILpnxV9zvU4s2E4IAgVhTrVuIVNBLnBV91ulgdHcxXg2jujM rZKHgsffZ8GDZvuHds7b8ZdBKV5eYomtgghBf7KDX3PYYAerr0MArEG1ylT+/6f+h5XDo4a4h+v ypdG54jOdE+wMDJSJnvdRJFWx0GmBk9JXKGylyKbZU8Nke+A4IoFp/eAjMSlcfCCGMOkKwW8s53 jbcX0knQxi82bzCkRxK+CXNz6Bs= X-Received: by 2002:a17:90b:4990:b0:38e:b3fd:d584 with SMTP id 98e67ed59e1d1-3931f94365cmr1262125a91.15.1786599268892; Wed, 12 Aug 2026 22:34:28 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3931d872ec5sm594734a91.0.2026.08.12.22.34.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 22:34:28 -0700 (PDT) From: phucduc.bui@gmail.com To: Ulf Hansson , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jisheng Zhang , Stepan Ionichev , Colin Ian King , Pedro Demarchi Gomes , Osama Abdelkader , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Cc: linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 2/3] mmc: davinci: Handle errors from optional IRQ lookup Date: Thu, 13 Aug 2026 12:34:03 +0700 Message-ID: <20260813053404.21553-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260813053404.21553-1-phucduc.bui@gmail.com> References: <20260813053404.21553-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc platform_get_irq_optional() returns a positive IRQ number on success or a negative error code on failure. For an optional IRQ, -ENXIO indicates that no optional IRQ is available. Other errors, such as -EPROBE_DEFER and -EINVAL, should be propagated so that the caller can handle them appropriately. However, the driver currently stores the return value directly in host->sdio_irq and continues probing. Propagate negative errors other than -ENXIO. Signed-off-by: bui duc phuc --- Changes in v2: - Use parse_fail for proper cleanup on IRQ lookup errors. - Keep the value returned by platform_get_irq_optional() in host->sdio_irq, since it is already checked before calling devm_request_irq(). drivers/mmc/host/davinci_mmc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c index cdb9fa94b56d..773577a10512 100644 --- a/drivers/mmc/host/davinci_mmc.c +++ b/drivers/mmc/host/davinci_mmc.c @@ -1249,6 +1249,10 @@ static int davinci_mmcsd_probe(struct platform_device *pdev) host->use_dma = use_dma; host->mmc_irq = irq; host->sdio_irq = platform_get_irq_optional(pdev, 1); + if (host->sdio_irq < 0 && host->sdio_irq != -ENXIO) { + ret = host->sdio_irq; + goto parse_fail; + } if (host->use_dma) { ret = davinci_acquire_dma_channels(host); -- 2.43.0