From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABD893FA5C7 for ; Thu, 13 Aug 2026 05:34:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786599278; cv=none; b=b4MdTQvyaHvu01xyQ0svGdWdeVKsnFDKWNK772gcNC3zS7u73wdCST1p5HAf5GK/o4/QnkPU9i6vY1E8zPlpNklqqD0KoYg61AtTJ+TH8QK1dtx/hxWs1dEuQMKFnUDzLkChrm1TubPznv4rMclx3V7bCQQmKBAgNq3aS23c4Bc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786599278; c=relaxed/simple; bh=d+qPrP6oSu2aMxcgbd5QZLwjghoOCkMl7GCAc+Moo/8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VUV/YokN4+5vNbf6SwMQbPcsOjVvvwBfC8Ioh9hf/OsW1zViQW5Evftkg78QIgqIwOWmK17rPChTFBQTm+BEadM42THkQ76L3W5k8MXnmkByoLuellbhHdF9qSdBDxnfEn90HoZaBUtrKcR1VTmzzozu1r87G0pO18Fx4XpwaWc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UcUNmA+A; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UcUNmA+A" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2cf50c6f235so25501755ad.0 for ; Wed, 12 Aug 2026 22:34:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786599273; x=1787204073; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=R9jEpSymG16S90LWBY9Z/OiKp+TcgWzc+6zLqoEqqxY=; b=UcUNmA+AOgQYdnIx60JqzkDLof6PZm6H+Ni0biiyiaPre4UCKn2iB3mqdsOI/kxujx i6Oa3QOFsMJupqPOwVAyHmAXonxrEOl35ZckiYX1KkHVdZblGnTJBAcT1PPaiBM22RJn Q8gz7HjVPrq8+4VYsGTKxQq64/NkR03QBRklNA/HJlzR5UcMIvjJ/gkCb8OWieL6NoHe 8rGTLyj1Vo2diXujeOutrDqlYTOApnE4alan+SvODjzI8LRW0lLnTQx9q3r5606rHGXB OUgDGjKgHyfFV+ruGpPbUTdxd3LO2hQbMIQU9Up4vKuB4RNWL5Kjm9yjTHNbIYv3jPG/ fM8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786599273; x=1787204073; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=R9jEpSymG16S90LWBY9Z/OiKp+TcgWzc+6zLqoEqqxY=; b=s1q5KO+7f/lA/f7aFG882dZ7Mpt20eUt3jbeACdSnqB1akPW8CLzoPUhhFlZDEFSNU l15DxhiDw1yu0iuqVjFPJrgzZ0pPjW2WfP2yNcbrfFCKKdHi1wY2tDcCk9MCvcoPkjQd 5xXiWauY54YD+tuKClbxuZsUsQaXRmkmfypKyS2xRc1D80l/ush36uPIZkbKXGkNG2N+ /Zwb6KMllalCI2THw89sjwz1BxgCcw0jrTBsq7PXxSS4/OotMDvJz0GZQ6pIgHS8MWza OrY2LdlZUUAIMbqRiNV+jpLRx7ZdtG0G5WTnmqiLrTuOUfJH3rEIV0YRCc8Pp+sV38Qy Evfg== X-Gm-Message-State: AOJu0YwFDqpe216slsMcwPQd8dptZtAVw6T8UwBVdSpBnjb6aP8ZDctz YuMOZW3RfW23CWFh9Uxp7m8lz7mOU4izocQ8Znem8w5AP0+z2pcUCByX X-Gm-Gg: AR+sD12zJ9yHrzHLKsDeEfh/QZ+BMGtBmdNqY+2qniiE6rWKpBu0DfTMJq4iALqHUxE 0AX8CmwJnZoAY9XmEmWOW6Ch1KuqcvaIdZnv+rCve8jrhdbJmi2TmbIFwFAOprSqXgfQ+Wyu7dt bO7jramykCFnuoAm0/BbW9Qe9vtHqcRQlbFQf6d127p/ufX8XrWgPC/hMun5J1W1iQUptD4EsO6 sm/MXCuPMWIdBW3VaM5bTBFjr0YIUspd5HG/0IxNm1UueT1n2lJmsmBktBjQymmuyvU3YQNMpLl XLX9q8cFzefZofsUB+ABZ9mghzZ0+K2UWmPe8PHSca+5F+GFfhM0O2CPrMbI+7AO1bfX7WnOvXd vQvhrRin5Dq2r97up+weA4jLr4Vo1XJQtfhC8Q27oFu6QpOEgK8Hua3y1ztcuJPkIoUn1cFDGyC OIY04UC63XWztpWPuxMvrsUpEGqlzFyFFkngg4ToKzGVY7gJrPwMjIutLrOygIFcEimGMhiJsA5 9wC+9OfvD4JcabGWWXnt5CZByGPL3ui/GIiNdvHF5mNY0mRpFAWeoI5hrMGaMAuJEvp8YRU4fOj b1ExZBS1VKLZkS4= X-Received: by 2002:a17:90b:52cf:b0:38e:9e9d:9209 with SMTP id 98e67ed59e1d1-3931e278f94mr3672086a91.17.1786599272978; Wed, 12 Aug 2026 22:34:32 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3931d872ec5sm594734a91.0.2026.08.12.22.34.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 22:34:32 -0700 (PDT) From: phucduc.bui@gmail.com To: Ulf Hansson , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jisheng Zhang , Stepan Ionichev , Colin Ian King , Pedro Demarchi Gomes , Osama Abdelkader , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Cc: linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 3/3] mmc: davinci: Handle optional IRQ return value correctly Date: Thu, 13 Aug 2026 12:34:04 +0700 Message-ID: <20260813053404.21553-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260813053404.21553-1-phucduc.bui@gmail.com> References: <20260813053404.21553-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc host->sdio_irq is assigned from platform_get_irq_optional(), which returns a positive IRQ number on success or a negative error code on failure. Therefore, 0 is not a possible return value from this API. Check for a positive IRQ number before requesting the SDIO IRQ instead of treating zero as a valid IRQ. Signed-off-by: bui duc phuc --- drivers/mmc/host/davinci_mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c index 773577a10512..c503e5f5c886 100644 --- a/drivers/mmc/host/davinci_mmc.c +++ b/drivers/mmc/host/davinci_mmc.c @@ -1303,7 +1303,7 @@ static int davinci_mmcsd_probe(struct platform_device *pdev) if (ret) goto mmc_add_host_fail; - if (host->sdio_irq >= 0) { + if (host->sdio_irq > 0) { ret = devm_request_irq(&pdev->dev, host->sdio_irq, mmc_davinci_sdio_irq, 0, mmc_hostname(mmc), host); -- 2.43.0