From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1645640F8DF for ; Thu, 13 Aug 2026 06:16:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786601793; cv=none; b=elt0lam3AfXSdxhfCmCeJUNQIXogQ+V7Q18PS8itBjDn6H6MRe4so2YQfvvmfQk1pwOjL45MBeOxsmDW5B36EQcdyhufDfPBW0kdh1HEot5QYb/pJQBnvsSKAijBM0dfasaWb+lYdUjilCYTG8ymVAQLDEhgz8yqrEpjDsCS9y4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786601793; c=relaxed/simple; bh=C5r6FUXnK85JITcdf5+hrKsZ0/zeo/xBEREjhDG91f8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TigAR6Es2W6vFMmiba1sEYewcH9vkZodJaquToZ9EmisIeo+SQYl93TNRyNj1QgbMyTkOStPXQGiyxsMH3ZpyB2Bhf4MgiNm795pIfw3/kskD8A5QkcsKC5jexEYy9kie5XCNaBnkdiZsbuZ45RKOkm65KBkFMzzOY2ISSS6CzE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JbDhaq7J; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JbDhaq7J" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2cab973140bso6322775ad.3 for ; Wed, 12 Aug 2026 23:16:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786601791; x=1787206591; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=C5r6FUXnK85JITcdf5+hrKsZ0/zeo/xBEREjhDG91f8=; b=JbDhaq7JDTzwS2vChkEXGloCUmZHjkilJFgOa9EpIqwyGWpN7higB725+oXByt7wLu UD6E5vRVotgadjh1fJmsf5QG3hIunBpvgVwqhouMpqAuMfenQ3Aoplz+s+8dnTlx1xAi GdOHpyaTdJfdDF323qcNoUB2h5t4ty87x4z/mZ5q0/mu9XxlP8haFaU76yDYEtthKjJ+ ykQhQI+7lnZ77pg3Vup5qp1JuRgj22FIeHglSDxmLygJ2UFYmnzENsWAIegeJnz4o8x2 0MoDvQipj3xOWr6JWmYE2SCTfpb3iTIjN7XWkYExFJM4NCKvKNzbYTVv4UoL3EIta6CC gzlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786601791; x=1787206591; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=C5r6FUXnK85JITcdf5+hrKsZ0/zeo/xBEREjhDG91f8=; b=rkrLjZgAZusyxOAOLdShdd5Ugof6CyvpGMY7u7JAWvkHS5bsNdKUPOpfUwhmW5sFE9 kRRH1SHI/eodXhSFHdq4S49OG3BckK0KVAZr8bUBp0kn8I6eO9vwiBflDrVQfSgn9Lid Pnv+s0aFdTvkdNrCBs7ws/7QI3U4vcUiwwnTziw0V10fP5Dc+0IrmUo1dn7puCdMpxWa Ph/aKPpHT7gFE+FgWLYM2dutnU9VA3JfC3HlcyPCA0Ou1+A4qy2h81nyx5z2a8I9qRqY waTeaO5M/JNd6rDgy9AHgHKmudQ5eCeyr++DP5WzMS3xdb0OzgrqeF/vbJ6DjXElvAkK SGsQ== X-Forwarded-Encrypted: i=1; AHgh+Rr5DXMA5t92Q1DsBpKy1z+iyQelvXlOidxmDpfLyj7Hb5DGiklx3dUgGSCHyXfLZb7toCpTwoviJOpbeIs=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5+wHxJQDldZVcbaA5RtaawX6T7z9YXSRtSBYwHYImlDn/dj5U shgmvZaraHpVfzVFaOS0O4SaRV5DQd5vkkfWStFk0uVCW+bw4e0WRNeO X-Gm-Gg: AR+sD10LVJbZSHtZdrzmyYKDvWyX0PVvyIOKfpXRTFRtUSPDiongawitxgLUJSVnXeV Te8yb84KFvcXXODpNJ248Kw0Dj71dFPQEuQqHANWu/uLUFyaxWgGPNVSs8Fy6Sj2/otN/ydvKA1 Z/xV/4cto3QwnU3BeC9nihh6YSu8f2OsBc7vq94m9fYYZ6RMHrxicEGioGZVlize7Rhd5WQYnS2 Lpt4ZJtDRawGlUVALpT57fVVLGl+HoVwCENh65mohFmqwcZ+gqy4ZQZc7hcdk+ITriRS48te2u7 HAQUs609sausy09YRXirAdIukrITN6qXKdiZ1HB5KmsHsQdeM44j0Bci+E7VfdPXQWe7S/BVoLr NW6y5nroT+J0pg+Ntc+TXzHJPS0R8SJ3XC5LQlGxdGWdE0jWHPQag/PnkdQEo9gTrNHFEFDsM44 0Z8qG9u3wi7uOiS75TORWJ4SX38W4nWrj5gIH6fegQIbppBrbcm1wXLTGmLQI5Ule5xP6AW6dl2 iUfF0lSE14qDQUHeUtIh2Bn+ONyzsH/4syrpVCzv3SgKaMK9SUK X-Received: by 2002:a17:902:cece:b0:2d1:1a18:4d0a with SMTP id d9443c01a7336-2d37d695848mr29190495ad.9.1786601791006; Wed, 12 Aug 2026 23:16:31 -0700 (PDT) Received: from secrnd-cstp.tailb7f510.ts.net ([125.131.91.97]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d37c41403asm4648715ad.46.2026.08.12.23.16.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 23:16:30 -0700 (PDT) From: Sanghyun Park To: Pu Lehui Cc: Sanghyun Park , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , Ihor Solodrai , bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH bpf-next] bpf: Fix stack out-of-bounds write in cgroup link update Date: Thu, 13 Aug 2026 15:15:58 +0900 Message-ID: <20260813061558.2577010-2-sanghyun.park.cnu@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <916b5920-a2f4-4b05-b86e-6a29e599ffad@huawei.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hello Lehui, Thank you for the review. > not only BPF_PROG_TYPE_CGROUP_SOCK_ADDR, but also > BPF_PROG_TYPE_CGROUP_SKB, BPF_PROG_TYPE_CGROUP_SOCK, etc. I think we can > make it general. Yes, it seems we should cover the other cgroup programs too. > use link->link.prog->expected_attach_type AFAIK, for CGROUP_SKB, the current program's expected_attach_type is not always the link's actual attach type. Non-enforcing ingress and egress programs are intentionally interchangeable for backward compatibility (ref: commit 5cf1e9145630). I think we should validate the new program against link->attach_type while preserving the existing compatibility rules. Let me send a v2 with a new approach.