From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3508446846 for ; Thu, 13 Aug 2026 08:52:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786611167; cv=none; b=iYgWA/C6hGYbQEeoZfN5Mok4TnLqp+ijNyxsYiWGys9wE5FD6NWUlfOX075HUz7ZHa6q5jtmzrXxifFZZ571YFQ5J+SwmC9HjIfOCAvm3GAVU1bIe9SNNphs5d3hH80EStTZqHy1/57GGgUYTxwAOzPXZKMPhaWg+bSJSlcQ6+k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786611167; c=relaxed/simple; bh=ldbF5ILBtjfVdXOICss/RvJxBQ+h5ZIfdab/mT+/gKk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nPQiHtbK8Y17jZyKvHXxMbJXscXu3JQkF2gS6LjqU5PpZjGfH7dy4Kc8dcuJCo2ww0674zEr118crCvNHiNb9wqEHrHvO1dJofXnMWNgUnCEh5U3P4rAp1UawD/uQNGuZ8gCLGVL3RKk1lQbJ/phBtwTNRfBQqXc3R9avy3mns8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aKMSe8rB; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aKMSe8rB" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-38ea87caafeso1784105a91.3 for ; Thu, 13 Aug 2026 01:52:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786611165; x=1787215965; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=sX9XI6O6qjCjlu3Bv7EdsrhNGWhNvzRT2+KyAOXZhAk=; b=aKMSe8rB+bOM7nIKZPrqaIcQ+zsSf5HAW4IAAZW+xj1HQJdFdRstb5GRwXycvF4ZWe E3tA9XPUX8mKMVu9OxuYTCSA5fD068gyTF0aOnASajKyEUMxvPBvevUvJfo96s+Lxuyk 2u7RHratoi2iY0o5oq9/81ncqcsicFhZDM580xHCQbrMd4fN69yinuHPe2vYjbjvdSPQ S7Zwj7wehsojA7OLR13GPTF6njsmNP4uLfSU1Mep6SfR0NOg6EfFo+Iq56xmFXuyXl7j B7I8UqyeqJGBTAIHdYNxpIhD8VPFBHuJvzN4idFBkDR6x4dJwGNrBrqDsXKDGlgbnjHr XSAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786611165; x=1787215965; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=sX9XI6O6qjCjlu3Bv7EdsrhNGWhNvzRT2+KyAOXZhAk=; b=CmNiFjdn5HPh5SopaW/NBfTtS0BRyHq48xOLEb3Fy4Mf+s7EPwxCb5lLbM3e56lxfk 1xe5Um9d5jH4TdiXW1yGitaEBtaC1gJ5HGWXegv7aEuOYrCXzR8f/bHacBIOOWISqer9 AIE3Eb/Up9tzd2YP8rSof/DhcnYeWRUjY96BIna9cbbiSauVRoKTp1FLqn0gHIqnrHFE rWAjmsYl148IyKxaFm/8IbmrAwKUJ5ZL4/zAfiMFMWAFUYFn1COwgRfpFK2rvux0V2GX lBElgj8CVUj00i50dVoXnQ927rb1llfOJVxcK7c3xITze2eil5ODhyZSBmP27u6i7+Cw /Hkw== X-Forwarded-Encrypted: i=1; AHgh+RqTX78BWT43zAIHzaO/OngvNNkFJVftmDTyG5UNu5a4ofg/cc96/nvicr11EiWjUeHwrleBJPF+qv48nzs=@vger.kernel.org X-Gm-Message-State: AOJu0Yy504l1XEwaXxvCoycb+rXcX/Acj+PGAKg0MXHJkxMiCaxR5DYI P07rLSmYnDaQ7Td0e8KBa+4v3+N/Ho8NwMmkEnYMr0ZU6PKqxIEiGc86 X-Gm-Gg: AR+sD136smpf3bg2S3UIdZkPfVG11z2Qs81WC3btwU7adO7Z4qDyEtxH3frQN4/VO40 tkSzGuD2g1tQRwgRMs1HRn73hRwE522VebgnmMypHzf7yYaySW//+kdAtNHBGi6lECGzQ2jhnCy zKoWzhSrGqM0KjtQ7y9U3PRWT6hev12sxVkwwfZ4an8vyPRIOcWr7FYMy52t86ulowJQzh4i9Go gOOt26rR1dlOirqkq6CgCuKQh2ImRtBGOAZflJc4y3rqWH9Vg87KHNfzlPt0GFMm9P2XCVIe9Ow cHIEujHGHB8tuYFcKUT0Zee/ffQq0gRe7uJREmkhkXm+PkUqUp2NSovjRCd0sBK3/YASD690Xo1 RGq7K1CBYVeS5dplIXehAkwh8ih1tt0SGI8wwjVDf/2/u4L13tc1Vs3duogqxWkZrXCRKmN6otT qamRIFgFVSEtod61KtQ17J/GkO53TPB0dVuxrag5B7uLunlMiG+Kp+qp3R196FGsSU0rJVh4BsK YAvdOk/I9e6vA4Xoq9cSHqlOoFWDq3SfF6sZwGRXu+Ik1PwyQpOtyKKu+v05qs2GEQ18q25qg/R le+sdBhNlBQIzOc= X-Received: by 2002:a17:90b:278e:b0:381:25ce:bcc2 with SMTP id 98e67ed59e1d1-3931e0242f8mr5395506a91.6.1786611165058; Thu, 13 Aug 2026 01:52:45 -0700 (PDT) Received: from phuc-desktop.. ([14.160.25.72]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31ec0223e31sm5465372eec.25.2026.08.13.01.52.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2026 01:52:44 -0700 (PDT) From: phucduc.bui@gmail.com To: Kamal Dasu , Broadcom internal kernel review list , Andi Shyti , Florian Fainelli , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Wolfram Sang , bui duc phuc Subject: [PATCH 3/3] i2c: brcmstb: Correct optional IRQ handling Date: Thu, 13 Aug 2026 15:52:13 +0700 Message-ID: <20260813085213.44001-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260813085213.44001-1-phucduc.bui@gmail.com> References: <20260813085213.44001-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc dev->irq is assigned from platform_get_irq_optional(), which returns a non-zero interrupt number on success or a negative error number on failure. Therefore, 0 is not a valid IRQ number. Check for a positive IRQ number before requesting the IRQ instead of treating 0 as a valid IRQ. Also use a positive IRQ number when reporting the operating mode. The driver sets dev->irq to -1 when devm_request_irq() fails, so the mode check should only consider positive IRQ numbers as interrupt mode. Signed-off-by: bui duc phuc --- drivers/i2c/busses/i2c-brcmstb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-brcmstb.c b/drivers/i2c/busses/i2c-brcmstb.c index 91525a36e575..3adc73f3d608 100644 --- a/drivers/i2c/busses/i2c-brcmstb.c +++ b/drivers/i2c/busses/i2c-brcmstb.c @@ -655,7 +655,7 @@ static int brcmstb_i2c_probe(struct platform_device *pdev) brcmstb_i2c_enable_disable_irq(dev, INT_DISABLE); /* register the ISR handler */ - if (dev->irq >= 0) { + if (dev->irq > 0) { rc = devm_request_irq(&pdev->dev, dev->irq, brcmstb_i2c_isr, IRQF_SHARED, int_name ? int_name : pdev->name, @@ -697,7 +697,7 @@ static int brcmstb_i2c_probe(struct platform_device *pdev) dev_info(dev->device, "%s@%dhz registered in %s mode\n", int_name ? int_name : " ", dev->clk_freq_hz, - (dev->irq >= 0) ? "interrupt" : "polling"); + (dev->irq > 0) ? "interrupt" : "polling"); return 0; } -- 2.43.0