From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD37143E9C9 for ; Thu, 13 Aug 2026 09:54:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.69 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786614869; cv=none; b=sd4DKRUpe+J96WY0Vq5/Ud58/6kWtJc0hGitjDf09RTqyQahnhzCiQCjIH7O/LnIqMkmM+5p+e1/5nw7mho2aQjj5fWDL+olndjYZ0KTRwPexkgeCvmJvHIKTL/rzedszeQv9t8yTXE/FjylphVXB5OFToqb23Ryxeknr/RSNGU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786614869; c=relaxed/simple; bh=ZrzVy4++WKAZ6CcT1q+LHfjHpB2pCNjESfLLZY0Kclo=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=ElVnfKJV56j9EsuPGYFvCQ4VaA0WH/FM02qnH0GVG52jLsnGrPrL/XTzcENuvKYtttJcXC1gmULQW3/M01KSP4AogNbixyFH322wlnN04nI3+DvoUydPHHupSAwLOaeSSOtiLqAVL4uE45GPFsh9N9X3tiJGEFrQH66ABwqJc0M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--tarunsahu.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=uclQKIWp; arc=none smtp.client-ip=209.85.128.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--tarunsahu.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="uclQKIWp" Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-490a767b782so15718215e9.2 for ; Thu, 13 Aug 2026 02:54:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786614866; x=1787219666; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=w9wwW7mRQHxWYHcAeYLej02klFAo7h8n1OW6fMkc7LU=; b=uclQKIWpjuCRa/ftQkt5IbBqP6TkufK6i0DVHPYKXKR+HEtaqOYUTvoWGiKBLJmVQh MKLGTBG6lSbxdN2nkO6qIlNyI4ugW+VaWNflSKhR4uJV7+uPCAxt1nHV03bXda8WjJ3V eR1bvODY8CjPdlEbULNhFvnm0wcueakREgURISBzMXS/CI9+f/C1MM73aoPyCfXcKwS0 6mXzS8zswpu5OYuUJ2mKnPC4BZc+9JRliDai7Enl6tj/DwPA7HB2jdZfFRDdAyuAlkI0 sOB8vYqJrwOxw1MXEXaBkGw2aU5EI3NcIOizmKCIZEeN7FVCDcs8xCHqJAIa5I2WDNyy 5TSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786614866; x=1787219666; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=w9wwW7mRQHxWYHcAeYLej02klFAo7h8n1OW6fMkc7LU=; b=JyFym1QM05XbECs9DBkbGlhFGEVn9ugj80J8tXp6kXeISWMFZ94Wo3USfjE3dTpRzE EyP/W0VcCtuWtj+PWb4lCKRErQlL4xpNEK0TCTj1flsXcLqvIYpWg9PshaMMrOhZoDNt 7Tqzo0KpsB9th1lX+Vrt3Fg5uXQQsQmOHX2CsavJcc/k5s0BZxTbs08u+HDYj4HL6Xx9 ZitvToC881fRgs/MaEQ+WPYDpR2k/uM+rP5lQ6PTa0fumme2Mj351NUOa1J4ITyMr5Ov zipgiLKSS3FUouRobGncTi4y02r5Lz0dO79pnsbkWdhP0klkwYHDKnR2NP7/OfR66Ltz n6bA== X-Forwarded-Encrypted: i=1; AHgh+RpQvQzm9vA9ij6nxpe8pQXfH+IAV0JSwQhSEKTERbMLHAszOViO8DcuRO4ZA6aFmzlQMY/wgO565byi54s=@vger.kernel.org X-Gm-Message-State: AOJu0Ywvjgg2eVPPr9fajNeyJqT7PTzskOi/FDmmWS4GD6OasTzbSC0c NshJyyZ3bW8p4KVE0/LRVMY8YTV/h6h86Fry3U5AiaCM4Cqx9xObeOvSeuu4Ap0896ThUKZ9ZCl X5ltHk38Ths1E1oR2ug== X-Received: from wmbf23.prod.google.com ([2002:a05:600c:5957:b0:495:5899:6e45]) (user=tarunsahu job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:b99:b0:499:7a5e:4c3f with SMTP id 5b1f17b1804b1-4998215a94fmr44349825e9.1.1786614865465; Thu, 13 Aug 2026 02:54:25 -0700 (PDT) Date: Thu, 13 Aug 2026 09:54:19 +0000 In-Reply-To: <20260813095421.1700945-1-tarunsahu@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260813095421.1700945-1-tarunsahu@google.com> X-Mailer: git-send-email 2.55.0.699.gb54405d56f-goog Message-ID: <20260813095421.1700945-2-tarunsahu@google.com> Subject: [PATCH v2 1/3] ARM: locomo: use put_device() on device_register() failure From: Tarun Sahu To: "Christophe Leroy (CS GROUP)" , Madhavan Srinivasan , Russell King , Geoff Levand , Michael Ellerman , djeffery@redhat.com, Nicholas Piggin , Greg Kroah-Hartman Cc: linux-arm-kernel@lists.infradead.org, dmatlack@google.com, Pasha Tatashin , souravsgl@google.com, skhawaja@google.com, linux-kernel@vger.kernel.org, driver-core@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, Tarun Sahu Content-Type: text/plain; charset="UTF-8" When device_register() fails, calling kfree(dev) directly bypasses the device_release() callback (locomo_dev_release) and leaks internal driver core structures allocated during device initialization. Fix this by replacing direct kfree(dev) with put_device(&dev->dev) when device_register() returns an error, ensuring proper refcount decrement and cleanup via locomo_dev_release(). Signed-off-by: Tarun Sahu --- arch/arm/common/locomo.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/arch/arm/common/locomo.c b/arch/arm/common/locomo.c index 55e360452828..0f6689d343b0 100644 --- a/arch/arm/common/locomo.c +++ b/arch/arm/common/locomo.c @@ -223,10 +223,8 @@ locomo_init_one_child(struct locomo *lchip, struct locomo_dev_info *info) int ret; dev = kzalloc_obj(struct locomo_dev); - if (!dev) { - ret = -ENOMEM; - goto out; - } + if (!dev) + return -ENOMEM; /* * If the parent device has a DMA mask associated with it, @@ -255,10 +253,11 @@ locomo_init_one_child(struct locomo *lchip, struct locomo_dev_info *info) ret = device_register(&dev->dev); if (ret) { - out: - kfree(dev); + put_device(&dev->dev); + return ret; } - return ret; + + return 0; } #ifdef CONFIG_PM -- 2.55.0.699.gb54405d56f-goog