From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8C1E43BDA3 for ; Thu, 13 Aug 2026 09:54:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.69 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786614870; cv=none; b=YPxxHONlzbDeCyiSzLNatwEVEf/oypll4mjkHjufFAU5jLGc0DxpHb4u6IuHg/l5cxyYDQpaSKQVYXezvwsJgsBtx0p9xpnLXH1FJiRAruQ4A5IFaPMzseY6TpJyhgTXKUHos4wyZdLi6y6XByZ90xYichQMhxQBcU/qs4DYtdo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786614870; c=relaxed/simple; bh=11qx+PtQ2pEMxgdfrgkekO+lbmRjyJQJNdojVzW2Rb0=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=htRNGia6HwNEXckdhXFMa5lnGMDIji3dYRpVJxZKBfD+c+vS1x2ancc+C7w7koOz+5To8AaFlkk1yP+PsmkwURnlwigJjreM1rCbL+7MA0TNqXIqByFkSVvt6GYd3wqDDhVal/FO0BB0LdlEsVV8TakUK78a3kQhqqk6JcvbI7Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--tarunsahu.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=wHvwPRKF; arc=none smtp.client-ip=209.85.208.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--tarunsahu.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="wHvwPRKF" Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-6a17bf3d42eso1729249a12.1 for ; Thu, 13 Aug 2026 02:54:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786614867; x=1787219667; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=c+Ghwm16zCb3XluSdXC+OMNEFWBin0x6u6wWkTNkW+w=; b=wHvwPRKFo8XuStYnPaEmx2Mni7BLUa/I3EPQYqScOaOuJF/jzc9ELGEYaW7dbHD6iI 1pUAkS2LUkPOw7e1f3UhHi/zQv9JitWaFB7qEzYQFuG6vhEJA4M+YTpa4Ia7RzWm/VqH 5impy7UTiDbJRFP81YPVKBNPH4mJesZ7c3UH6PEDit+Whjdqd3rDt6WgicXAlINVhBXJ LO7h7l1wif2KAXr3IJe8eDpVwZrZhEWqGk9zYuW4dJPJr8ezQ9gUXKCbzQo2Mg7TLhhC J/apAIb1FOqWSRnV2VaieWQvK9aFMVejUM35mC+ap4LdXQ6nQevWY6uQweWm9TN53sth NfHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786614867; x=1787219667; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=c+Ghwm16zCb3XluSdXC+OMNEFWBin0x6u6wWkTNkW+w=; b=B2Vpo2qTAgcZ7MyBnYJLu4vkJWznpXItLRbErIWLxk4Sj+AjsMUGLaUHuwayC0S0+a OodGXpt1kZaPz8gR35egqkHdZeDTU6VOTgEw2W5eZGsVXoWazTGmcYFcmSve6xYy69b+ gw6MehQJNnDqg4Cq8ZKGFzAftNEHxnuFyRjyhORBBHBtXDrMHcvtOyOUblwQqatTgEGm 39rLsYH4zxIVOL6c0yT6O2fTDTqsQhLt1Z7kNFfGm64QVOs5XcgBxsdg2asPzkScDD1O ieYv8FFEBIr80fZgs0cqHqm7q2sFIiaxdOy+4pn/pjWjVXQdxiOqUFGR7GLd1FThuBUw PdpA== X-Forwarded-Encrypted: i=1; AHgh+Rre4XCLSOaoOoknHkhUAGJZobnbIjRt0ffmQw+neT24WcqLzBIOt0dyHCOoHzunNRT1r4N6LxtZBAy9PEc=@vger.kernel.org X-Gm-Message-State: AOJu0YwrnD00NvqjNbt/VFHMFiCQ2Ao4NG1KT1z09qw6mLA17WuG37nU +YCDNC5ztuatGd0NebDRDzfvAYvm+xJEYTc161yrsSfg3zMixAoHgJ/xcNtew7hpg0e4UiTmJEo 9khm1/EYjTZaQmyN0sw== X-Received: from edqz25.prod.google.com ([2002:aa7:d419:0:b0:6a0:51ba:9873]) (user=tarunsahu job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6402:1948:b0:6a0:a4be:6ed0 with SMTP id 4fb4d7f45d1cf-6a380618f4emr2015007a12.17.1786614866346; Thu, 13 Aug 2026 02:54:26 -0700 (PDT) Date: Thu, 13 Aug 2026 09:54:20 +0000 In-Reply-To: <20260813095421.1700945-1-tarunsahu@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260813095421.1700945-1-tarunsahu@google.com> X-Mailer: git-send-email 2.55.0.699.gb54405d56f-goog Message-ID: <20260813095421.1700945-3-tarunsahu@google.com> Subject: [PATCH v2 2/3] firmware/edd: use kobject_put() on edd_device_register() failure From: Tarun Sahu To: "Christophe Leroy (CS GROUP)" , Madhavan Srinivasan , Russell King , Geoff Levand , Michael Ellerman , djeffery@redhat.com, Nicholas Piggin , Greg Kroah-Hartman Cc: linux-arm-kernel@lists.infradead.org, dmatlack@google.com, Pasha Tatashin , souravsgl@google.com, skhawaja@google.com, linux-kernel@vger.kernel.org, driver-core@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, Tarun Sahu Content-Type: text/plain; charset="UTF-8" When edd_device_register() fails after initializing the kobject with kobject_init_and_add(), calling kfree(edev) directly bypasses the kobject release callback (edd_release) and leaks the allocated kobject resources. Fix this by replacing direct kfree(edev) with kobject_put(&edev->kobj) on registration failure. Signed-off-by: Tarun Sahu --- drivers/firmware/edd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/edd.c b/drivers/firmware/edd.c index f980c5b56858..763e7b16d517 100644 --- a/drivers/firmware/edd.c +++ b/drivers/firmware/edd.c @@ -748,7 +748,7 @@ edd_init(void) rc = edd_device_register(edev, i); if (rc) { - kfree(edev); + kobject_put(&edev->kobj); goto out; } edd_devices[i] = edev; -- 2.55.0.699.gb54405d56f-goog