From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05072463B88 for ; Thu, 13 Aug 2026 11:10:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786619449; cv=none; b=I/vrDCPvL/LKZxsSzz/LGuyChDA+1oxb096XpNOKDzfuioZc5YD0nVfCH1TaU2imIeQHtitco/p++4jKrLl7836dqplI8tfKcr2DpFCs81Rj2eLi6SWMWc3+FsMD+vkKnBsm1jCYZxm9UISWGPlPXNpbFKW0xrz5NRoRdp+NCUs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786619449; c=relaxed/simple; bh=Wn5FH2Qdib/LYSpamWWjNLetgJycofQ+KaxeeNkHZgc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=PTH1pkk/7tpzRzKC3svFztVnbsEV2ktIsT7bN9Hh5RW+9zE8xPYs/CfvPBFHv6GEmBTwfzyMRfV/4SSUtqCt/fhbW+7pGjmoNylztIJzljGqfrfCLsR3f3qHRzkuBDK091KP2C8Uze+Q2Tu9aSNzKDSXZJgOhh9esaBCfXB+dz0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gyaP34RL; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gyaP34RL" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-38dc69c74b8so768521a91.0 for ; Thu, 13 Aug 2026 04:10:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786619433; x=1787224233; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=TPEMR8s91oCRNTEPx4cjBv4/QdcijBwc2O/2txPE2jQ=; b=gyaP34RLQRzVlVTS8/0ZfuA6dk0NrfTFFZtbHEKO2jOmkm7Fi3ZIgyfFyKlxg361u7 imamG6uMv7MPr7byn4Jer80/fMPJDd+je8ON6axk+lNz9F3kCDJaX8Gyzs5vJ3hpH8u9 rYGVmZB7JIdOyoZ3zMkSzFyEhkU+vbf+DaVDLHvV29CSLG+NZQdf4UmxWgJQDpY28GjD +HAiRHCpQYqpNBKEEV1yfB/IPrOuqtW+bensPrv9drVlwJCAXlgjcBz3AhiYytsK3fG+ Dix+CM+q1c1hwwkP60UiM4XfRWOhopchDvsEWTBAPW/acUT/H1G81G6Dw+f0W2sSMk49 871w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786619433; x=1787224233; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TPEMR8s91oCRNTEPx4cjBv4/QdcijBwc2O/2txPE2jQ=; b=kF/ii28Cj8u2FAG4Eh1oZQXdZ5UyGrzGc5XmsmGyCdUoc7Ug7fA/nnR1QErlT+T8wP BMXBRekRWxd/JumQaQaF9pJX7e+ejfa7mIHdP75+yv2U+0FQBcvOPa7WtHTdbD58lOke wEmtUimk1DpB7rMPOuotLGLmhSz+eQgdJCWHSOecr9TV7alQA74YwXCXfhzd70K1cSft El2KTagfOIk8x5JZxh4e3iOCRmZW/HZAs5ysLJonc/p6M01O0u+uaze+L6fEhQ45vfqY pFKZZPBFUnGIp1gEEc3PHa77yMZJxJmiFtZJglqJDpdeODZ9vPOSODTk96/xVswtey0L UaiA== X-Gm-Message-State: AOJu0YyRxckNSIVEz+/VcErgZ97FVRR16RlhvgUIGgzS3Fx/JKWRNQFo Tmhrew1dPNHoauWvEpiA8UU2gj2guaCaXUEo/WkiUjlPoMMr5+Daeo5y X-Gm-Gg: AR+sD10Mb4a3mFqd7Y4aoitdDrxEyk5x0xnJ3LX4uDft2wD6Z2JWb2sH9dmW3CwAtOX ng8XntdUAkaJGndmfpmkZvoicmTDaS5W0KkjhGnv0bWfeUD3EGNUcL93pUwawH8CLK8SNlIMaOF 9UiXZQ1WS0p+7Bbs1Pbq/nJdPALfXmflDi9i/Vpv5IZvXU51bnIuDIAcg42mu1sNKLn0jPiCWEH aBLX4UyDn/0MXsu5NImUspFGdSSNeodsBMoI9OCUXaBd2A8q8OD47s3zGYnsm93368lb4lLcnF3 O9/hCUGVWyOR85fXC4iO/ymTxwP1fcIANzt1HWECrmyNSZWkKlP6IIFFUB2ruePsUall7k4AO8v KrcjQdvtjSuomjUYE2s+A7otQiqXkElC0sm2lxaxIncXHi2SH6TMheLaUaHoYGkSFOeWAU8M7rc URoEfrVYRAZmuYeaacyQ4uEd9qUgHwK1uFioof4Pv1oxKLYW0j3Mrw8NuclP9cHqM80/NCMpxzV h+lM3qTFVrViLqM/QKzqrV0ZiA8DVqajOozk3juV7es00gAjjwU08JNYC6pUmN000gPM/Vv+MFQ qcEaHwSQpiD8 X-Received: by 2002:a17:90b:4a10:b0:37f:be6c:f3f2 with SMTP id 98e67ed59e1d1-3931dfe0fdemr4953305a91.2.1786619432138; Thu, 13 Aug 2026 04:10:32 -0700 (PDT) Received: from localhost.localdomain ([2406:7400:94:ab62:887d:e555:df21:3318]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1412d8bd946sm8358848c88.5.2026.08.13.04.10.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2026 04:10:31 -0700 (PDT) From: Manush Prajwal To: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Manush Prajwal Subject: [PATCH] bus: arm-cci: fix device_node refcount leak in cci_probe_ports() Date: Thu, 13 Aug 2026 16:40:14 +0530 Message-ID: <20260813111014.895-1-manushprajwal555@gmail.com> X-Mailer: git-send-email 2.46.2.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When the number of matching child nodes reaches nb_cci_ports, cci_probe_ports() breaks out of the for_each_available_child_of_node() loop without releasing the reference held on the current node. Every other exit from this loop iteration either continues (handled by the iterator) or stores the node into ports[i].dn; this early break is the only path that drops the last handle to the node without a matching of_node_put(). Add it before the break. Signed-off-by: Manush Prajwal --- drivers/bus/arm-cci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c index 7f2baf0571..5ab3d74c9a 100644 --- a/drivers/bus/arm-cci.c +++ b/drivers/bus/arm-cci.c @@ -461,8 +461,10 @@ static int cci_probe_ports(struct device_node *np) i = nb_ace + nb_ace_lite; - if (i >= nb_cci_ports) + if (i >= nb_cci_ports) { + of_node_put(cp); break; + } if (of_property_read_string(cp, "interface-type", &match_str)) { -- 2.46.2.windows.1