From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6BD8404BFF for ; Thu, 13 Aug 2026 14:24:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.92.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786631098; cv=none; b=dIAcrms4Nu619lyEdX6u/SSZbHibvwgS3fQH8LDMVjubeB1jROZx+hoDnD8SwiyNwFedovK8rCXNM/IG54IJFKHm/Nmg/4j5hJ19RT76/sUh+ZpVxowXoqzSPIPczBLwLDUArHtrW0Gd3tsG+67uP7vhs0WmR1KpWrRugHQSNF4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786631098; c=relaxed/simple; bh=PVUTFjdilo3C6B/bS9tDq0BxIfqFDm9y8Wl34+b7ukE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=M098MYl9Gbw1PM4Ej3J2zfXLuL2dZ2MoNMbKhz+amn9HvKWaOe9tjYwnfKWEPUQ2G2MB4maE79Nz7wS+vfPkX7GOR72sOm913M5tAgU6YTB1LFv2WCVA6VS9ck84B9XkHRwdVVKp/BuVcGQU2cbj52iwGiZaF+5w67CrLzkKXz0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=pass smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=l1Rz8dTs; arc=none smtp.client-ip=90.155.92.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="l1Rz8dTs" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=q9QNdpxU0/T2F7GMHiAkHG2Zmnpp9e/akFiDLL3tm9o=; b=l1Rz8dTsQ8QmcY5XxUES+6qXXK esP6CMf/aMJaIenikrKz89kADd1SFA1/YZSu7UEjwYXCSgAS9A+tnG2fTisqcXKT3bZEnToJk8ZAY OL0xraoGhE55SolDnya5r4o0l4mADwjpT3nzilt+lcZHPPxjYUlVhaEZEPByhRHPgkajbew0pl7jw PgUDrXoxMxNYJhOsUI3rmPbEwnKhkVos5+bjseJkLUQDnBp+92+oZxr3dMHGVzWxSflBDs78YkSyN oxrGoz2f5KwEQuKXYruxxM7Cwrniw60Ka7WTFFap/IkEWdE//CbfWFKWNbgV22uINJSxlc4QIWbCd 1InsNfSw==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.99.2 #2 (Red Hat Linux)) id 1wuWM9-0000000GFFl-3xAV; Thu, 13 Aug 2026 14:24:30 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 0881F301127; Thu, 13 Aug 2026 16:24:28 +0200 (CEST) Date: Thu, 13 Aug 2026 16:24:28 +0200 From: Peter Zijlstra To: John Stultz Cc: LKML , Juri Lelli , Valentin Schneider , Connor O'Brien , Joel Fernandes , Qais Yousef , Ingo Molnar , Vincent Guittot , Dietmar Eggemann , Valentin Schneider , Steven Rostedt , Ben Segall , Zimuzo Ezeozue , Mel Gorman , Will Deacon , Waiman Long , Boqun Feng , "Paul E. McKenney" , Metin Kaya , Xuewen Yan , K Prateek Nayak , Thomas Gleixner , Daniel Lezcano , Suleiman Souhlal , Andrea Righi , kuyo chang , hupu , kernel-team@android.com Subject: Re: [RESEND][PATCH v31 8/9] sched: Add deactivated (sleeping) owner handling to find_proxy_task() Message-ID: <20260813142428.GG788244@noisy.programming.kicks-ass.net> References: <20260807035232.1881495-1-jstultz@google.com> <20260807035232.1881495-9-jstultz@google.com> <20260813134823.GP776954@noisy.programming.kicks-ass.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260813134823.GP776954@noisy.programming.kicks-ass.net> On Thu, Aug 13, 2026 at 03:48:23PM +0200, Peter Zijlstra wrote: > --- a/include/linux/sched.h > +++ b/include/linux/sched.h > @@ -1261,11 +1261,11 @@ struct task_struct { > struct mutex *blocked_on; /* lock we're blocked on */ > raw_spinlock_t blocked_lock; > #ifdef CONFIG_SCHED_PROXY_EXEC > - struct list_head blocked_head; /* tasks blocked on this task */ > + struct list_head blocked_head __guarded_by(&blocked_lock); /* tasks blocked on this task */ > struct list_head blocked_node; /* our entry on someone elses blocked_head */ > /* Node for list of tasks to process blocked_head list for blocked entitiy activations */ > struct list_head blocked_activation_node; > - struct task_struct *sleeping_owner; /* task our blocked_node is enqueued on */ > + struct task_struct *sleeping_owner __guarded_by(&blocked_lock); /* task our blocked_node is enqueued on */ > #endif Oh, cute, that last __guarded_by() isn't right. p->sleeping_owner is in fact guarded by owner->blocked_lock. But clang isn't complaining :/