From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CFE348D868 for ; Thu, 13 Aug 2026 15:31:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786635118; cv=none; b=Dpp6wk1bdN0ZbALSDTOGuKf1ZViyHVNyUdcbHVYRqbBlY2hdDlj0/qB7JNWcxyfHy0ITqvSueIZms7DYPtALTlMpaBPR1h4u/Xf+w1OgTaoAxtnc2PjCy6+vkvwMi3JlXwdOclo+HPM8I1XuX89ecG5FwIEt5vYKY6psjhPPiUw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786635118; c=relaxed/simple; bh=6/z9IRV5ZQn/Frw7BWoJwC2CimqWWJl4hMDciS+A1D0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gjCM5CEcm4nCmR2ZvD/MTZZNxLQ5LqSjZQj4qQLYxSryjECsIDH7z2n2hwACmphDfV2oaMwRGjG5yTw972g9X4F/ZGjclhJS/1/kE0cTKDD3D0m7KVlYXiuwqcZXg6yYsj+PIi+VFRqc8RxTvgPiiCaQKYG0wwkJ2udABEsc9DI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iVhUKz6t; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iVhUKz6t" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-c9aea40d799so1410461a12.0 for ; Thu, 13 Aug 2026 08:31:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786635116; x=1787239916; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=lRy+t8tNDkimDr+BoBwwY6yvO7nk9mVt02bQsB0YYA8=; b=iVhUKz6todDkgwKQ4DI2oErKKRfJTpIoP2RDQpIlDVZg+orUa6PUB4kcHcEbCB5166 Zi/YS6Rmi2mhyx5QB6uuHBhaWcH8xq9W0aDq1WwrLYruAqKsuTHLy1r4AdulR8Ph6gX3 qiDgMZbZkEzIPcuT4CHSpMtF/z/EbHu6s7FXu+qLZt7BJ7aCKTC/EoAFjcpxOqvQa7oz tuyMYPUdU+P4NS0vqj9Dfes4YMTe21gfpjur1DQ97vH1+CN4KUylXPRlZxNf3DrXBhVa KH/WdB6/mXrW4jhf8NDQbGCOgpIpm1cGZxZZ2+a55szB35Ibwu+Kri92EPToAfhsY28t fzdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786635116; x=1787239916; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=lRy+t8tNDkimDr+BoBwwY6yvO7nk9mVt02bQsB0YYA8=; b=qxMJx2zXtnFU2+pQry0WIlybdgCoVbmOf8YP2KHrXAZhoof3PIWCO9OFtnwPC+8U+S EgoN2iKeKpKKd/HvJV9F2uZderGMezKYfvZyA1NneTBbbnOCN9JAo1FsTL8jgoe/77Hi nZCFoshRKJVgdyWrLqQYMZiJp2G0wb9BvE6RR0eoNHozK0l1GMWRPTRzNSpO8t97SFT4 zl71F1etDzHC2EZLIWiX3nBwokZ+AdVlywC4FTdnac9KXW89MsmXs0cejAGR0MvFOzvQ XAht6kfCeqSsvXa4LaR+495ncR1Vdjve3bBcRq7d8WB0negV5r6ZNcQTv3lR91Gb2tUN 7eAA== X-Forwarded-Encrypted: i=1; AHgh+RqzGCAd4lIjEnTbs1FqU+JI26AYat/lz5zZgLG3Fk3JUyy4lXNI5zaHEIJ+9cQEm1ZK/LA/v9Br6UC2LrQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzsN7DW0yU9ZkBpNRZk0Y8twt+unZBZPIitdMPwjdlYlqO7yD6f MVKFd3+FVMRuYRsHi8YVkdMYGr2Q0rTqWw3gs8bluclCerTh5C0CdLYz X-Gm-Gg: AR+sD104jrYEjWbc9CC8DfOIvwy0wHsmgnbvsO8H7PiS3BQGcKRLg3F9sdr1ECIiNB/ a0JFbW1Ev/1kNHYVEuHOlgA71kAER1YRakyAZqzJQzjLZyIl9kir2rEZVkASJCJS+OSmq96jF0c gVzg7lH/MjuIbRj1ScJMGO5USfJVy6eLEFe6eoDwYXCwCYdBtJ0yHt7SbajV1Iczz+5IiMQsOl9 cc5+ldiSg0mYsX0Wm1gf2bHZTMSN1MmTdbGhI+odv4VRs/d7skNXvkB/UIeQi6AR0lMYkO4Z4WU iarG7bIFG8kQZDABi1tY6QjtvTWEoU8T1nZcKQdOQhdpbf7URIK4m7H5m3a0UpdxiBWLjzb2x5h Z5oE2NNiQSVw1G0B+DAefoMl+UslKIg6VuErSytNiaFD4XViuYFJs0kDjRQtDG5OyIzEQCxWA7T aXJUvhhgznEwRkOkdAdtZUxzJzwQuKgD7YAq6IG9HzGtRyfeCNpy3YBWSVJhdhGW6gmCcQ7KgDQ nmiG0dv0T3ZpYxJAA2/EhZ/w17q6xKMiUTaSWWQ+P4qZUVYzwmA6Gso3ZTUwg== X-Received: by 2002:a05:6a20:2589:b0:3bf:7bf7:7913 with SMTP id adf61e73a8af0-3cc5503a34bmr8643790637.14.1786635115961; Thu, 13 Aug 2026 08:31:55 -0700 (PDT) Received: from debian13.localdomain (bb219-75-96-14.singnet.com.sg. [219.75.96.14]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31ec082943fsm7960604eec.29.2026.08.13.08.31.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2026 08:31:55 -0700 (PDT) From: Adi Nata To: lorenzo@kernel.org, jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linux-kernel-mentees@lists.linux.dev, Adi Nata Subject: [PATCH v2 3/5] iio: humidity: hts221: Allow unknown whoami for DT fallback Date: Thu, 13 Aug 2026 23:31:27 +0800 Message-ID: <20260813153129.12423-4-adinata.softwareengineer@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260813153129.12423-1-adinata.softwareengineer@gmail.com> References: <20260813153129.12423-1-adinata.softwareengineer@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The WHOAMI check currently returns -ENODEV when the chip ID is not 0xbc. That rejects Device Tree fallback compatibles. Keep failing if the WHOAMI register cannot be read. On an unexpected ID, log it and continue so OF fallback matching can work. Use dev_err_probe() for the read-failure path. Signed-off-by: Adi Nata --- drivers/iio/humidity/hts221_core.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/iio/humidity/hts221_core.c b/drivers/iio/humidity/hts221_core.c index 76a391f421f5..b73c26aae9ec 100644 --- a/drivers/iio/humidity/hts221_core.c +++ b/drivers/iio/humidity/hts221_core.c @@ -136,19 +136,15 @@ static const struct iio_chan_spec hts221_channels[] = { static int hts221_check_whoami(struct hts221_hw *hw) { + struct device *dev = hw->dev; int err, data; err = regmap_read(hw->regmap, HTS221_REG_WHOAMI_ADDR, &data); - if (err < 0) { - dev_err(hw->dev, "failed to read whoami register\n"); - return err; - } + if (err < 0) + return dev_err_probe(dev, err, "failed to read whoami register\n"); - if (data != HTS221_REG_WHOAMI_VAL) { - dev_err(hw->dev, "wrong whoami {%02x vs %02x}\n", - data, HTS221_REG_WHOAMI_VAL); - return -ENODEV; - } + if (data != HTS221_REG_WHOAMI_VAL) + dev_info(dev, "unexpected whoami 0x%02x, continuing\n", data); return 0; } -- 2.47.3