From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 387B948C41B for ; Thu, 13 Aug 2026 15:32:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786635131; cv=none; b=EF4jB+ppTAVm9bYBvzc+QJ5VZEq89DQZRPzt6jy/lY1f6mOKxqDwdoujQGVTxFV2lEBj03Kf36Ba3Wat5o/VpB2D+jkV+ThRXYmFhzMj2lJ48f2lIuaslg93pbqFCdDGas6y2egxoLEmanwfpNygCDQPB2kThnmWUPND9pP/7cg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786635131; c=relaxed/simple; bh=sfBAezaRbgRTasTkRdf7Yl4IPx6PAR6DvqI2G38FvDA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cIWVuDyUl4wq21MXnV0QJ7T8A/3hXLmc+9sLatZsFC0ffL2dfRTkRzcN7Mk0iwQbgF9g1aUQKC7STCG3E0BMo+0i3xsUIfsgS6YBmq1/I4fF/H0cnzTVzXw2RMD2p+SNmWPkPAbKisGIyLtFiaUySULVHIgCqJRjaOijAAHRf/U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LPo/RxGr; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LPo/RxGr" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-38101f85591so1124910a91.1 for ; Thu, 13 Aug 2026 08:32:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786635129; x=1787239929; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Q2qdJ72LpMBcvPrJb15/0HrRL2gmcJhiINfNwI4WIvY=; b=LPo/RxGreTuVBvodu6e5CRs62zGeuSd4AXYxN6atXQyh9vFIKOdKjKx9QM7QNzaof9 PmKchn8EbSxTfBZGVnOSxLVkhuG+HGatOBySRk9EDM9UPUNOzhOeIGjK20PE8SPT/i5F mfwROpeQQMVA23GL21SDsIh56fHP/TxSYrl7z59leJUCdlca7kU15tWMirEjIPtMBmFw n+O43djMaKyYrJJZ188ffZWpl0RDtWm5Mj9V+ex+pMxFuc4yQyXdBpN61xd81nF9a/WC TXLOqJOwVZVnBF65deEiZbppGKp25nzKINTpowFeR5hzyX2+uFZqBFwLMNM6FfzfGncA poaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786635129; x=1787239929; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Q2qdJ72LpMBcvPrJb15/0HrRL2gmcJhiINfNwI4WIvY=; b=nZtWNY77kIL3SfpoaszYq1rwhpXDoCV6VVU+Tb3p24Olx05t3X+IT3vUJobXAHtFuq xoYecRc1wK2/2KsFC25UWTQU2gvXsoiAS9RzbsA2Sc1k1NlzDMV4bGYtEN0LgoMZpxWk j0SU0Sk6xuTNnImMsmfBKA/S8TKK1pjc/4KbDIuFAV0HafA9k6AxK7ANGQ25fHjXgyOz d2N59fbN/EUFL4BKyKP9WCkIKoYLYtquJIvBXBwweWkAhQ2mhgLFG9G6HJqSFqJa5mM7 13OFT7vuZRae4o/YkBPQuxQqjzK6pFAtSY8iKw6HDjT3Ry4PmaHS/CZ4qY2ye+N+1xBh js8Q== X-Forwarded-Encrypted: i=1; AHgh+RoZPczj9obVOaDXd5tz5eD1hXVI7b5T+xp6w5fc4+yAFUL0PZWyqd9cLqYIIzU3/n3/jLqUnWhNKWte4JU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7oe/KHQ+NEfgOElsoDbmeeq2HtgtD5c++GwGRFAHOI8/HyA// fdieXBUbSAlq8CTVOU3lwNV0MSW5tPe0wIoMbNqEfQ1Qjwr/kmWg6qX8 X-Gm-Gg: AR+sD11Jdr58WcudY2LnT72qSK0RwjbmuevmmcPGpovrApykjVLUgrClSSpCWHG8juk LxmPevSIP1+sgE24lOmf/WYFSYZ25wx94WwF2/+7kQn+v3VghmKHqJCBhsTwG7dYtTEgsPy8MOt 3ZDSskV3uzzTNBTSnPcAduayyWp9pnwY9l/NNBgZurCn8T7IQoVCjSIwCIuOAegKsS9Gyix1iMn rqtHEEL5nG99WHfdA1RUaaxZ6CSB8wJQumjlJJCHQtdC/m9z5RBF9DpmaJwUaDqsurtgKsNrJUl a0zePXDtm+gGwWg1uPinKmiQY5nVIO5TR4DvUEAuZ7fsljzs8LbXwMW35osgBjznZ0u63GOu7br odfE1E7ED1wwbMtCVtVmTwpGgGpEyJgaertAHtKGJn9K+71NhYKKGqQZL7x4eVm6FiT9fP58Zuf laXsAJcTcyhCC+rQ8DCtmztj7gzAuCpok4vqQgdzhlQtONqsycOI5puBa2fMm1Opqn97K/XYohq IIOAbwZx+Yp8XPv9c3c3OzaZI9tYeW6c0Nq9u83j75F3QxuCSNktd4pVGkVEQ== X-Received: by 2002:a17:90b:50:b0:38e:7f22:f674 with SMTP id 98e67ed59e1d1-3931f9069femr2991671a91.11.1786635129125; Thu, 13 Aug 2026 08:32:09 -0700 (PDT) Received: from debian13.localdomain (bb219-75-96-14.singnet.com.sg. [219.75.96.14]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31ec082943fsm7960604eec.29.2026.08.13.08.32.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2026 08:32:08 -0700 (PDT) From: Adi Nata To: lorenzo@kernel.org, jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linux-kernel-mentees@lists.linux.dev, Adi Nata Subject: [PATCH v2 5/5] iio: humidity: hts221: fix division by zero in calibration parsing Date: Thu, 13 Aug 2026 23:31:29 +0800 Message-ID: <20260813153129.12423-6-adinata.softwareengineer@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260813153129.12423-1-adinata.softwareengineer@gmail.com> References: <20260813153129.12423-1-adinata.softwareengineer@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit hts221_parse_rh_caldata() and hts221_parse_temp_caldata() divide by (cal_x1 - cal_x0) without checking that the two calibration points differ can cause division by zero. Reject zero divisor with -EINVAL, logging the offending calibration values. A device with such calibration data cannot produce meaningful scale or offset values anyway. Signed-off-by: Adi Nata --- drivers/iio/humidity/hts221_core.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/drivers/iio/humidity/hts221_core.c b/drivers/iio/humidity/hts221_core.c index fda38dfc6742..47a10884d812 100644 --- a/drivers/iio/humidity/hts221_core.c +++ b/drivers/iio/humidity/hts221_core.c @@ -245,6 +245,7 @@ int hts221_set_enable(struct hts221_hw *hw, bool enable) static int hts221_parse_temp_caldata(struct hts221_hw *hw) { + struct device *dev = hw->dev; int err, *slope, *b_gen, cal0, cal1; s16 cal_x0, cal_x1, cal_y0, cal_y1; __le16 val; @@ -275,10 +276,20 @@ static int hts221_parse_temp_caldata(struct hts221_hw *hw) return err; cal_x1 = le16_to_cpu(val); + if (cal_x1 == cal_x0) + return dev_err_probe(dev, -EINVAL, + "invalid temperature calibration points (x0 %d, x1 %d)\n", + cal_x0, cal_x1); + slope = &hw->sensors[HTS221_SENSOR_T].slope; b_gen = &hw->sensors[HTS221_SENSOR_T].b_gen; *slope = ((cal_y1 - cal_y0) * 8000) / (cal_x1 - cal_x0); + if (!*slope) + return dev_err_probe(dev, -EINVAL, + "invalid temperature calibration slope (y0 %d, y1 %d)\n", + cal_y0, cal_y1); + *b_gen = (((s32)cal_x1 * cal_y0 - (s32)cal_x0 * cal_y1) * 1000) / (cal_x1 - cal_x0); *b_gen *= 8; @@ -288,6 +299,7 @@ static int hts221_parse_temp_caldata(struct hts221_hw *hw) static int hts221_parse_rh_caldata(struct hts221_hw *hw) { + struct device *dev = hw->dev; int err, *slope, *b_gen, data; s16 cal_x0, cal_x1, cal_y0, cal_y1; __le16 val; @@ -314,10 +326,20 @@ static int hts221_parse_rh_caldata(struct hts221_hw *hw) return err; cal_x1 = le16_to_cpu(val); + if (cal_x1 == cal_x0) + return dev_err_probe(dev, -EINVAL, + "invalid rh calibration points (x0 %d, x1 %d)\n", + cal_x0, cal_x1); + slope = &hw->sensors[HTS221_SENSOR_H].slope; b_gen = &hw->sensors[HTS221_SENSOR_H].b_gen; *slope = ((cal_y1 - cal_y0) * 8000) / (cal_x1 - cal_x0); + if (!*slope) + return dev_err_probe(dev, -EINVAL, + "invalid rh calibration slope (y0 %d, y1 %d)\n", + cal_y0, cal_y1); + *b_gen = (((s32)cal_x1 * cal_y0 - (s32)cal_x0 * cal_y1) * 1000) / (cal_x1 - cal_x0); *b_gen *= 8; -- 2.47.3