From: Lyude Paul <lyude@redhat.com>
To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
nouveau@lists.freedesktop.org
Cc: "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Simona Vetter" <simona@ffwll.ch>,
"David Airlie" <airlied@gmail.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Maxime Ripard" <mripard@kernel.org>,
"Danilo Krummrich" <dakr@kernel.org>,
"Lyude Paul" <lyude@redhat.com>
Subject: [PATCH v6 4/5] drm/nouveau/kms: Only allow enabling atomic modesetting on nv50+
Date: Thu, 13 Aug 2026 13:42:55 -0400 [thread overview]
Message-ID: <20260813174416.1812656-5-lyude@redhat.com> (raw)
In-Reply-To: <20260813174416.1812656-1-lyude@redhat.com>
Atomic modesetting support was never added for pre-nv50 chipsets, so make
sure we don't allow it to be forced on. Additionally, print a small warning
when it's not supported.
Signed-off-by: Lyude Paul <lyude@redhat.com>
---
V2:
* Check against info.family, not info.chipset
V6:
* Check against device->card_type so we can perform the check before
setting up nvif
drivers/gpu/drm/nouveau/nouveau_drm.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c
index d021a3049be1a..82a8061e6d3e2 100644
--- a/drivers/gpu/drm/nouveau/nouveau_drm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_drm.c
@@ -739,10 +739,17 @@ nouveau_drm_device_new(struct device *parent, struct nvkm_device *device)
struct nouveau_drm *drm;
int ret;
- if (nouveau_atomic)
- driver = &driver_atomic_kms;
- else
+ if (device->card_type >= NV_50) {
+ if (nouveau_atomic)
+ driver = &driver_atomic_kms;
+ else
+ driver = &driver_legacy_kms;
+ } else {
+ if (nouveau_atomic)
+ dev_warn(parent, "Atomic modesetting not supported (needs nv50+)\n");
+
driver = &driver_legacy_kms;
+ }
drm = kzalloc_obj(*drm);
if (!drm)
--
2.55.0
next prev parent reply other threads:[~2026-08-13 17:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 17:42 [PATCH v6 0/5] drm/nouveau: Enable atomic modesetting by default Lyude Paul
2026-08-13 17:42 ` [PATCH v6 1/5] drm/nouveau: Fix cleanup bug in nouveau_drm_device_new() Lyude Paul
2026-08-13 17:42 ` [PATCH v6 2/5] drm/nouveau: Print the nouveau.atomic parameter in nouveau_display_options() Lyude Paul
2026-08-13 17:42 ` [PATCH v6 3/5] drm/nouveau: Fix drm_driver struct/nouveau.atomic parameter handling Lyude Paul
2026-08-13 17:42 ` Lyude Paul [this message]
2026-08-13 17:42 ` [PATCH v6 5/5] drm/nouveau/kms/nv50-: Enable atomic modesetting by default Lyude Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260813174416.1812656-5-lyude@redhat.com \
--to=lyude@redhat.com \
--cc=airlied@gmail.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®