From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D133A38F957 for ; Thu, 13 Aug 2026 18:34:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786646073; cv=none; b=ZQmUFQpfAfflweao5mwPprJfAzVTnTvUby+PV0SCM4Qwe3MaamVwuqoMliYuYv8Z1Jg12VcWPDMpFKtiQN2aptZm0RI/q06g1xFgrOLbz7P/ZqnMe0fCWzin9GvpPj1es2pCTmVkDwE2YLzxWFP5g01rSnf03EeXNDGTAG03RPQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786646073; c=relaxed/simple; bh=mqYEFzcu9adlmzMlbAGBlaKC7RKZhOj1IPYoG0xJLLg=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Xtx91GIao8f6qNA9LNffTPVeHW/Nn/voFA/QtphkI69s8ZYA/eFdHxQ2bcYhq11B9iJFOuF0LTFFw8+bvigxX2wkqVEM+HoS/CxR9iJsOLcATbZAXF53syKvIshVx3cZFsfohIOpQigBCqVfk8ZCK4Iv8AUePdCLlcU/k1fAiI4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=p/OKSJRx; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="p/OKSJRx" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2cf6d65d8a7so3842575ad.0 for ; Thu, 13 Aug 2026 11:34:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786646071; x=1787250871; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=7YHG5aECJfFEafyUES+0YBuoUGPDTuM9lTTdzyRLjcg=; b=p/OKSJRxf7ptWC2hVbg2/OknYjufxh+QBNiirT0t5UCmjXMaoc5hnAAvmr2Dd2R4+M 4EtJjpqTS/xccoolIpkN2S0Z6vD14kfL6i8/AT/BLY5KgQiHCDaymj5d3sB6S0oooHP3 /MLB8CxWqNshYxTs+GPzVnlIK3RptOtj6enNt5e3biUZJZUJj/MkIle5jadep0o8tyh9 vuT49udVZdeEl1l5D/CWW1mj12JN8VSaTuk8M1UFgYhIrqFo0478G3QvD/pCjOIsRX1h iqLxC8pRLyq3qHoNX1kesGVk6dnbEyCPp+lp1fKoKNmjNMMPEAqVodPD7+He9wGKcIa4 92rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786646071; x=1787250871; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7YHG5aECJfFEafyUES+0YBuoUGPDTuM9lTTdzyRLjcg=; b=Oh31b4+vMBiKHarFfJsUZH/lt7VxQyIcvYJhAJ0lgdKs3YW8RUvRiw54UTvJbkInTh kxn2O0z1GXqw3MGA0j9Py2PanQ+qHC0t+AcmMiuJEErJ2J8/RKkAKFf/vTjdGiU6XV4g v9VnxRwJIcfESo9I9YiRh30oZpBF2J1RyqQAVcOV1Nsk/5XsGoxvxTAk7fLy/oHOnrJa AdrN81XKql7hETK2yyqmYX4SVCBOJn9dsLC2FxAWEBlHoHgZg3cMh+i3Xz1WtQk4J8lR 6EtWvpJfmj2yjP0tlGLkkEavpIh4cm2YFrm1R3ht3WCq9Bw/OULJeOkn6PgWLh5hYffD p7VA== X-Forwarded-Encrypted: i=1; AHgh+RoSkszTXLKSMb/h8mYrj+W+7ZKlPSXhdWvMzvp81FditWn8IVfGLUFsULOxC0O771r1GzCG3TUSToMtQ/U=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1plTO3duuTCbr/Q/XkCyCjLDoOIAv8wKo1usmg12n7sNK5RPs /3Mx5Ltf3Hq6cFF5aId2DVAeTDNP0LRHmraPZI1g71/0WRbxeEi7LIam8xzxl9pyzHK64w== X-Gm-Gg: AR+sD12tCLjvnBdZk1ClLbxrT62g4TuYwkC2kphnirES3YAe9n9FmcCxCqS7SUq9M/W hwQT9JdsE0Xk9HYFisI7maNvFkikGVlurY1K6ZXLq8vmqds0MiRA2d0tTqdJ+r6eFNQHC4oVKn7 dcLFwt4EA+C++NNZ/S9eMLcFDlPrnoqpyKV9DiNfN2mor0yg5ZXq/ijGS5oerv5qds+ulAwE8Li NP2sK2JEinTMFNXwnCcM3bw7xeyOhb9JfcQY3G5/G5lKZSi5rvT8jLbpeL7vzNcD1uGnPCZ/R8F MDQKcgAePNtSDXl28fRgkebPYglu+MwUa3K7RvxjYCnSoQzqOaS5DQz+VZ1VADvMKJ0wj1Fg/7t 3zvpJjoPO3HBOi1BKw0OY7tc7KmyPth4VVwnV4kEz/1pB1lGwHL/vGhz0kxWISc8FXmHdAqNraW 6zwg+DxzXnDRNDbO2rLv5xPbVf+OaftWB0VvfXAgqOnaZPYJC35uv+Ubh+Qu2Kv4XqikUSsecQB XgkxyMr+F6g+QfIWIpPqSiLV45fIv8xBWBoiWBM0k7v1miqF06esyxloXM= X-Received: by 2002:a05:6a21:398:b0:3c4:1493:6822 with SMTP id adf61e73a8af0-3cc5527de3dmr10298362637.18.1786646071025; Thu, 13 Aug 2026 11:34:31 -0700 (PDT) Received: from localhost.localdomain ([2804:7f0:b103:29aa:a46e:b8bb:4db6:5c63]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31ebfc3ca41sm10226567eec.21.2026.08.13.11.34.28 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 13 Aug 2026 11:34:30 -0700 (PDT) From: Joas Antonio To: horms@verge.net.au, ja@ssi.bg, pablo@netfilter.org, fw@strlen.de Cc: netdev@vger.kernel.org, lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org, Joas Antonio dos Santos Subject: [PATCH v2 ipvs] ipvs: fix integer overflow in ftp helper port/address parsing Date: Thu, 13 Aug 2026 15:34:24 -0300 Message-Id: <20260813183424.47522-1-joasantonio108@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Joas Antonio dos Santos ip_vs_ftp_get_addrport() accumulates decimal digits into a __u16 (hport) and into unsigned char (p[]) without checking for overflow. A crafted FTP PASV/EPSV response with an over-long port or address octet wraps the value, so the helper configures the data connection with a truncated port/address. The netfilter conntrack FTP helper had the same defect, fixed in commit 2b413fc689ba ("netfilter: nf_conntrack_ftp: avoid u16 overflows"). Apply the equivalent fix here: widen the port accumulator to u32 and reject values above 65535, and reject address octets above 255. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Joas Antonio dos Santos --- v2: use real name in Signed-off-by, add subsystem tag to subject (per Pablo Neira Ayuso) net/netfilter/ipvs/ip_vs_ftp.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/net/netfilter/ipvs/ip_vs_ftp.c b/net/netfilter/ipvs/ip_vs_ftp.c index b315c608f..9e3e005a8 100644 --- a/net/netfilter/ipvs/ip_vs_ftp.c +++ b/net/netfilter/ipvs/ip_vs_ftp.c @@ -102,7 +102,7 @@ static int ip_vs_ftp_get_addrport(char *data, char *data_limit, char *s, c; unsigned char p[6]; char edelim; - __u16 hport; + __u32 hport; int i = 0; if (data_limit - data < plen) { @@ -144,7 +144,11 @@ static int ip_vs_ftp_get_addrport(char *data, char *data_limit, return -1; c = *data; if (isdigit(c)) { - p[i] = p[i]*10 + c - '0'; + unsigned int val = p[i] * 10 + c - '0'; + + if (val > 255) + return -1; + p[i] = val; } else if (c == ',' && i < 5) { i++; p[i] = 0; @@ -222,6 +226,8 @@ static int ip_vs_ftp_get_addrport(char *data, char *data_limit, if (!isdigit(*s)) break; hport = hport * 10 + *s - '0'; + if (hport > 65535) + return -1; } if (s == data_limit || !hport || *s != edelim) return -1; -- 2.39.5 (Apple Git-154)