From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72A5239E6F0 for ; Fri, 14 Aug 2026 14:07:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786716444; cv=none; b=NKd7LRpYLpRyqSs1WG/BF+i7bWorIQYGRpFwh6qjHGoMRH+H+s2jyrHkZhqm59rX5sMg/Y5cDjnciAX9sNCKk7pbHmbivcK1YRiR0nB+L6gwKbjfHx18i/hxpt8QL1quNbXfEycNhfstSRo4Sm5pGVhuQ10LqHiK3NKo39yEJxw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786716444; c=relaxed/simple; bh=KKLy5EMnklXPbhnvbu9dl30pgZLAa7WMR+ilI4JN1Cw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Hy4t9cHmRtg/m5iq04LjF0NyfXEcQ0ra2EheCwvy0587SP7jOQ2Jg0MadI1LNE9Z7KRRhxVDbGDLWgTOZsjznLEvgF1qft9jGT5VBC8GWavi680MIoBmgT6wMHRP9/UANygCLCalLpSeC60lx42xQKYxo2WM3CehBRIVFqtDtxM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=rMLFKARK; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="rMLFKARK" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 0DFE24E411D9; Fri, 14 Aug 2026 14:07:14 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id D576B6046D; Fri, 14 Aug 2026 14:07:13 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id D266511C4ED7A; Fri, 14 Aug 2026 16:07:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1786716432; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=7wLBGn50vSLQ8v56Mg7/uG9rJVn+UFZHymtVBTKFZ88=; b=rMLFKARKiuHkTTZj7Ef2UbJhsshBBSZ/ffcAasj1WbNlsU8NjdUdWj+TZ/awrD/hGuaH7Y SIEvmCntfNjvF33mkduugRe2uR4+YuuHaRtm6wCQkIScl1giFAUTiWWsv1A7/q/0qx7tYd xrz/hM0Ve4PRe+Yp5lFRn6yD1TuIs0sbA0oOpm1uRGdd7hiv9uagrFCbhsr6K0y+0i6VZk 6v6AV0+laWI+ksBqmmORcwqAzCgmqEJe4TiKZ6LUdmG+azgyRAOm6bQxN8DzXQaAwSqHx4 96o/EoY61EnQpFOTDr7ofmpv+NsZ01NhspxcdNOR6Dc3TGOyb+nzUA2zCBFkGg== From: Luca Ceresoli Date: Fri, 14 Aug 2026 16:05:58 +0200 Subject: [PATCH 10/11] drm/bridge: fsl-ldb: don't create a panel_bridge Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260814-drm-bridge-every-panel-v1-10-19cd5277cc8d@bootlin.com> References: <20260814-drm-bridge-every-panel-v1-0-19cd5277cc8d@bootlin.com> In-Reply-To: <20260814-drm-bridge-every-panel-v1-0-19cd5277cc8d@bootlin.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Jessica Zhang , Linus Walleij , Inki Dae , Jagan Teki , Marek Szyprowski Cc: Dmitry Baryshkov , Hui Pu , Ian Ray , Thomas Petazzoni , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Luca Ceresoli X-Mailer: b4 0.16.0 X-Last-TLS-Session-Version: TLSv1.3 Now a panel_bridge is automatically created for every drm_panel, so this code, looking only for a panel and unconditionally creating a panel_bridge for it, would lead to creating a second panel_bridge for the same panel. Fix and simplify the code by just getting a reference to the already-existing bridge from of_drm_find_and_get_bridge(). And since of_drm_find_and_get_bridge() returns a refcounted bridge, take care of putting the bridge reference by using bridge->next_bridge. Signed-off-by: Luca Ceresoli --- drivers/gpu/drm/bridge/fsl-ldb.c | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/bridge/fsl-ldb.c b/drivers/gpu/drm/bridge/fsl-ldb.c index 26cc72948f31..c289139b9273 100644 --- a/drivers/gpu/drm/bridge/fsl-ldb.c +++ b/drivers/gpu/drm/bridge/fsl-ldb.c @@ -86,7 +86,6 @@ static const struct fsl_ldb_devdata fsl_ldb_devdata[] = { struct fsl_ldb { struct device *dev; struct drm_bridge bridge; - struct drm_bridge *panel_bridge; struct clk *clk; struct regmap *regmap; const struct fsl_ldb_devdata *devdata; @@ -119,7 +118,7 @@ static int fsl_ldb_attach(struct drm_bridge *bridge, { struct fsl_ldb *fsl_ldb = to_fsl_ldb(bridge); - return drm_bridge_attach(encoder, fsl_ldb->panel_bridge, + return drm_bridge_attach(encoder, fsl_ldb->bridge.next_bridge, bridge, flags); } @@ -298,7 +297,6 @@ static int fsl_ldb_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; struct device_node *panel_node; struct device_node *remote1, *remote2; - struct drm_panel *panel; struct fsl_ldb *fsl_ldb; int dual_link; @@ -339,19 +337,13 @@ static int fsl_ldb_probe(struct platform_device *pdev) fsl_ldb_is_dual(fsl_ldb) ? "dual-link mode" : fsl_ldb->ch0_enabled ? "channel 0" : "channel 1"); - panel = of_drm_find_panel(panel_node); - of_node_put(panel_node); - if (IS_ERR(panel)) - return PTR_ERR(panel); - if (of_property_present(dev->of_node, "nxp,enable-termination-resistor")) fsl_ldb->use_termination_resistor = true; - fsl_ldb->panel_bridge = devm_drm_panel_bridge_add(dev, panel); - drm_panel_put(panel); - if (IS_ERR(fsl_ldb->panel_bridge)) - return PTR_ERR(fsl_ldb->panel_bridge); - + fsl_ldb->bridge.next_bridge = of_drm_find_and_get_bridge(panel_node); + of_node_put(panel_node); + if (!fsl_ldb->bridge.next_bridge) + return -ENODEV; if (fsl_ldb_is_dual(fsl_ldb)) { struct device_node *port1, *port2; -- 2.55.0