From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFA653B774B for ; Fri, 14 Aug 2026 19:29:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786735770; cv=none; b=BzfB6Qh+w+xqwK62ZWJN1458yMuFNAXJuy6Ob9Khx3IE+sGd8rFcJ3b69dd5jZlLJzXvqIydsJFBoYmu0jRf9+EiswGZzNP/6J/pbHkzRb5lr2//LUt9Ly1sb6jOCZdpFuG3Rlzdg6Fx9QfFVqlbphiITHo5X1dytVzuVIv6q38= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786735770; c=relaxed/simple; bh=DYUlMEbqUsURMwexmCD/xyIYznB1QWbXqfysKMihGio=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BRlUrcFiRzMO0yx6yQkUtMH5Z44GgIuPxJGmUrBjkjd9MNfvrnqycV9kxXnoFC/M9NmaczuPtHDpPCp0Zrh1+/bKNVAIInxA3oTqhn1YHFQEQChz1RcRfqqkRqBQ1dzGpeX3ntj1AfqdXbC5bbAAyOQuyB0QI2A6hGWpspiuyzg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MGDXX0wg; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MGDXX0wg" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4954b3c5cbeso897265e9.1 for ; Fri, 14 Aug 2026 12:29:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786735764; x=1787340564; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Ij1m4fx/1NIyn8kVtLRSbyCjXHfqmQiafcPU+9XENi0=; b=MGDXX0wgAf//EJdXVzwlXyJqMxKnFX3cHS/XKU9uD7QtS+929IleUVoFpFKuBJMQ+B VejVuMpUSDtGkH8/qN+LNAsZTmNJYAoq33TYv5R5xbpuGQuFKJbQZT/Sc9YJhM5UsT5n lcZh3nK4KBrzyRBD5NIoNg/vdBjOuaic1M6ABakbHsCfAuVdMxUJzrptR0nuKHvW6FqT N5uqwA3sUmf58y/9htGo34scab1PGUs2C0LqP0amzKdlWzPlKqOkXkQh6sNYfcJm4nPh Xhkv5XvIJMc1Ic+eSlynyxm+51NxyswDOFLlw0tAfFfjBlKWN8G+3szwinHo+wp5FP2A Dv9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786735764; x=1787340564; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Ij1m4fx/1NIyn8kVtLRSbyCjXHfqmQiafcPU+9XENi0=; b=jXhFHShCgoP8P2ajNSTakvgrPr4tFvEEB774lGbp73TWAN5YsSaMUtrY1AKg5LZNTk vx7FJ03xZjYoJe34R7VaXXGlNvCW0Pbz3h8lDBsQ3Mf0HQ2Cmr4/4cSN0UA/VvgIsafq xyCmmUk9Wot8x97vbaEYinPD7EUdIQpt3YB2+RqzQd6oorQ8mdQ/cgEMnH2k6wvFJoK5 rUD4DYAYIIHfimOX9nX9b8fQ5e0bcIa18fM7mHLuSfqp5BsyWDnpo59To4FPYa+Sbcdh ZthjdpSUDHlfyizOyON29f5kJJO7EvpjoWi+bJZ/Y08lf0PVrfFwRQC4QpusxGSOLN61 ka0Q== X-Forwarded-Encrypted: i=1; AHgh+Rro7Zv9Be2LkYpH8NFglspJhaL1r82qD5OwU2y0YcFuJysIs3bWbs0Fn293zKo8xQ5EmVYNwzLgr1/rPMU=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/VXs+o5SxBB78wESxLkn98izgE1fQn6jV9RKCtyoneCu2SHj3 1vt17VRXxYK8rao1hTrPLoapbA+XH0SUvxQu5hBFEmU6bcF57LZY0V92 X-Gm-Gg: AR+sD125yye4DBZnKyKU4nyKnII23rvEC7NGE3BlsktBaIpuHACkTG7nX8ynys/PVWM 6SwDPiJCwv1NiWmH+blJO1EVpWJFg1bNLJg3UEO257mzf7ssu1wx5Kyf4MCmiQaFmvI8KRzvo2Q v+jPHrGLnxGbMprbD+vw/wNis4yWWOYpkayBOdN4KwBzGHEFm+dT3hzGOg86oj4CSsIQc81EXJO rRZgBZ5z1hkpjCh38WGOo5Vi12rSZ41vCTsKduJXg+i7VYfs7p0yTqqKSr6zsCEhm3wc3m9RvvQ ldpYROd7FiH7fASx71lD95n1k5txPvNp9Su/9dXsg9el+49pjREX/QL73qXDI7TThFRfxer5ORS wlU+qg+T8LTgB97m0SOJ0g0H3ACy+MwNGIm3+d7PJzcHT5GRJuBLBj8w+qBEcQU8EkoW4tKSjrE gwYbfWTIIvLdH/4h3oYPfC1viihQwmx09tgQ/LuQgX+tQ= X-Received: by 2002:a05:6000:2c06:b0:47f:dfc1:6907 with SMTP id ffacd0b85a97d-48160751b75mr4934421f8f.3.1786735764379; Fri, 14 Aug 2026 12:29:24 -0700 (PDT) Received: from localhost ([2620:10d:c092:500::4:391e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f2005bcsm10625829f8f.6.2026.08.14.12.29.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Aug 2026 12:29:23 -0700 (PDT) From: Gustavo Luiz Duarte Date: Fri, 14 Aug 2026 20:28:54 +0100 Subject: [PATCH net-next v3 3/7] netconsole: reject enabling a target with no remote IP address Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260814-netcons_ipv6-v3-3-bc0915e8c75f@gmail.com> References: <20260814-netcons_ipv6-v3-0-bc0915e8c75f@gmail.com> In-Reply-To: <20260814-netcons_ipv6-v3-0-bc0915e8c75f@gmail.com> To: Breno Leitao , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Shuah Khan Cc: Gustavo Luiz Duarte , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org X-Mailer: b4 0.15.2 The command-line path already requires a remote address, but if a user creates a dynamic target and enables it without setting a remote address, we currently try sending netconsole traffic to "0.0.0.0". Refuse to enable a target if the remote address is unset. Reviewed-by: Breno Leitao Signed-off-by: Gustavo Luiz Duarte --- drivers/net/netconsole.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index 351754d53cf9..4af4f3039d4c 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -483,6 +483,11 @@ static int netcons_netpoll_setup(struct netconsole_target *nt) bool ip_overwritten = false; int err; + if (nt->remote_ip.family == AF_UNSPEC) { + np_err(np, "remote IP address not configured, aborting\n"); + return -EDESTADDRREQ; + } + rtnl_lock(); if (np->dev_name[0]) ndev = __dev_get_by_name(net, np->dev_name); -- 2.55.0