From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61AB93BB13F for ; Fri, 14 Aug 2026 19:29:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786735773; cv=none; b=s5IRhQSukLno2J7RWFRfOAwyCbC/ZdhqeHr+no9jDM+mspkBOcbUmZziqs1wYCTkce+OBhZiApBrMLOnojGK+f0BUfaSRbI9WZS3+m3Yj3TIm/73sTl9RXpJfgIKr90Dnbx3zc4Pr/S0Rcrg2sneDBH4NCoCmFAbDVp5MAwMXOg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786735773; c=relaxed/simple; bh=evoNCG15G6WzqrwbqEvAz0ljT6c3gDzGnnAZfhprhjI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=F7Fu1GUOC3gWysmjj/YYapz6gyK6nlfOX4tFnDW3cy7ksXsC6wJWnN/OsQARJo8g64fT5cCmsszTmGkc38bnuZ5k8tUFICs65ugiGtNxTUHl6PNe05LICtV6Gm/JEVQ6ILFqFqGPD1WMZiarDxUIFI0zNxJYG1kvJnioJ1ppiAY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Rh/8GNMw; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Rh/8GNMw" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4954a2dba6cso1055805e9.1 for ; Fri, 14 Aug 2026 12:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786735767; x=1787340567; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9WsLtkV3HpWQM29hlh8OFg5JwIeyXX1Q1ZnZhfhuQco=; b=Rh/8GNMwTeGKZnluGyJdrLcmeOmei1Ra5kbhVi2rpAzg+wzIMIP/RRtfGsxnJ0N0Kr VWk8BMDwkBJUFjv8Bx3wxZh2BslRcXwSmQHSddxme7ewLREYWBpvM3g19UF+u8bgV5JR G8kl3W/afCqeDSEHNXurNECvVvdcdaYc7571HCoXFtcGZtoFJqbPtjfNjFxiQ6kuwKMh vTDGttRGX1tvVNUS8rsXTezVM52Lux6AQWgDHRBgjjI7N96PuBnWtjT30M9bEbZaB0zR 7xCriOMrhdQOhcFxgnSbc7neL+iy0ICGSQaSEChX2cbP5e8LN0Goa8euwYPCp6KzzwYa K5WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786735767; x=1787340567; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=9WsLtkV3HpWQM29hlh8OFg5JwIeyXX1Q1ZnZhfhuQco=; b=kIcBkNxKnVEMIkyjAPETqFaSNwitMVNyTd9k/LAELU3VlVfWzHHyA6DpO9HASJWqPy Wz2SbK64STKppYxdy5rHXWQoN64r7VcZuwy4klNNFh4QDYSnMGpbce0JPUeruIp/1gX2 dCcNJj5skG6T/I6YC0aJkD09CPWJO52gFxgQvCrLGvzQgX9Uh7FRKzyH2t10+mQuYfTM vrToJ/y2aS/u9HBwUaaMTbu/RvAVYlp4kQVSIiMD30tGFRE/UVhQ/IPS/ZX/zqTWr0O4 EMNKTC4Hl+rVD9l6jODgl4YDIWOCl0uOg8FYSWR6q8NVFHusholVsk4C3F0x+3bbRmwv tDDA== X-Forwarded-Encrypted: i=1; AHgh+RqSvkS79hUcZQx3ljZRgr0/gtogJV8qG9BxocHYrytp21PP/GcBENNqAtr4gx3Xsl6cvPvW+68gZNtcciM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+YVM/g36GqhMUiaaz2svlEJpXvgZK6cIVETTLnGOsRK91RSUd O+27XNyQd9RPHTMpEpPGclW3pndnT3hVuBYPlgxyAvK6v+BCRupjzeq9 X-Gm-Gg: AR+sD1258Pkql/XwLgluw2O/5diD1SpE3UVAUzf6yN+jvuaPpyv05Kusc8Q+JCKcS5i Tq94cLEiOXWqAt50u9ulaNwZFG9i670PGg5F4DkeTeCgwMSib3w/SRNZzZeITvl8/qe+IHH8+wr a07m2mnZeNf0/l0zxQPDqXdicTt5sn1HzrUCI0Q7VaS0WtO1J2y42tmEO8WbXnTVjzgFmZ9weQp ylT7aVcZ6TnjVkwl5MsWjYIWOe9KRnTPd2HZtbztWFPS+oBkKeamE5dLO5jF3nBXJVF5/4ld7VD FxJAnwnzXj+QxdG1tWKLqWxab6D0dprOC2LgTMNN7mdA5RMH4LGfcdBMMCrgoUDFYOjO5YRu3RR Le4iX+te95nhXLCkDTEPxV5KbCOuiVs8EqihFMBIynO4KWfPmdUrxj1OEhN2E03NEsgzlIFXwSQ 0BTy2WASm/7PiLmtnt2W53Lj4mIfI+2Hem2wH1q2a1a9Q= X-Received: by 2002:a05:6000:288e:b0:47f:921f:397f with SMTP id ffacd0b85a97d-4816078a831mr5570171f8f.4.1786735766602; Fri, 14 Aug 2026 12:29:26 -0700 (PDT) Received: from localhost ([2620:10d:c092:500::4:391e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f219e12sm9464228f8f.10.2026.08.14.12.29.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Aug 2026 12:29:26 -0700 (PDT) From: Gustavo Luiz Duarte Date: Fri, 14 Aug 2026 20:28:56 +0100 Subject: [PATCH net-next v3 5/7] netconsole: show empty string for an unset IP address Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260814-netcons_ipv6-v3-5-bc0915e8c75f@gmail.com> References: <20260814-netcons_ipv6-v3-0-bc0915e8c75f@gmail.com> In-Reply-To: <20260814-netcons_ipv6-v3-0-bc0915e8c75f@gmail.com> To: Breno Leitao , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Shuah Khan Cc: Gustavo Luiz Duarte , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org X-Mailer: b4 0.15.2 An unset address (local_ip/remote_ip), now denoted by AF_UNSPEC, currently shows "0.0.0.0" in configfs. Print an empty string instead, which is more clear. In netconsole_print_banner() we can be even more explicit about it, as we don't have the risk of userspace trying to parse it. Reviewed-by: Breno Leitao Signed-off-by: Gustavo Luiz Duarte --- drivers/net/netconsole.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index abcc8515ddd2..1f18d0a7d2dd 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -718,14 +718,18 @@ static void netconsole_print_banner(struct netconsole_target *nt) struct netpoll *np = &nt->np; np_info(np, "local port %d\n", nt->local_port); - if (nt->local_ip.family == AF_INET6) + if (nt->local_ip.family == AF_UNSPEC) + np_info(np, "local IP unset\n"); + else if (nt->local_ip.family == AF_INET6) np_info(np, "local IPv6 address %pI6c\n", &nt->local_ip.in6); else np_info(np, "local IPv4 address %pI4\n", &nt->local_ip.ip); np_info(np, "interface name '%s'\n", np->dev_name); np_info(np, "local ethernet address '%pM'\n", np->dev_mac); np_info(np, "remote port %d\n", nt->remote_port); - if (nt->remote_ip.family == AF_INET6) + if (nt->remote_ip.family == AF_UNSPEC) + np_info(np, "remote IP unset\n"); + else if (nt->remote_ip.family == AF_INET6) np_info(np, "remote IPv6 address %pI6c\n", &nt->remote_ip.in6); else np_info(np, "remote IPv4 address %pI4\n", &nt->remote_ip.ip); @@ -863,6 +867,8 @@ static ssize_t local_ip_show(struct config_item *item, char *buf) { struct netconsole_target *nt = to_target(item); + if (nt->local_ip.family == AF_UNSPEC) + return sysfs_emit(buf, "\n"); if (nt->local_ip.family == AF_INET6) return sysfs_emit(buf, "%pI6c\n", &nt->local_ip.in6); else @@ -873,6 +879,8 @@ static ssize_t remote_ip_show(struct config_item *item, char *buf) { struct netconsole_target *nt = to_target(item); + if (nt->remote_ip.family == AF_UNSPEC) + return sysfs_emit(buf, "\n"); if (nt->remote_ip.family == AF_INET6) return sysfs_emit(buf, "%pI6c\n", &nt->remote_ip.in6); else -- 2.55.0