From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCB5D346A07 for ; Fri, 14 Aug 2026 06:08:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786687713; cv=none; b=dA5sxYbWq8fOoIVF+YlhD6+NAwEUceMCmyT6xj0KT40C8oc9QKGX5B3NlOzn7tYyWYyF9dIA83oQzw9i48gO3/j9+SfboQB7Hpq2ROZ22/6V9/kMy/aDF2S29UceqTU0kq/0c/QiwrUKm1X2pYyVBW4YtUa2H25io2+jQpiLUYI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786687713; c=relaxed/simple; bh=OdaBAiQb6gEmCNb7tFmBVM0j0naVT2qn4/yODI81cH0=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=OUc+BGUoUowfgd0I2tDw+Hu7W+kMWOnnSkiGq1C6oIneq74MGB16SNos5dtgxpcQT6JDF6sNx5iDN6COuaj0kB24HrWxL1TliRrQXLs7d6D5WfRXnSZd04akT0A8ZVhZ6zvV5rqxAE1f736UK2J3p8pNRXoEHGHQ+ycnk4oAgC0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bQJ606uC; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bQJ606uC" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4954d29264cso3132045e9.2 for ; Thu, 13 Aug 2026 23:08:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786687709; x=1787292509; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=TINErpoZs249/gc7F8k6VoM2fKTzeeCGjix6Ih+NnM0=; b=bQJ606uCU8XPYFBlOGD6j2sRBxZpXgup9HIH6OuLxkK+4nqSrdw7+QedqNlFf4CmQf wIkqQhVF5zLzzG4YOTjU/iMeS1FvoMMD0Tu+Wab32ea0gdsiQOA1zu6em+abbPpDZhFZ w1ZshsUkM6n1JxuveiUfB1MoZlvg7nidoOTnD1mAflvlBidzERC04LYSc1tiR8ke4fGV QWIHPe79DV6Bvof6knZFQ+G7lf0PCgi+JhhZKF3jG1xJJqxtmI7nmgo0pOEDHUNs9mVV o556nwRwW6JR3KbYMQ2jZVAvbmYT2LmmRfMojCcVGT+TDWVOYUjsXseNoTHQlQ8iZ7U5 YRQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786687709; x=1787292509; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=TINErpoZs249/gc7F8k6VoM2fKTzeeCGjix6Ih+NnM0=; b=Srwa3f+utX0CKS9rGZ9YYAFBL7KqB/QpmzvfQRkEz34USadFSCfbaAivQAAGFAMHPW Kh5rYQHiCIaTBkPoGYvyUkiuDCvNGzO8UeXzCaCrTfs60uIquJ0yRUFfW9AytFuzW1br BK27eel3LrQJ7YIAFLEJRn42cYj4h/Vb+EyHONevNK9vbKBUjSycy/AsnReviiMVlyT5 xH0Knp2Gppa1s+61Nwi+Pzd7SKwoeq8oEzCTBvWVbsd1U4k4oxUl54euJDbRRVIEc73K DNb6XrncCVhSJ5ZYFi9/aWBoQ5wrJfj7wCog5RxqnMcX4nvuFXVRq0B94nupvwbzHBz0 YWUw== X-Forwarded-Encrypted: i=1; AHgh+Rr2T6JP9ffPridLb6WgrWb49p/19awFe6ylpeimxVL4Ye7ap+A6BBmg+aPVD6rCdbLCJVa40f5F9uakFOc=@vger.kernel.org X-Gm-Message-State: AOJu0YznWguFaZh6Gu507z2LI0p1wqv0ASGoZbGTTIzJq9cd6tAVEXY1 UXALwBq00oEqYPJYQY0I8wKbEJVHvGpRm9wa+D1Vj+u5+srrrbdg4aC+ X-Gm-Gg: AR+sD12Kn3isdU7/4djHRpo+nHoqlJbxdpHXUN+tlgYXU8cYwTnCLzDTnC7FPgqlF1b 344MTZTgstp74rq22pHn4J2o6T4II0/D8P2Xs5e56NLztp1Afh9Hzjee1mNTVJfLL9USeGql1Ez vUCxGImeph9TJcOHs5fCDQYMqMmjP9W5ZT5qkQMPBlLYSt+sA3FHaFLNdYRMYqRzpwVk7oJNu9f y4LaShyM2OchY9WjlmB5rMtBC8e2fcKNgx0tw7CuWhlvfRxy0RNxXxckC0W5gjGr7crX5OmFZnu VVe6uJyd272P2PLaBHBLkESbmpEJt3MRiEffimUdfaFZTrJA2x0H5MJQsLplI9DL/Awa1zl1vtQ wqoDMwDYZml20hunzW4QxuOiIFjBlXs975+S+YlUKYkm785P6rFxVcfkDDocOHtpQcsI5AdoFWk MpRIvwSe+ZT+ci5LRXloobP2ZXtGaz+1aYI/UpqBCDcugG5TXDYnRQUGnuxk/COIikJiNNHOLQO rDYNkmw3kd0SJLz37d8TGZhg85DY2daOCFrYkc8 X-Received: by 2002:a05:600c:1d89:b0:499:726a:117c with SMTP id 5b1f17b1804b1-499879bf7d0mr46462705e9.19.1786687708806; Thu, 13 Aug 2026 23:08:28 -0700 (PDT) Received: from INBSWN167928.ad.harman.com (bba-86-96-6-50.alshamil.net.ae. [86.96.6.50]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49989ae9618sm1475095e9.13.2026.08.13.23.08.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2026 23:08:28 -0700 (PDT) From: Abid Ali Subject: [PATCH net-next v4 0/3] fix the MTL fifo and DMA race condition Date: Fri, 14 Aug 2026 06:07:52 +0000 Message-Id: <20260814-stmmac-rx-fifo-block-v4-0-1951fd3d33b7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIALiwfmoC/33Nyw6CMBQE0F8hXXtNH5SHK//DuOjjVhuBmpYQD OHfRTYSE1xOJnNmIgmjx0RO2UQiDj750C0hP2TE3FV3Q/B2yYRTXtCSF5D6tlUG4gjOuwC6CeY B6GRVG1G5utBkmT4jOj+u7IV02EOHY0+uS3P3qQ/xtf4NbO3/0wMDBrlUmta5Lgzl51urfHM0o V3BgW+RcgfhH8QakcvSCmbpLyK+SMXEDiKAQikqZTSilLbeIvM8vwEG8nIsTAEAAA== To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Russell King , Qingfang Deng , Maxime Chevallier Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Abid Ali X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1786687705; l=2747; i=dev.taqnialabs@gmail.com; s=20260425; h=from:subject:message-id; bh=OdaBAiQb6gEmCNb7tFmBVM0j0naVT2qn4/yODI81cH0=; b=Dp4UMAGzWTSENRNb6J6gKaqOlTcxE4kwbzpspsjNxVeDZhtAGQlLgXTIGxhQDfHB/+bAMPmAY P9hhkFyeyD6DtwJEMI0/cor5QU5XZzAYFVALTKId94CVLFNBHFMFmUZ X-Developer-Key: i=dev.taqnialabs@gmail.com; a=ed25519; pk=4Syx51HH/MOySSUpi79M2ToLOdwt1yiNb338eKZBJNk= To: Andrew Lunn To: David S. Miller To: Eric Dumazet To: Jakub Kicinski To: Paolo Abeni To: Maxime Coquelin To: Alexandre Torgue To: Russell King To: Qingfang Deng To: Maxime Chevallier Cc: netdev@vger.kernel.org Cc: linux-stm32@st-md-mailman.stormreply.com Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Abid Ali Changes in v4: - Rebased on net-next. - Link to v3: https://lore.kernel.org/r/20260813-stmmac-rx-fifo-block-v3-0-738acbee55d9@gmail.com Changes in v3: - v2 tried to fix the ordering in teardown path, but it still would not follow the ideal flow mentioned in the databook. So have seperated the patches to deal with the teardown and some findings from sashiko. - "net: stmmac: enable MAC rx/tx after DMA start": reduced in scope, now only moves the MAC enable after stmmac_start_all_dma() in stmmac_hw_setup() and stmmac_xdp_open(). This is to handle the overflow scenario during bootup causing hang. The teardown side in __stmmac_release() is no longer touched here. This change could go independently fix the overflow hang at bootup. - Added "net: stmmac: xgmac: tear the datapath down in the documented order": for ensuring ordered sequence is followed for teardown. - Added "net: stmmac: xgmac: decouple the MAC Rx/Tx enables from the DMA ops": drops the global TE/RE writes from the per-channel XGMAC DMA start/stop ops. - Link to v2: https://lore.kernel.org/r/20260727-stmmac-rx-fifo-block-v2-1-4dc3457d31d0@gmail.com Changes in v2: - Corrected the ordering in teardown for xdp at stmmac_xdp_release(). - Link to v1: https://lore.kernel.org/r/20260726-stmmac-rx-fifo-block-v1-1-45ab094b6c02@gmail.com --- Abid Ali (3): net: stmmac: enable MAC rx/tx after DMA start net: stmmac: xgmac: tear the datapath down in the documented order net: stmmac: xgmac: decouple the MAC Rx/Tx enables from the DMA ops drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 8 ++ drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c | 94 +++++++++++++++++++--- drivers/net/ethernet/stmicro/stmmac/hwif.h | 17 ++++ drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 85 ++++++++++++++----- 4 files changed, 170 insertions(+), 34 deletions(-) --- base-commit: 4f93b12cf7b25fbf8e73d222722805b049f0a6d3 change-id: 20260726-stmmac-rx-fifo-block-ef589c38f96b Best regards, -- Abid Ali