From: Tomasz Unger <tomasz.unger@yahoo.pl>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Dan Carpenter <error27@gmail.com>,
Tomasz Unger <tomasz.unger@yahoo.pl>
Subject: [PATCH v2] staging: rtl8723bs: remove stale comment and dead code in os_intfs.c
Date: Fri, 14 Aug 2026 09:26:06 +0200 [thread overview]
Message-ID: <20260814-v2-attempt-final-v2-1-cd3a27834b7f@yahoo.pl> (raw)
In-Reply-To: <20260814-v2-attempt-final-v2-1-cd3a27834b7f.ref@yahoo.pl>
Remove the comment referencing an unresolved 'XXX' placeholder
and the commented-out memset() call it describes, rather than
fixing the placeholder in place.
Suggested-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
---
Changes in v2:
- Removed the stale comment and dead commented-out memset() call, per Dan Carpenter review suggestion.
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
index f31196f54b3e..e3f0b9c8123a 100644
--- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
@@ -664,9 +664,6 @@ u8 rtw_init_drv_sw(struct adapter *padapter)
/* add for CONFIG_IEEE80211W, none 11w also can use */
spin_lock_init(&padapter->security_key_mutex);
- /* We don't need to memset padapter->XXX to zero, because adapter is allocated by vzalloc(). */
- /* memset((unsigned char *)&padapter->securitypriv, 0, sizeof (struct security_priv)); */
-
if (_rtw_init_sta_priv(&padapter->stapriv) == _FAIL)
goto free_recv_priv;
---
base-commit: db2ddb87143519e20a95aa36c60b36107b736a58
change-id: 20260814-v2-attempt-final-45442f63b7e0
Best regards,
--
Tomasz Unger <tomasz.unger@yahoo.pl>
next parent reply other threads:[~2026-08-14 7:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260814-v2-attempt-final-v2-1-cd3a27834b7f.ref@yahoo.pl>
2026-08-14 7:26 ` Tomasz Unger [this message]
2026-08-14 7:42 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260814-v2-attempt-final-v2-1-cd3a27834b7f@yahoo.pl \
--to=tomasz.unger@yahoo.pl \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®