mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Artem Dinaburg <artem@trailofbits.com>
To: Sean Christopherson <seanjc@google.com>
Cc: Artem Dinaburg <artem@trailofbits.com>,
	Jinu Kim <kimjw04271234@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	x86@kernel.org
Subject: Re: [PATCH v2] KVM: x86/mmu: Write-protect tracked GFNs in all address spaces
Date: Thu, 13 Aug 2026 21:12:27 -0400	[thread overview]
Message-ID: <20260814011229.72845-1-artem@trailofbits.com> (raw)
In-Reply-To: <anOLfLhAGbOXT30p@google.com>

On Wed, Aug 05, 2026 at 12:14:04PM -0700, Sean Christopherson wrote:
> Actually, irrespective of what we do with SMM, we should harden KVM to
> skip marking upper-level SPs as unsync, because while corrupting guest
> memory is bad, corrupting guest memory *and* crashing/compromising the
> host is worse.

This is correct. There is a working guest-to-host escape via an
upper-level unsync shadow page. It works on Debian oldstable and
likely other shipping distributions. I'd like to see that patch
applied even if the SMM question stays open.

> it wasn't clear to me how marking an upper-level SP as unsync leads to a
> corrupted rmap, and I hadn't thought too hard about it.

There is a bug, unrelated to rmap and still unfixed in the longterm
trees, that turns an unsync upper-level shadow page into a writable
mapping the guest shouldn't have. It can be readily found via AI
assistance.

Either of the two suggested fixes would be fine, but the unsync
behavior is dangerous and should be prevented.

      reply	other threads:[~2026-08-14  1:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-04 10:57 Jinu Kim
2026-08-04 13:10 ` Sean Christopherson
2026-08-05  8:24   ` Jinu Kim
2026-08-05 19:14     ` Sean Christopherson
2026-08-14  1:12       ` Artem Dinaburg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260814011229.72845-1-artem@trailofbits.com \
    --to=artem@trailofbits.com \
    --cc=kimjw04271234@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®