From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f228.google.com (mail-vk1-f228.google.com [209.85.221.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6766D30DEDC for ; Fri, 14 Aug 2026 01:15:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.228 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786670122; cv=none; b=KiJREpHnoMDaj3vXHxWKBRWV6SiYYWm9A9puydTeuMsRfBZqUiu80wvTFrhO1HnR7xXCEzGeWo8P3jeuni1ktWRMXp+HBdkVjTZTPUTkwYfby5KQQH5ziUniEooRQW8VPjSdSsq4mT3VXvUzkRH+ybAo4iQqOWTOd25jsM5fFrI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786670122; c=relaxed/simple; bh=+JHdt3JmG2owDpqNuYfz4r8yuUstsxsqLFft1/pNYqM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=g/+C/PR+VkIsNSW59jt7OSIQfK0mIWdoWCAhPoS8zDylmJuKcYHMAgfT4UW/KLfczISnChD+E7yNlfK5U+qf6bdch/wrjgYvdEF5yIAVy0CxRqztYGZ6xg0Hc5KT7ZBTKDpIoWwXPNpOAFDZaXlokl2Rw1HylQrX0USQjzf4yak= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=iJc/usnJ; arc=none smtp.client-ip=209.85.221.228 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="iJc/usnJ" Received: by mail-vk1-f228.google.com with SMTP id 71dfb90a1353d-5bfaa014978so182884e0c.3 for ; Thu, 13 Aug 2026 18:15:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786670120; x=1787274920; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Fh4eD78DYvCQuANjl+/oFgvf7Q84OxklnUgvpJokBqM=; b=q/hSbmfUfZmYG84xSk0waEH05bv1nuFqlZQjNbJPw2sc0lIVgiyBzW/bOGWlVByZr+ bIfPINCA1q/SzdLYV26BIwvusfcpdyvdsozn/K2UUePAzTy5sh/tKpDyyqmnOIKAzhm8 j18MXNuHFl0p8c4f3DgtIRc0qsknKBJAR4CNVUPyFl5uTOGtDMp7qZqN9F8CFv2zvpty dbDgRFom1AGISY2mZR1e+5trU1DXuuaDiwSJ1htOMn70dU9OlbN/tykNT8dDhy0OmIdL +w5ejmdAXfkfMuSZmIuJa2VYGQmalLmNlEZNC0EMzLSVEcG66K993wZAfqXXy11e4Fnc K7OQ== X-Forwarded-Encrypted: i=1; AHgh+Rocj60C3pH5AHOVF5wgV8j7ut1HS7fOyooG310+3+HaCHpAqIDKCp4Ao1hoQv8cGCNPe/GNOzH72eLJiOY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7mIdhw6n6dVPOIeSuXRCvQv/1cwIufpWpHGG/ttGCF/R0FR4U 3qU6HTawOdgzSWf/0eHyYjmSsBFQPgQ28H6tmncvTN875z7xBWOPbnbnwl55sN2vDRr1KHnSS3l rRRWo/1fptDzO7JkbGP8qEQwVvZ56ACuwwGIHa4XRAA3G61wSwWpF65S56U9oFiaLBdxvXc6tbt pb8aSiAEbOiNa/BYSPwbXPs1amG0dSGEcp2/+DctU+l0XXliT2EXVzBDjt5EDG2O605w0S2xL/q GzTCkllMilb62Tl0A== X-Gm-Gg: AR+sD10xQ1VIrZXPomG60efJtPS6RavmTRuNsWhZ9YBNn/uZ5O4gNEqgo8cqCo3gcxh j9wki7I8UrUhK0cUraPrSmRDYyzDjyGglfH687QyMl7dye3wh1YSEEFhzji5uj/nzoVMFz1O6O1 gD687ypAgJvd0/f3tfXIoJ/5IzPUBlHa/2rP21apJxxDu0szvEYM3ycoBR64iBGcbhNqp57E5WL j50wYYy3LLIq6lHuCmNhQsAKeq7SP801JLqHsbUua7cqU77VBI4WcMIwPGpvAUr2V1RzzhQhZ3K YTrFUNbkXcJavluWTklnl/s1cqI0zcsW/H1ojowRI4Q3nLtVKuEGZKtdUbuWHaDMEdjgGixdhCR 1CUnW1JNNL7FHOMOjy7/NJLEBA6p5AZYy+x682u3cwAxbjgwhho9PxpeuvZPbgn/iyjlAwmnVVX yCNONO9rQXTPe5XbxE54H5hNcN0Bt+0RY1Cg== X-Received: by 2002:a05:6122:4893:b0:5c3:8565:8fa1 with SMTP id 71dfb90a1353d-5c591eda699mr468175e0c.9.1786670120327; Thu, 13 Aug 2026 18:15:20 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-16.dlp.protect.broadcom.com. [144.49.247.16]) by smtp-relay.gmail.com with ESMTPS id a1e0cc1a2514c-97bfbd8a182sm13812241.3.2026.08.13.18.15.20 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Aug 2026 18:15:20 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-cab048cdb3eso447731a12.0 for ; Thu, 13 Aug 2026 18:15:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1786670119; x=1787274919; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Fh4eD78DYvCQuANjl+/oFgvf7Q84OxklnUgvpJokBqM=; b=iJc/usnJ+XIGbzZjG4UohF8zPCRVeY7zsS1bfIWmkVhknr/bro9G/rscoX83nDIVlr 9sIGpA7umLyzuG7NdoaOJWZXDg/trewdgpveA+gCjP4/M7qnTDbqMPXkgJdPYtM6Om5P Ms0ZPPOCuwkA4/IJjpjCC548QZxkcwfy8Dbi4= X-Forwarded-Encrypted: i=1; AHgh+RpsRD0IAPDIPqu8gdu2bbcsP8j3jlhC6iXi7vWZl6nJNNCZqRgx4goufbstAI8GnbUZsVCPh+/JF7h6Axo=@vger.kernel.org X-Received: by 2002:a05:6a21:6b16:b0:3c8:e0b4:cd9b with SMTP id adf61e73a8af0-3cc71eb5e50mr2099600637.38.1786670119232; Thu, 13 Aug 2026 18:15:19 -0700 (PDT) X-Received: by 2002:a05:6a21:6b16:b0:3c8:e0b4:cd9b with SMTP id adf61e73a8af0-3cc71eb5e50mr2099551637.38.1786670118775; Thu, 13 Aug 2026 18:15:18 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31ebcb69fbbsm12174177eec.11.2026.08.13.18.15.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2026 18:15:18 -0700 (PDT) From: Vikas Gupta To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bhargava.marreddy@broadcom.com, rahul-rg.gupta@broadcom.com, vsrama-krishna.nemani@broadcom.com, rajashekar.hudumula@broadcom.com, dharmender.garg@broadcom.com, ajit.khaparde@broadcom.com, Vikas Gupta Subject: [PATCH net-next 07/11] bnge: remove refcount from L2 filter Date: Fri, 14 Aug 2026 06:44:31 +0530 Message-ID: <20260814011435.194631-8-vikas.gupta@broadcom.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260814011435.194631-1-vikas.gupta@broadcom.com> References: <20260814011435.194631-1-vikas.gupta@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e A reference count was previously used under the assumption that any context holding the last reference could delete the L2 filter. However, going forward, the filter will only be removed by the same context that created it, making refcount unnecessary. Signed-off-by: Vikas Gupta Reviewed-by: Dharmender Garg --- .../net/ethernet/broadcom/bnge/bnge_filter.c | 23 +++---------------- .../net/ethernet/broadcom/bnge/bnge_filter.h | 1 - 2 files changed, 3 insertions(+), 21 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_filter.c b/drivers/net/ethernet/broadcom/bnge/bnge_filter.c index d1279a4babcd..33b75d8fcdeb 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_filter.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_filter.c @@ -13,8 +13,6 @@ void bnge_del_l2_filter(struct bnge_net *bn, struct bnge_l2_filter *fltr) { - if (!refcount_dec_and_test(&fltr->refcnt)) - return; hlist_del_rcu(&fltr->base.hlist); kfree_rcu(fltr, base.rcu); } @@ -31,12 +29,11 @@ static void bnge_init_l2_filter(struct bnge_net *bn, head = &bn->l2_fltr_hash_tbl[idx]; hlist_add_head_rcu(&fltr->base.hlist, head); - refcount_set(&fltr->refcnt, 1); } -static struct bnge_l2_filter *__bnge_lookup_l2_filter(struct bnge_net *bn, - struct bnge_l2_key *key, - u32 idx) +struct bnge_l2_filter *bnge_lookup_l2_filter(struct bnge_net *bn, + struct bnge_l2_key *key, + u32 idx) { struct bnge_l2_filter *fltr; struct hlist_head *head; @@ -52,20 +49,6 @@ static struct bnge_l2_filter *__bnge_lookup_l2_filter(struct bnge_net *bn, return NULL; } -struct bnge_l2_filter *bnge_lookup_l2_filter(struct bnge_net *bn, - struct bnge_l2_key *key, - u32 idx) -{ - struct bnge_l2_filter *fltr; - - rcu_read_lock(); - fltr = __bnge_lookup_l2_filter(bn, key, idx); - if (fltr) - refcount_inc(&fltr->refcnt); - rcu_read_unlock(); - return fltr; -} - static struct bnge_l2_filter *bnge_alloc_l2_filter(struct bnge_net *bn, struct bnge_l2_key *key, gfp_t gfp) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_filter.h b/drivers/net/ethernet/broadcom/bnge/bnge_filter.h index 44ee1357a0ff..16a5d91517c9 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_filter.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_filter.h @@ -42,7 +42,6 @@ struct bnge_l2_filter { /* base filter must be the first member */ struct bnge_filter_base base; struct bnge_l2_key l2_key; - refcount_t refcnt; }; void bnge_del_l2_filter(struct bnge_net *bn, struct bnge_l2_filter *fltr); -- 2.47.1