From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA03034750B for ; Fri, 14 Aug 2026 05:25:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786685150; cv=none; b=iu9yQ6kipQmcFq4ggPoprLg97RBQ8+dfupI4zryD1e//xMvffjWWORJRxM3RpEGAz1ZTD0dGcV5OmFb6mXat6jXm2/HGjhQ1kTAfvYtk9AjudTE2zEU1rHxoY/3jK7P0jhIKjRDyMJzVvQ2uC0Dwh85dck8PIR9sO0kjbx1vyV0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786685150; c=relaxed/simple; bh=H/0j9VTGpIw85o2pShiiCvoF0meADA6ZpVf/rpuGrzk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kTUfaYoCxW+4d638NWUiPxTYrdAm9eTVWV5BF4YuJpsIZk+IR6hQoBKqT71Yw/+LRvs/OfTNRXJebYFG33TMfNKNccOlv9Ww2zQw9I865NTEZFlqw2+DKS5EZF376tETkK/Jia/PXN0PE0wVCo6SnirnL7DhmqfBbHqmyKAeZzY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=asu.edu; spf=pass smtp.mailfrom=asu.edu; dkim=pass (2048-bit key) header.d=asu.edu header.i=@asu.edu header.b=ptcOfzHI; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=asu.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=asu.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=asu.edu header.i=@asu.edu header.b="ptcOfzHI" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2ceab75934dso8116055ad.2 for ; Thu, 13 Aug 2026 22:25:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=asu.edu; s=google; t=1786685147; x=1787289947; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LLASIE22a/uiaobsLF58hTYRb9DY+V8EmMZ+My6U0Ek=; b=ptcOfzHIx3edXb/hZ9wHxTJq7Bfmu4sPm4ZYm+a/sCof+XTURd+rmjKXQ/jsGVsaS/ 2qsDv/f1gswkdU6dsVNDEjVicNqldOk2tgDUGaAe3y0uTZIztJdqv+GyJJF56fnWWa9O K9Su4OQcpMstaty+q1xZ37DENNd6Ye1AOECAVh+KoYQWNTIGdeBnwOjD6e1WqjJwspqr j51vjnWX+TS7Qx+U4qmvNxoS+405u9RVRGI9fagKFH565fBUgWN2M7aqKijXCRv5j3ap 3J1XFMMzOolwEYyyaRs60ZhjNMXqGYPFJLsmP1mGlOvAH55vNZLD9kZS11Q0k8gzux64 TZ9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786685147; x=1787289947; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=LLASIE22a/uiaobsLF58hTYRb9DY+V8EmMZ+My6U0Ek=; b=tVwCLH+pMEVP5G58naAmO2lFoeLcUbQ9+3pO8cUBPfGwWqLv09TOCrdNmRFyfgZ0aL sq7qIdc6254DrL18EDMirShkNpLXRgVC2whaRUjGejxDu9tQ5f9Ycqi/wguDSplmBDaC JPTt80oKZ0vFYJ+rgTrOB4etrboRtWv2JURO7Tu4sdAUragkkd0wsJEMlPFRqj8bYpEL wwZ2h+EzD1WTgSo5M4UZSlr0xVMA5VDRv/YEDyNhR/Jvcuw8S7ha1clRlMv9cYQsLeBK srVDBXgUNncWZp6Gj7W1otyj3l7yTE00rpOWrPMMyAOK421FGBs0Y1HEsxUevXhINbT4 nzzA== X-Forwarded-Encrypted: i=1; AHgh+RrPDmDY9gMiYKalV5szJeqgtpFRWNUIgYqr38XFGP3aG0tHiHvHTDUwb+jTWPWqLy8nnlkZ2MnvTJibZW0=@vger.kernel.org X-Gm-Message-State: AOJu0Yxw4YmTXOIPFvaYbn4ZCF9BlHylcMe1YMH59U6MGGjSPPek6QOI Q+jvpAj4XSn9QW/mfO2bdBiKj73A6DEY/eamtQp1xY/PNAuy8tuZnubA1cdyzdIuHA== X-Gm-Gg: AR+sD105BS7Yt6DaI+iaC/t+usnyn7ba1eELKRq7/YjW2/wOyL1iIlLpZpEF6qEqH+u 34+OXnzIfizLKinGHWTw31szEhv8H3QylYI1/PfIRkEm2Uo+gSmG1S9Rq0MEEQq40f8HTaQHkv5 vencX8B31TRcOUGfsO872PCHbOU9ap96FghkDqGh5pFpTvy2L1Tg3w/8989MXE0BtM0Yhyf3x6M aSVz2eneiEoBPROJyEtikTmdhrJ0ilcR+JnS7YV3m57tB/9t3BrJjGQTRY1A+dlU33bpSYT45Xk 39hfC4aqgs9WzaPzBr/KIDdUFf4wH/rVOXV0uRM1Y5AOoJtCp3kKRwV4cHSnqf3IZRurddzkRuC KIQhCF7HSmmoGmYJUTvraAy9LHOax0oCQl89Y7OLtCpKU9CitOnbiAG5nL3vnSVFhjTgo+YZR1R MNvE145iV/qfV6+8GX2roTjJ5N+Z570Akbor0pd6FwlPBYxo83QWHO+96LgkIIABOEqUSyUw== X-Received: by 2002:a05:6a21:e58b:b0:3c3:8255:8c4a with SMTP id adf61e73a8af0-3cc71ebff67mr3607716637.17.1786685147097; Thu, 13 Aug 2026 22:25:47 -0700 (PDT) Received: from p1.. (209-147-138-29.nat.asu.edu. [209.147.138.29]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-141387e49d3sm5051237c88.7.2026.08.13.22.25.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2026 22:25:46 -0700 (PDT) From: Xiang Mei To: andrea.mayer@uniroma2.it Cc: dsahern@kernel.org, edumazet@google.com, netdev@vger.kernel.org, bestswngs@gmail.com, justin.iurman@gmail.com, alex.aring@gmail.com, davem@davemloft.net, horms@kernel.org, idosch@nvidia.com, kuba@kernel.org, pabeni@redhat.com, stefano.salsano@uniroma2.it, stable@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v2] ipv6: rpl: add NULL check for idev in ipv6_rpl_srh_rcv() Date: Thu, 13 Aug 2026 22:25:41 -0700 Message-ID: <20260814052541.1198373-1-xmei5@asu.edu> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260521200859.816b8923b5f27bba6124461e@uniroma2.it> References: <20260521200859.816b8923b5f27bba6124461e@uniroma2.it> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Andrea, We noticed this is still not fixed in net. We tested your idea and it works. This is the patch we tested: diff --git a/net/ipv6/exthdrs.c b/net/ipv6/exthdrs.c index 9c677eb1d1a6..51941ad656a3 100644 --- a/net/ipv6/exthdrs.c +++ b/net/ipv6/exthdrs.c @@ -368,23 +368,16 @@ static void seg6_update_csum(struct sk_buff *skb) (__be32 *)addr); } -static int ipv6_srh_rcv(struct sk_buff *skb) +static int ipv6_srh_rcv(struct sk_buff *skb, struct inet6_dev *idev) { struct inet6_skb_parm *opt = IP6CB(skb); struct net *net = dev_net(skb->dev); struct ipv6_sr_hdr *hdr; - struct inet6_dev *idev; struct in6_addr *addr; int accept_seg6; hdr = (struct ipv6_sr_hdr *)skb_transport_header(skb); - idev = __in6_dev_get(skb->dev); - if (!idev) { - kfree_skb(skb); - return -1; - } - accept_seg6 = min(READ_ONCE(net->ipv6.devconf_all->seg6_enabled), READ_ONCE(idev->cnf.seg6_enabled)); @@ -485,12 +478,11 @@ static int ipv6_srh_rcv(struct sk_buff *skb) return -1; } -static int ipv6_rpl_srh_rcv(struct sk_buff *skb) +static int ipv6_rpl_srh_rcv(struct sk_buff *skb, struct inet6_dev *idev) { struct ipv6_rpl_sr_hdr *hdr, *ohdr, *chdr; struct inet6_skb_parm *opt = IP6CB(skb); struct net *net = dev_net(skb->dev); - struct inet6_dev *idev; struct ipv6hdr *oldhdr; unsigned int chdr_len; unsigned char *buf; @@ -499,8 +491,6 @@ static int ipv6_rpl_srh_rcv(struct sk_buff *skb) u64 n = 0; u32 r; - idev = __in6_dev_get(skb->dev); - accept_rpl_seg = min(READ_ONCE(net->ipv6.devconf_all->rpl_seg_enabled), READ_ONCE(idev->cnf.rpl_seg_enabled)); if (!accept_rpl_seg) { @@ -689,10 +679,14 @@ static int ipv6_rthdr_rcv(struct sk_buff *skb) switch (hdr->type) { case IPV6_SRCRT_TYPE_4: /* segment routing */ - return ipv6_srh_rcv(skb); + if (!idev) + goto disabled; + return ipv6_srh_rcv(skb, idev); case IPV6_SRCRT_TYPE_3: /* rpl segment routing */ - return ipv6_rpl_srh_rcv(skb); + if (!idev) + goto disabled; + return ipv6_rpl_srh_rcv(skb, idev); default: break; } @@ -837,6 +831,10 @@ static int ipv6_rthdr_rcv(struct sk_buff *skb) icmpv6_param_prob(skb, ICMPV6_HDR_FIELD, (&hdr->type) - skb_network_header(skb)); return -1; + +disabled: + kfree_skb_reason(skb, SKB_DROP_REASON_IPV6DISABLED); + return -1; } static const struct inet6_protocol rthdr_protocol = { We don't want to take your credit, so if you have time, could you send this as v3? If you don't have time to land it, we are happy to send it for you. Thanks, Xiang