From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B51283FBB6D for ; Fri, 14 Aug 2026 07:16:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786691792; cv=none; b=UcCwalHD97UuYE7TAQCRUwFBgJTlgnz7QF2ym53q6IbmHIAmYw0vtoML2CW+wy5VaepPQvlSCk9vj+jVxz7eIleu2j8uV3Js6ASK4DwlIj4B68Zn0r32H1krPhD3OHZ8ZZEBNb6xK7icbVwQB/HPVEFshtZO0HKKxvkKRLtmxZ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786691792; c=relaxed/simple; bh=zar0ocNDpzcvZswjGBpDM/SllOQPVDJKH/Jt/EEOME4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fegHLEaFLmIaB+/0QokAt+WDWGhPerZ6MnUyVjLcVbANvfk3yaTGRwHmlSKlaTxGr7OArwIChWPhBTZdEREeliJ9V3TJgJ4VKNh8PS6ZKV6A90TOUHA8/CNfsBW1Q2qna2CVjp0F0QlU4ArTlWCpfRbzDVUn6Ich00G8XMPA35g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZvkVnzbG; arc=none smtp.client-ip=209.85.167.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZvkVnzbG" Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-5aeba09900bso489485e87.2 for ; Fri, 14 Aug 2026 00:16:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786691787; x=1787296587; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=LzIj66XKEQ6RIkUHTy3rFsHtC76rnm8Vm0nnybk33G4=; b=ZvkVnzbGlwD/bbvxuHyRVl0lkiK8gce/82cHu7RHr0hsk0Elrf2ENOGf1JZilNt2FK CZc5mXQbWssxIlQp2k2dXQwlJY9snCYTN558EOT9dmj1uBJjWxG2mh4/DeF2NX79IEM5 l8XWH4GU+Rmw6i9ejOHjtXlHwgYZ00YirMdX6P5lm1H52AXWJDPVLxIX/NB4zKQJm2sr qebGo2GxLRxZLEdEozdUO8NlTGlhxQfC0rGq1op0Y24gGCnc7QRUHqCbys/hDRqhQdYI tBiONe+6mibJaaWR/ob/vvhhd3AsF06Eb2sEupJgOU9pp/GlGXl2yQTfnCUbLkGzjFal 0pJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786691787; x=1787296587; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=LzIj66XKEQ6RIkUHTy3rFsHtC76rnm8Vm0nnybk33G4=; b=nj1+onVjfERkFY9xic+XMfYDZlAhjxe08/fqHJojrFUGei1g6Q6PNxiCBKF2S4x0bj 6y4Hg0ky5/tDX8YUJbnwJhlB69iYK0UgWVAg3/166oaszfRCbFwB50Ja4Oy1NKA/qcXb /jpVOIyy212aHko0AZBd/p4FIp2jgteDESaDWa7FLW3uWTe2TQhtk62jgkx9ob0c+3j6 /Gr3cWVq2PuYJcGov+OhlPzT7gM2+t0EH87n7H2LTXQODGvDQWYCndXBkK/dUM9z1QuO mE8gu+VilWZNHZ2USNOYeylHmynfDVmRLMVONzqSIdEhZmyJWB8SpYn8QXbfkYcbuFb3 enCg== X-Forwarded-Encrypted: i=1; AHgh+Ro76su6NaTtvEAmpsyPdHmmV7G38oNIYxNDrmXGu5qyLhmYMkpGaG2bU+Dz4jEcOOQECEa9rusQeVm5Lr0=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7360FOGcyQVZSwOfsXrxCqHi/1RivEiZ5nRsDaZHLK+KRuWfo cQuWf2AifAXGo5EWKzE+ZqcSdcrbpVz+jzZ3me0O+B7fZg3WnT7cLVee X-Gm-Gg: AR+sD13oECiikzyfMjCOkFFCmFp6d5MW2GUMC4Jv7nrqo8lKTf6CrfxrhwFrUi9ymiF 6gF8kXbIfQK50lks/yMpqlzDiuu80reQ6pGN0ikM4cZxOpxgoDnGYYQlCxc/nYg2+IDJSxpG57a mhsm7EpI51IC29Ol7PkPgh5mNv5F7D2jLk6UVKHRwzaAlttPr/wEdaKDadzeG4NZeU0a2+D/q4V Qe/r3A8xMmPX2MjeETziQxYYICb2vXXxxDZ+TV0WVOmBxwfRPiIJqmYRaO9wVncLbRA2C6xIi5u P+XDHXUGQgDZ2M5wul95SCdLuszC08iIOvqrGd1i5myHxmtYYgBuyHsqFbAnf+85K+wTjeyDGGW Ps03HU5kMZZ1+6LPjjpRLrlVklNRFiELVLBE6Ma5iF9HwOS8mMaNhQTTpbWUHBQepWprCPYHVSw 6ukopDAbTbvuMnIKdI6NKe8o+E4wT4Mv6dtbNFMMGJKywL4JG0qaTR9BMO97OtJBfJEfhj71p+z begpDw6+xshTA/PEddvkGw= X-Received: by 2002:a05:6512:8388:b0:5ae:befc:97a7 with SMTP id 2adb3069b0e04-5b45915d054mr345710e87.13.1786691787350; Fri, 14 Aug 2026 00:16:27 -0700 (PDT) Received: from localhost (host-80-73-162-2.rev.as20985.net. [80.73.162.2]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b458ba5345sm372531e87.32.2026.08.14.00.16.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Aug 2026 00:16:26 -0700 (PDT) From: Andrey Golovko To: Robin Everaars , Mark Brown Cc: Vijendar Mukunda , Shenghao Ding , Kevin Lu , Baojun Xu , Sen Wang , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , "Holalu Yogendra, Niranjan" , Pierre-Louis Bossart , "Dommati, Sunil-kumar" , Antoine Monnet , Ville Saarinen , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: tas2783-sdw: power the Function up before preparing the port Date: Fri, 14 Aug 2026 09:50:00 +0300 Message-ID: <20260814095000.22512-1-andrey.golovko@gmail.com> In-Reply-To: <20260813211858.17509-1-robineveraars@pm.me> References: <20260813211858.17509-1-robineveraars@pm.me> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Wed, Aug 13, 2026 at 09:18:58PM +0000, Robin Everaars wrote: > thanks. One clarification about my negative v1 result: it was not an > active-playback resume test. The controlled pre-suspend tone had completed > before system suspend. Thank you for going back and checking, that is a useful correction. I had been reading your result as evidence about the resume ioctl, and it is not. Your second case is the one I would expect to have worked on v1: a fresh pw-play after the sink was suspended opens the PCM again, so it goes through hw_params() and prepare(), and that is the path v1 already covered. It failing on v7.1.7 fits your own attribution to the missing b627da430357 - without it the DAPM writes that follow are dropped against a stale cache, so the Function never comes up no matter how well the port is prepared. So yes, for-next rather than another v7.1.7 cycle. For the third case I would expect it to still fail, and that is the point of running it: the PCM core does not trigger a stream that was left PREPARED, so nothing in the codec or machine driver gets a chance to act. sdw_prepare_stream() on a stream still marked PREPARED is a no-op too, so even a call from there would not help. It needs the stream state invalidated when the peripheral goes UNATTACHED and comes back. If your readout shows PrepareCtrl=0x0 while the stream is running, that is the same gap and not a second bug. The module is on its way off-list. It reads and prints DP1 PrepareCtrl, PrepareStatus, the ChannelEn of the current bank and the PDE23 requested and actual power states, straight over the bus with sdw_read_no_pm(), so the codec regmap cache is out of the picture. It only reads unless you ask it to write. For a shape to compare against, here is what the resume-ioctl case gave on this machine, unpatched kernel to the left, v2 to the right: DP1 PrepareCtrl before/after 0x1,0x2 -> 0x0,0x0 0x1,0x2 -> 0x1,0x2 PDE23 req/act after 0x3/0x3 0x0/0x0 440/660 Hz tone after -1.7/+1.8 dB +73.7/+88.5 dB The tone figures are levels in narrow bands around 440 and 660 Hz in a three-second capture from the built-in microphone, on a scale where a capture of silence reads about 0 dB in the same bands. The absolute numbers say nothing outside this machine; noise floor against signal does. v2 of the series is at https://lore.kernel.org/linux-sound/20260813194000.10412-1-andrey.golovko@gmail.com/ Andrey