mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Serhat Kumral <serhatkumral1@gmail.com>
To: jgg@ziepe.ca
Cc: leon@kernel.org, dsahern@kernel.org, yanjun.zhu@linux.dev,
	zyjzyj2000@gmail.com, linux-rdma@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	syzbot+8c9eede336e3a843750e@syzkaller.appspotmail.com,
	serhatkumral1@gmail.com
Subject: Re: [RFC PATCH 1/2] RDMA/rxe: drive UDP tunnel socket lifetime from the GID table
Date: Fri, 14 Aug 2026 12:54:09 +0300	[thread overview]
Message-ID: <20260814095409.35416-1-serhatkumral1@gmail.com> (raw)
In-Reply-To: <20260810180635.GB507588@ziepe.ca>

> I'm skeptical this AI conclusion is right? Or at least a leaking sock
> crashing the kernel sounds like a netdev bug, not something to avoid here.

rxe_ns_exit is unnecessary.  

I put pr_info in rxe_ns_exit(): in 40 iterations of a netns whose
netdev is moved away and which is then deleted, rxe_ns_exit() was
called 82 times and found no entry every time.

That is ordering, not luck. With a 3s msleep injected into rxe_del_gid()
to force the window open (timestamps recorded with kprobes):

  rxe_del_gid_in             65.844231
  rxe_del_gid_out            68.677344
  rxe_del_gid_in             68.679284
  ib_cache_cleanup_one_in    69.011549
  rxe_del_gid_out            71.535930
  gid_table_cleanup_one_in   71.536279
  gid_table_cleanup_one_out  71.536313
  ib_cache_cleanup_one_out   71.536321
  rxe_ns_exit_in             71.582488 


So rxe_ns_exit is dead code. I will remove it in v2.

thanks,
serhat

  reply	other threads:[~2026-08-14  9:54 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-18 14:26 Serhat Kumral
2026-07-18 14:26 ` [RFC PATCH 2/2] RDMA/nldev: remove the unused dellink link op Serhat Kumral
2026-07-18 15:39 ` [RFC PATCH 1/2] RDMA/rxe: drive UDP tunnel socket lifetime from the GID table Jason Gunthorpe
2026-07-19 17:54   ` Serhat Kumral
2026-08-10 18:06     ` Jason Gunthorpe
2026-08-14  9:54       ` Serhat Kumral [this message]
2026-07-18 16:01 ` Zhu Yanjun
2026-07-18 16:04   ` Jason Gunthorpe
2026-07-19  5:08 ` Zhu Yanjun
2026-07-19 17:59   ` Serhat Kumral
2026-07-19 20:50     ` Zhu Yanjun
2026-07-19 21:13       ` Zhu Yanjun
2026-07-20 18:15         ` Serhat Kumral
2026-07-20 19:19           ` yanjun.zhu
2026-07-26 14:02             ` Serhat Kumral
2026-07-27 19:55               ` Serhat Kumral
2026-07-28  3:42                 ` Zhu Yanjun
     [not found] <c225c004-1fa9-4010-a843-8be033003e93@163.com>
2026-07-28 17:28 ` Serhat Kumral
2026-07-29  3:21   ` Zhu Yanjun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260814095409.35416-1-serhatkumral1@gmail.com \
    --to=serhatkumral1@gmail.com \
    --cc=dsahern@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=syzbot+8c9eede336e3a843750e@syzkaller.appspotmail.com \
    --cc=yanjun.zhu@linux.dev \
    --cc=zyjzyj2000@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®