From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30B0443C05E for ; Fri, 14 Aug 2026 10:14:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786702475; cv=none; b=J/0a10/fPtMC9mEW68V4BZ+hAPLZk2OZdzNIq7lIJ5aqscV++TlpjG8Nsi1wr5bY1GiNbPC0TAeBW9w/hgdiuppcXMeqWS336a2TBS/IMVCAbRF81ZEcR3WpsfvPribhlE8QBg/Ekhe2iVYRLbKY/o+wJqO2GwSaISfhe09dwkk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786702475; c=relaxed/simple; bh=EOvCzGPQ1wrO77c9ImbqYwELh6n+J6JCozv376VBumU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=OvvKbUGjyM4XmjKSEtGbcHVbtRJBC+0OBDQFoO5tvh71xSGYrickA3mOo1YJ4vClvuPASlrkJHe06uA1FKsyDW3A8obGtRj/rTq2+zp14vUjK+PsoWbfjiSnNPslGakBPKka8iUaOiyPYnxjWyX4Bs0R06RqlQKHOPdG3zKxn4c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PU/9i2PP; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PU/9i2PP" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-381c51fde6bso939701a91.2 for ; Fri, 14 Aug 2026 03:14:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786702465; x=1787307265; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=POFYQl9/S3qYOJeBzB96Y2RvTRQ9VB3bFVtckToWHaE=; b=PU/9i2PPh00fPP7Dt4j3IgQ3WzA57cFO7auzNpGcr/QIG/6zmLlZAn5vQ4pIS58XLn WweABjOipZCwsKfk91XDqrGcfYTaCaO3v0K/b1xNyEgdMjF26u6r/3nzhzg9kW3bp0fC wwKwpQMkQ4NkJAFqlvvePu76hOISXS8AstCIScq0uXq7wyxHdRl4qrkc1WhX4cajf0jp C1DvmuTDmI2CZSlKJEROFFrKJzZbg4eZQWXVLFjk07fUJe2LUzlrk3o3pOVxbNFgdOWg y4CIutgLjyx6bZz+pb9hlGUxxFEWrfKYm+GpMVWdwbWyWdO/guDZow9bga4qe7iCYTQc 3xSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786702465; x=1787307265; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=POFYQl9/S3qYOJeBzB96Y2RvTRQ9VB3bFVtckToWHaE=; b=jeKnEHxqRbcRPdNClayX5zZeCteaVSdJEWoo88XHcRqW6iHFQ56PT7uSDFfDA1cKXx +bAyz1X9bhYsXqutTkaYNV03tlRUWmGqJb119NTIBIUUD7EqEmN0eEgFXdA9gSMrqm75 P3orqHiRHpRwEAmGLDWr44X28wmsXs8OtKT5zMx29FSDd/I0pUqzXVxDRdlYs3OvB1gH fsjm/l2vjv1IVed29InfqSLe1UqYpJkW1rcnT5BOprnAJzfcJ1pBdil1W9VD6/QSJSK/ KN02X/6Tf3ypWhoRe6d+j0It0sJkgM3N9thLunOogJhJZsMAy3bLxju6rByvVCIBcqij q2BQ== X-Forwarded-Encrypted: i=1; AHgh+Rq7HBEzFJ3m7/mUpJYnF2LoTHeHA0XybkBddJFqx1WTiWOFaGa2sM7hHZexBVCmI6W4oGmyRvNZPMMM3gk=@vger.kernel.org X-Gm-Message-State: AOJu0YwTwf7YwoHUII2kJDtfYoBt9A0YBOm9OQMxcZBVdD//EMIbFeje tbKYMlXjsGfR1HViL9ScW24LyxC/RR0IMtU/vr6LRYIHrTP1uBAV+J4L X-Gm-Gg: AR+sD12gebELRSQ4fSq8QnxTAWjWNlsejh19Wb9qS/Lh9JlHX5lTdyww2MbPqj3Lwr9 yica4DA5cJAwQOp+PLiy1OwtqdBeQEOJV1BG16L6GN6VgyZLgnL2YyEWZFPm+WcZ9FDusF3jKtk bE1ff79sS7ux4VHUJPMrTYi5PELbLygvfnf5POeAmNOUB3IxPIxi6PYmisjXhnaeRf0AA4iV7A9 /EReEsGcKksYTNFXgaaU7x4CZq88lSE/qzq4a+SiMh6RMg8wxFvao7WbDsCgtWSwtRUh0/BEgby 1jAgdcNy+L4DP4NsQ0gMJMwgCoIGlVImMJafSPmy41UZn7o8zZLzZ9nhHFIqkneu0aIi4kOOTCH ErD5FBrt8UD/xIAGQTxlY1BPVpxDXT/2mWW1cx5JlUsgZueCHEDNHaL6rShenzYBwGDA9PuFaRM n2srB5YaI40+m5kbjd5jRLOV5O4U289/Gj5Kpb5FI2gcZXatqSPELxsh8chomyhORo89ORUgFgK wOB6/MsYFHLH2eH/01cj2Nsw/A= X-Received: by 2002:a17:90b:1dc4:b0:38f:1dc:672f with SMTP id 98e67ed59e1d1-3933ba72497mr5056363a91.18.1786702465144; Fri, 14 Aug 2026 03:14:25 -0700 (PDT) Received: from amd.ban-spse ([165.204.217.251]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-320e9df03ecsm2772615eec.18.2026.08.14.03.14.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Aug 2026 03:14:24 -0700 (PDT) From: Malathi To: Johan Hovold , Alex Elder , Greg Kroah-Hartman , Rui Miguel Silva Cc: greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Malathi Subject: [PATCH] staging: greybus: use sysfs_emit() in show functions Date: Fri, 14 Aug 2026 10:13:51 +0000 Message-ID: <20260814101351.1023627-1-malathi.a2000@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Documentation/filesystems/sysfs.rst recommends that show() callbacks use sysfs_emit() instead of sprintf(). sysfs_emit() knows the sysfs output buffer starts at the beginning of a page and is bounded by PAGE_SIZE, so it guards against accidental buffer overruns. Convert the sprintf() calls in the protocol_id, fade_in, fade_out and color attribute show functions accordingly. No functional change. Signed-off-by: Malathi --- drivers/staging/greybus/gbphy.c | 2 +- drivers/staging/greybus/light.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/gbphy.c b/drivers/staging/greybus/gbphy.c index bdb0f5164a6f..bb9a5b538e6e 100644 --- a/drivers/staging/greybus/gbphy.c +++ b/drivers/staging/greybus/gbphy.c @@ -31,7 +31,7 @@ static ssize_t protocol_id_show(struct device *dev, { struct gbphy_device *gbphy_dev = to_gbphy_dev(dev); - return sprintf(buf, "0x%02x\n", gbphy_dev->cport_desc->protocol_id); + return sysfs_emit(buf, "0x%02x\n", gbphy_dev->cport_desc->protocol_id); } static DEVICE_ATTR_RO(protocol_id); diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c index cab02b5da867..2689f9a7524a 100644 --- a/drivers/staging/greybus/light.c +++ b/drivers/staging/greybus/light.c @@ -173,7 +173,7 @@ static ssize_t fade_##__dir##_show(struct device *dev, \ struct led_classdev *cdev = dev_get_drvdata(dev); \ struct gb_channel *channel = get_channel_from_cdev(cdev); \ \ - return sprintf(buf, "%u\n", channel->fade_##__dir); \ + return sysfs_emit(buf, "%u\n", channel->fade_##__dir); \ } \ \ static ssize_t fade_##__dir##_store(struct device *dev, \ @@ -220,7 +220,7 @@ static ssize_t color_show(struct device *dev, struct device_attribute *attr, struct led_classdev *cdev = dev_get_drvdata(dev); struct gb_channel *channel = get_channel_from_cdev(cdev); - return sprintf(buf, "0x%08x\n", channel->color); + return sysfs_emit(buf, "0x%08x\n", channel->color); } static ssize_t color_store(struct device *dev, struct device_attribute *attr, -- 2.43.0