From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A954043D501 for ; Fri, 14 Aug 2026 10:19:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786702748; cv=none; b=aWOhoBXcH28ztKLFsQRVraodmSmPT0ardcQ9YM1/N7+JbcRu0K/AmpeJieGigS9I/wWpn87m66ZpOcTpeEKvux2ayVIFlNAXHgJsAmcd9dJOOsmpVg7SxvPxIn8lUd0EtyEx2GHud8JLbJMvDKzDFcZiYiuolB/0Lev8BZTYRkQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786702748; c=relaxed/simple; bh=sjRxSOQ4VFvx+8lAtTY/KAcWMBg150hKkv/kJBdwaY4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qc30/l9GQYP3GT2f5fo0I/KKLN7ghI6tICI28SRzyVc5tiburP5cItj7s3c2a42hm1XmjYtNGDUOP9MQ0J4tFjQ4RH/v8cWr9w2SvFX332TO1dWK4uKJoupfyNM2HQcNrKvzyADhwX0AvOdrnbCKmfiiq0sAcQ4kVljmbg2MP7w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LEulqq7j; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LEulqq7j" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-3810c5d691bso598105a91.1 for ; Fri, 14 Aug 2026 03:19:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786702738; x=1787307538; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=00KFuqOaLqNGyqP39XavbZiyVtoK/fjrOzIbJr0n9VM=; b=LEulqq7jM4tVvlTE9gjIZJWB2TZuKQVRcOVvsXMe6QumZ7hBQRxewzFOL9f+fCqnBF vydLHU3h/eRvNOy8potQ7juhwNLxH4I1jHp/ddnVh7Ds02plOc8ObgowRapXr9UZ6CkV rchRsyMrMSHkVFnN6wjdf46q0G2kfkdeP/78z1SWrbViQdvU0vnJQSTV9C/eJo2dlZag bM1f2jxiGtDWqhB4x72HiAPYdajgfpZ7LpVF3BzcdRzAky4EkkzIiB20AhvUczf4Q45G ddZcFunmU/E8If3NJYgYchmDZmsp4W+CW6uC3ZjM6uRdAHAsHsADhNcwqTDtqrr8Rxmj Jr4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786702738; x=1787307538; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=00KFuqOaLqNGyqP39XavbZiyVtoK/fjrOzIbJr0n9VM=; b=T+Nxq8HECpXqJ4sucQyqlZjr2QKmxDD5tl8Bxt8AB3z5sHB0H1/EQSZnXtlDyHTjjb rLS2u6dMUPD+yNI1fxzmK5Y4DEO6y0ve7DFMy6UPpmwqj/NEQPwgjjhdb/3z3+6I3TWS 4R+1E/8D3Khl+GMt0PdQv1UgSihcFdWOUQ8gBTuhTxJl2V6QEk5qHDOK/Q3r3pBqFZKV stoSrm5pII/Hqed841++nPWpVsOloblgPi+joFfUp+bPL6Ys89LkNKSRRmpSQFxwXsjy OBBtFL0OjRjitl9QBHlGYwIxOSzvamwxALEiCBxqe4cmiA8Pf9vVf0edrVz3bGxwUvfu SO7g== X-Forwarded-Encrypted: i=1; AHgh+RqhxjTvsZuD65ggGF9Hw/urBunpGTjiDYfYt+8vy3AhXJ3DKwPGm0ILWJdWgzoJGjrnY1yed1xbbKU7Wdk=@vger.kernel.org X-Gm-Message-State: AOJu0YwyOMGdgczKDI1eYDJxkUeo5SqCill7S9XkitQXU545r3z424lA c8plUTP1UNslahkm7kHRxokJ5fGU6N6HJsE8wCEPkvoVLFTJwkqfx4FH X-Gm-Gg: AR+sD10WZWUpkIV/fH2c0fhzfL7jxm8lzl3vrnlVHKzfddP5vSef8sxcDkVikcwXhcP oq3SX396YUjCsH/fKU11il0FNlS6NnxrnWNFaC0PAJHaxQ9VracdJBZPbxyy+gWL2F8jadkf6Bm xRey5Jtm22wdIvXurI4CsuG2tZmbL8r8fo+PXwCs0hnsHFzIPpzhQqQcBG2dySmHzD8MgED/h8q ITClhBLABi1xSGjJh+wLQ422FgrBVRRweLE8vfhQa5SzxgSTdUtFl6yqaBb2RzIzvGLoS4i6iKp vS9MAZIzq8su95iYlfPv1TbUW/ozy4vqcu1UXOnP6F3/vhGcwpNRZrvxt6LVCKf+MaTppRu5tQM jniUf2nU5fXBi0kxWiRgLPAVitTNO/1kKQ9v1vU+U7T5ZEBATa1F/lAflQBJDPvQcWNwc+K6JYi hpP8RjG0yYbLBA2jppG0GCNaQlMRki/eeynXEZbAA/b8B9HugnFsjrfQOuY+RgCQg3MFvMZFxVT b85iyzw X-Received: by 2002:a17:90b:48c9:b0:37f:fdc8:71b4 with SMTP id 98e67ed59e1d1-3933b6ea768mr5561433a91.2.1786702737700; Fri, 14 Aug 2026 03:18:57 -0700 (PDT) Received: from yash-Bravo-15-B5DD.. ([2409:40d4:124c:2e49:6997:3d3f:909e:c279]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-394e920ba18sm2074218a91.0.2026.08.14.03.18.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Aug 2026 03:18:57 -0700 (PDT) From: Yash Suthar To: jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, yashsuthar983@gmail.com, grondon@gmail.com, linusw@kernel.org, hexlabsecurity@proton.me, sakari.ailus@linux.intel.com, srinivas.pandruvada@linux.intel.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] iio: accel: bmc150: use aligned scan buffer for both trigger and fifo Date: Fri, 14 Aug 2026 15:48:42 +0530 Message-ID: <20260814101845.301769-2-yashsuthar983@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260814101845.301769-1-yashsuthar983@gmail.com> References: <20260814101845.301769-1-yashsuthar983@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Drop buffer as duplicate and s16 is not correct we needed __le16 as little endian, keep scan at the end of the bmc150_accel_data struct with IIO_DMA_MINALIGN, and use it for both paths. Fixes: bd7fe5b71918 ("iio: accel: BMC150 accel support") Suggested-by: Jonathan Cameron Signed-off-by: Yash Suthar --- drivers/iio/accel/bmc150-accel-core.c | 10 ++++------ drivers/iio/accel/bmc150-accel.h | 14 +++++--------- 2 files changed, 9 insertions(+), 15 deletions(-) diff --git a/drivers/iio/accel/bmc150-accel-core.c b/drivers/iio/accel/bmc150-accel-core.c index dc8a6285cf3d..596ff8267ead 100644 --- a/drivers/iio/accel/bmc150-accel-core.c +++ b/drivers/iio/accel/bmc150-accel-core.c @@ -1191,14 +1191,12 @@ static irqreturn_t bmc150_accel_trigger_handler(int irq, void *p) mutex_lock(&data->mutex); ret = regmap_bulk_read(data->regmap, BMC150_ACCEL_REG_XOUT_L, - data->buffer, AXIS_MAX * 2); + data->scan.channels, AXIS_MAX * 2); + if (!ret) + iio_push_to_buffers_with_timestamp(indio_dev, &data->scan, + pf->timestamp); mutex_unlock(&data->mutex); - if (ret < 0) - goto err_read; - iio_push_to_buffers_with_timestamp(indio_dev, data->buffer, - pf->timestamp); -err_read: iio_trigger_notify_done(indio_dev->trig); return IRQ_HANDLED; diff --git a/drivers/iio/accel/bmc150-accel.h b/drivers/iio/accel/bmc150-accel.h index e8f26198359f..9deff256aed5 100644 --- a/drivers/iio/accel/bmc150-accel.h +++ b/drivers/iio/accel/bmc150-accel.h @@ -64,15 +64,6 @@ struct bmc150_accel_data { struct bmc150_accel_trigger triggers[BMC150_ACCEL_TRIGGERS]; struct mutex mutex; u8 fifo_mode, watermark; - s16 buffer[8]; - /* - * Ensure there is sufficient space and correct alignment for - * the timestamp if enabled - */ - struct { - __le16 channels[3]; - aligned_s64 ts; - } scan; u8 bw_bits; u32 slope_dur; u32 slope_thres; @@ -85,6 +76,11 @@ struct bmc150_accel_data { void (*resume_callback)(struct device *dev); struct delayed_work resume_work; struct iio_mount_matrix orientation; + /* Ensure correct alignment of timestamp and DMA safety */ + struct { + __le16 channels[3]; + aligned_s64 ts; + } scan __aligned(IIO_DMA_MINALIGN); }; int bmc150_accel_core_probe(struct device *dev, struct regmap *regmap, int irq, -- 2.43.0