From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D10648F839 for ; Fri, 14 Aug 2026 18:51:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786733462; cv=none; b=pdb44npVPyv6Kg44xQQw1vGr7d9k6Ro90dkZue0Xp9jl23FI4xxbP/s9piiSyfA7PmSJ4c5QNg6t2+Yb1pvD1PQE8AFUTMRcI4D/YaVZRpeKZA4AkxDmlklIbNWDmbuWHc9h09mHqbCb1AGxc15NZL3n8XzgB8S+3ED1kzFQX+E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786733462; c=relaxed/simple; bh=h6dskMjDaYvXUEqmAjvoBa4mHB98HzGpO5dIROEKGDM=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=dBZGXqQMNZ/DAECcyIef5VnRly9qdBc0U9rONXVInxEJ2UIRnZJvYPWx+C8qYU8PcRR1G6uT2/gJsCEP4tSDj2RyMJmiWt3TuoIOL74JyaX9ORHRP/gzdHo11ql62Bp2KgN2aCFJ7BAnLINPom+eoAUwaKn2eLLWhqcc9uN8UBw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=mzXT+Uop; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="mzXT+Uop" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B56F01F000E9; Fri, 14 Aug 2026 18:51:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=korg; t=1786733461; bh=TV8bUkdBfVbHLoK7BDmT7kXxjVr5tsUwBjeyEdijATs=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=mzXT+UopQ5TruH8fdX2R5O64VKqLtjeMTGinJHqMfmSQVGWmUXHgfvK+vTAj90Bgs GUJGekglByQFLxslwQZKmlIO34m8kThXvkhZvKCcBjNHVnbPhD5vzNNNA2e84P/+0Z k0jJP+3SYgqRKUN34ZUxuJzVSN7LFLuZdUPeO2Qc= Date: Fri, 14 Aug 2026 11:51:00 -0700 From: Andrew Morton To: Hongru Zhang Cc: linux-mm@kvack.org, david@kernel.org, liam@infradead.org, linux-kernel@vger.kernel.org, ljs@kernel.org, baohua@kernel.org, mhocko@suse.com, rppt@kernel.org, shakeel.butt@linux.dev, surenb@google.com, vbabka@kernel.org, willy@infradead.org, zhanghongru@xiaomi.com Subject: Re: [RFC PATCH v5] mm: retry page faults once under the per-VMA lock Message-Id: <20260814115100.24a6be0cd0e672cc3c051f86@linux-foundation.org> In-Reply-To: <20260814085300.399107-1-zhanghongru@xiaomi.com> References: <20260814085300.399107-1-zhanghongru@xiaomi.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 14 Aug 2026 16:53:00 +0800 Hongru Zhang wrote: > From: Hongru Zhang > > The per-VMA lock fault path falls back to mmap_lock on VM_FAULT_RETRY. > When mmap_lock is write-contended, the fallback can reduce page-fault > throughput. > > Add a single retry under the per-VMA lock in the arch fault handler > instead of adding a new VM_FAULT_* flag. > > ... > > Swap Throughput (higher is better): > +--------------+-------------+---------------------------+ > | mmap writers | Vanilla | Patched | > +--------------+-------------+---------------------------+ > | 0 | 17303.09 /s | 17899.48 /s (+3.4%) | > +--------------+-------------+---------------------------+ > | 4 | 12596.23 /s | 16095.20 /s (+27.8%) | > +--------------+-------------+---------------------------+ > | 8 | 0.58 /s | 15420.57 /s (+2658619.0%) | > +--------------+-------------+---------------------------+ Well. > With increasing mmap_lock write pressure, Vanilla degrades sharply and > drops to near zero at eight writers. Patched kernel holds up much better. Thanks for working on this. Are you able to help us understand how much effect this change will have upon any real-world workloads?