From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96E1D45FFB6 for ; Fri, 14 Aug 2026 14:40:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786718458; cv=none; b=gAaAtB0+6YrZ/yu+VpTkVIGmx3QenhTmkIAaN1KdpfPtMILmyFlJaB7gmDi1jaGzheXi/5kYZ0OUlWwiDt0CxPRrwOi1J44ZHqs8g25kaRq12//Fk6H9Nk01hf5rb8RY+jPVOUdUIwLGuj8VZGlVfIX+tcNMg6YFrfvge3hUz34= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786718458; c=relaxed/simple; bh=Yl5uiFFHOp2PyXi4gYfnS3yjeJG3bLm74K6yWesuz/4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=N2iw62pX7tQETn3+Cbw/bLcisFxLx2tWzRHCvx3flP6JhSsQxUtc0Dtu+OCpSNINl+rsemCEZPauSNIpv9f/Km7P4N+fFQpiH3u+9kjbUt3vbrxgXcwo6YpNj7ss9+/+o3u8yRPZwcTO8KQdjTjtMx5WsLeseEvjAcrgfuyihnI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l1HDr342; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l1HDr342" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-38e347638adso1322456a91.0 for ; Fri, 14 Aug 2026 07:40:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786718454; x=1787323254; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to :content-type; bh=rzvR50quFRSKXQACja47gJ2tPaACguFd0a1yLD/bk+I=; b=l1HDr342ugJctZVDeYXP/zUMimTgtsW9m6puhsduFpzd20wbcSK2mJi5hqy5qCATYj jKiYRC2ri6EhfO3R+IV7KVmInJo5a/bchz+e+36Fk4pD7XdiEEKGbgGv8q2mVw/Hi18a NQJH/nSf/vMAdoQPzvSRhG9gHp/kb11v0pqogxVPb9M/h1RLmEL9swnIS+fBcaJjWbDJ wMw1qGEF+zPsxNY1lkUJmYnzXIOJh1mZlDShRO36pjrmv8k2EdNuzJ4q7Xs6fgJhbHZo C3mkV//8yx9Wbqfx9luTgb7J+gEGby3dMMAEEDcQ7QFeCicYYiCNFRdqL4yNtxNWVRp4 ci6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786718454; x=1787323254; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=rzvR50quFRSKXQACja47gJ2tPaACguFd0a1yLD/bk+I=; b=RXtyxqIrI8JY9uglVrT3c11WBkJmsSEUBzthpSYJhqJEo48m/zBOhkSK1R7ruE08D2 tM+ZLl9grPWY2o41A+8kyihbNYo83U37R4nPIIWgc4lnXbx61aHHgEgJ90ir2ZSpMf9u LkN+LEt7R0IciqeixgcM1A0qVNxApomGagaLb+dAGRL6oSPGrsgV/0s86Ca+TCyRA0AV VfamDgTHOPDFRqKQv/0a8y8z+HURjBuHTaB8ugEkolheZHatNSe7nt31v3JLAJ0VVpDO CYu4dfd/4Th9cTp6vjOc+ws3+/wcoayhCBKEMVmcpVE+AfV4Yi+DNlkMopR4xnCTZFw0 UlQQ== X-Forwarded-Encrypted: i=1; AHgh+Rq8FHz+3+d01/h7zkxllvDck9q2ZUVF3WUbrW8vLtwi5DgU3hn/xMIIyTgNfjKm2cgEmM6rKEN27M+noZE=@vger.kernel.org X-Gm-Message-State: AOJu0YwB+f+G7CleJQ5SSyoIHUDFpC7VlQOeUEKNxp8rO5mCNJf7qkPU BvOm4LZVIGE/+9f27v2TIsshS+2bd2ED3onJVkWFpBzXY9RQufjrv5FU X-Gm-Gg: AR+sD12QEk9zogbeRLkkNGajg16R3vwrhLetFqv/wptlpDn5porNHS+HEsPvJNwUqMY 6uaZyotnkTgGdpikSZd3SM3h6IxWYbsB5iCAVM+p2upnBNDlo33sOIEpocDu+qTOFeBr/T/T+af EOhU/6RlgIjJtLuJoI4Q88G/R2SbaTXwimW2VneOOLnZE3knDh/n7fOdPmhHjsCkvftA9SNnqWs QUQeZKJHMQX3TSneadTaLx/uxsCOLAZ6U4xN0vXDzk0mcs6O3CYELekCvg8xVLXJPT+U3x7S9vM WEzJmFtT7rih4y3y1fszxyMKqIeExLJ3pDNlmLG0Bg64bPjyavPlpTfJw7ZjzYhsraiJDO5odvj /C5BjplUUrSheJXbRwMpDjws6ILOfh8w51T1DWmoEpp3amj3xc6CZG3LctGIYa4kDwRPU4Ee4/9 wU4gnshCHMSiUoofO7gwevQFyOfllk2ckajwRJ2e6rg937NCpixbDBl+GGUa4xmx9bfjnErR/ZL ydguhGP4Da0PIVpQvIc6ZhKaV6LsX1bLwk= X-Received: by 2002:a17:90b:17c5:b0:36b:bec8:94c5 with SMTP id 98e67ed59e1d1-3933b874ad6mr6546913a91.10.1786718453590; Fri, 14 Aug 2026 07:40:53 -0700 (PDT) Received: from fedora.fibertel.com.ar ([200.55.79.212]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-320ea8fe4c2sm5021125eec.29.2026.08.14.07.40.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Aug 2026 07:40:52 -0700 (PDT) Sender: Mariano Baragiola From: Mariano Baragiola To: Johannes Berg Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] wifi: mac80211_hwsim: require exact alpha2 attribute length Date: Fri, 14 Aug 2026 11:40:47 -0300 Message-ID: <20260814144047.1130527-1-mbaragiola@linux.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The HWSIM_ATTR_REG_HINT_ALPHA2 policy accepts one-byte strings. mac80211_hwsim_new_radio() later copies two bytes from the attribute into data->alpha2, so a short value reads beyond the attribute payload. Require the exact two-byte payload used by build_radio_msg(). This rejects malformed requests before hwsim_new_radio_nl() handles them. Fixes: 26b0e411d37a ("mac80211_hwsim: restore regulatory testing functionality") Signed-off-by: Mariano Baragiola --- drivers/net/wireless/virtual/mac80211_hwsim_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/virtual/mac80211_hwsim_main.c b/drivers/net/wireless/virtual/mac80211_hwsim_main.c index 02b6d81cccd1..4a567a2d885b 100644 --- a/drivers/net/wireless/virtual/mac80211_hwsim_main.c +++ b/drivers/net/wireless/virtual/mac80211_hwsim_main.c @@ -876,7 +876,7 @@ static const struct nla_policy hwsim_genl_policy[HWSIM_ATTR_MAX + 1] = { [HWSIM_ATTR_COOKIE] = { .type = NLA_U64 }, [HWSIM_ATTR_CHANNELS] = { .type = NLA_U32 }, [HWSIM_ATTR_RADIO_ID] = { .type = NLA_U32 }, - [HWSIM_ATTR_REG_HINT_ALPHA2] = { .type = NLA_STRING, .len = 2 }, + [HWSIM_ATTR_REG_HINT_ALPHA2] = NLA_POLICY_EXACT_LEN(2), [HWSIM_ATTR_REG_CUSTOM_REG] = { .type = NLA_U32 }, [HWSIM_ATTR_REG_STRICT_REG] = { .type = NLA_FLAG }, [HWSIM_ATTR_SUPPORT_P2P_DEVICE] = { .type = NLA_FLAG }, -- 2.55.0