From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E6EF48F849 for ; Fri, 14 Aug 2026 17:15:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786727724; cv=none; b=lz4nf1HcCY6MQl1PMzKdAnfCiFbrL/LGLWrye6Kj1UhH/mnf6uLQmgL7bY6ypTC5q029pwnAq7+IhI5VSvz0oFDk3jSt75/WdD/g61aHr75wzhYJL+yv82y4u9l/cF6RN97PASZ7Ex1usS32cfejZR16Sqsk/bnSASm5wAazbhE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786727724; c=relaxed/simple; bh=rAIZLVjKGNG+y5bKDCvSwEHs2PLOnmVm1kYSBVKJnHM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iqoCmjkhdAfyu2uWzexr+0RkmS/aCSsbSyVBz5InhcrVdSwz44tr/4KiAYWrwDlxLV9UDbDfWQ09+JMimAYJSwF4KYXfJPSxSg1thfAbcOIZsE0PZXL5awGtyC7nWnWLqbgao47rUqf5Cuv3s/z6NweRCtMtEzt1Xv/wS31WTpM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZtRLp+n5; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZtRLp+n5" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2cc7e86e7aeso14320575ad.2 for ; Fri, 14 Aug 2026 10:15:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786727721; x=1787332521; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=J7NzHtDJgIE4Qs9o6UwfjLslH9XWPzhykTS9dM7bn5w=; b=ZtRLp+n5AG/W44OC8RVpPIerN475tbNRmjazG6DcRkw7VtwnP8f/F+tpAGIlcszPA9 yCWuo9nhsw+hHfgz+EtMcDi8d3a05Igjs7L/FUhcLypjPQnUWUo9tbrf8EhyvczJNRKt 1k7ET9S9d4dToYHJQ2Zy1kiYCiKi7/etZEEsPvY5VQ5XJ5skNL8hquQ31sNuDYuwCEqS hYJb0GTrNsrcpta74/YT02jCU1J/AOo1ldzmcVMqbVpK4LMEgG8jFJ+OU/HTo+ZHr3KZ 8mItPxKAyAmt7a+5p5jnYcO+5OkgGzKU1Cash/QLje5N4gauqPdhXWjsTVLKzlXxFYj5 ZUeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786727721; x=1787332521; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=J7NzHtDJgIE4Qs9o6UwfjLslH9XWPzhykTS9dM7bn5w=; b=dvk0KlLwtqG1pPC4FgPPb9I+eLARnZ2g2fp7w05wzVRv7ZTbKhwwgxMVDrmNBVBlEj ilBdwhw8ZgY+c281tRqHNpJ4cQRE4D8AQTxIGEVxAl1fQPyxNdICaqH1MiXF5YJnMnll DlfQWJyKg2fT3zHYBrWZsvDVCp3XxEIDGBLVMyOsKeGeuiKvE/fhRHKAAx+5ydr2bxIa KKygGewUUtsHDHyOkJ4hXen9ZtFMVvaJqqdpvkPbsPWIST8v326R1UTgIpIHwknvYtJV 3kwji8EtyjUUr1foFt305jYoCLx1dj+RJwag49s63ns6HvfHt955Hwf2YHWT0zUqAqA+ kizg== X-Forwarded-Encrypted: i=1; AHgh+RpVEpHVI/C50Vs7ptu/thykTml9fFH+OM27bs1JzEDTPU2oEUsSBZr1Pu7vLh3kd8HCghxS9ZKWWJPi8sA=@vger.kernel.org X-Gm-Message-State: AOJu0YzU9+OfqjEyz6GD61wLtbzlO/gnVlam69O/gx6tssis6Wcht8pD vWYl2hZBSzEad/kRTpbUMWlh50gP7E+evD5zqsPIXhRwgyfb0HMNXhdv X-Gm-Gg: AR+sD12bhvdp/LXphDXjk7WJ7JiXRBz6i++LV9IMr5BHtPir5U9sIgFDR0qpWGx0e4P QaY8Ky+bI4iNKgqkxbhThpcGZt8jOzTm+SXH7UXftLPPMC0ovpiKN8Kl0CUdhKJEjj8uB1s+evK 31mM/OupFRTGXnJaH0OGWfimfsLD7Zj3ywYDl+ngwlP0BhxYf3O0s26u0JK+jRWTIXd8a/ZkeK8 YL4uwDuR22Hjqug/kZ37AdVFYcNaY1kYF9+r7USPSE6Uxn0ZjJ843FNkw4yjtAlGXcv+tHXQxFR Xl+TsjX8MZU9GRnuauKmpVMqb1L0wxzHpPRLYrh53gc7oGKlgpXQ2ToPYH7rbBiGuHMRXBrRDnV BoxxhR8LBXgyZsQZ5ISAnJq5UTrA+Gw5ngBXbaFV4L2VO1uEC0c4hys5LvWMH5fAb/q59TgNBLR RvOWt86fKlrFfn6Uh0xuoNv23s5SKWCvkhO/Z/WPoEIN3aysh88ipOak5LHYrB1iu+GCY1KMtBy H72GTNnSPA/lbGjGb0qVymqrI+kYOKgDEXe1cQraLcRdjOPt8Xu1LrRHivUd4npt3wNMXVMZDA8 /SUQMWqoe1qIurc0LscVpRtTyMHaEyGlMikAOG9v5F+tupmtOvZnwoUckaheA8aHkLuVmXg0oSl cXS89UJrkF6WS39J7hI1TPmSu3RZiGI274Tbsa1FvTHVnobEIMgE+3RXiBl4= X-Received: by 2002:a17:902:f603:b0:2d3:78c2:1f19 with SMTP id d9443c01a7336-2d3b0c5798cmr89161055ad.9.1786727720384; Fri, 14 Aug 2026 10:15:20 -0700 (PDT) Received: from localhost.localdomain ([101.251.7.10]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-320ea2f787fsm6182234eec.20.2026.08.14.10.15.16 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 14 Aug 2026 10:15:20 -0700 (PDT) From: Laxman Acharya Padhya To: linux-bluetooth@vger.kernel.org Cc: marcel@holtmann.org, luiz.dentz@gmail.com, linux-kernel@vger.kernel.org, ali@iusegentoo.com, raghuram.hegde@intel.com, kiraank@gmail.com, kiran.k@intel.com, ravishankar.srivatsa@intel.com, amit.k.bag@intel.com Subject: [PATCH v2 2/3] Bluetooth: btintel: bound firmware ID by TLV length Date: Fri, 14 Aug 2026 23:00:02 +0545 Message-ID: <20260814171503.42684-3-acharyalaxman8848@gmail.com> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20260814171503.42684-1-acharyalaxman8848@gmail.com> References: <20260814171503.42684-1-acharyalaxman8848@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The firmware ID is treated as a NUL-terminated string even though the TLV length is its only boundary. If the value does not contain a NUL terminator, snprintf() can read beyond the received response. Limit the conversion to the advertised TLV value length. Fixes: 164c62f958f8 ("Bluetooth: btintel: Add firmware ID to firmware name") Reviewed-by: Ali Ahmet Memis Assisted-by: Codex:gpt-5 sparse Signed-off-by: Laxman Acharya Padhya --- drivers/bluetooth/btintel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c index 26435e41f1ce..c204e9a1cd0f 100644 --- a/drivers/bluetooth/btintel.c +++ b/drivers/bluetooth/btintel.c @@ -701,7 +701,7 @@ int btintel_parse_version_tlv(struct hci_dev *hdev, break; case INTEL_TLV_FW_ID: snprintf(version->fw_id, sizeof(version->fw_id), - "%s", tlv->val); + "%.*s", tlv->len, tlv->val); break; default: /* Ignore rest of information */ -- 2.51.2