From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB7CE471272 for ; Fri, 14 Aug 2026 17:15:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786727729; cv=none; b=dUO7vsEGTCJ+qdtXeu77gTjvYA0V3ZR4sKewUw6B8Bse9tiR6PpviHOlAcKsYFWJRATD+Rc0XRLYBywsoUsamF0K5zV+v/k/xV47pZAHo2unk0dCPfSIg2/IWiml5q8C8J2VdDObUL/+GkhQb5uALCHsgkYl+DJ4vXd/itzieMU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786727729; c=relaxed/simple; bh=PdwSVh1m2noCaYpQ4pBbEWTeQEFQNhww10+UT/Lh9+U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gDUIPrV1vQUgkUuC3qWONBosUHLYVLHfb669dxC/YHfoX7GVrExPv/4IBscnSrESgBExPkpdOtyro8gLuADh2gwWdo5UYzODXXXSoc1U8bl1uPN4PRE6SmifOiDINF6mhtg3DhM9PszQIc5aM64vkwONdYHnw+hZOrWkb2FdJJQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hxTiifO8; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hxTiifO8" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2d049069377so14253785ad.0 for ; Fri, 14 Aug 2026 10:15:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786727725; x=1787332525; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ixYtoj+XjtvI8L7Upds4AZfaN4qSfYVwO3/g8PBQNAw=; b=hxTiifO8altvhNW3y7yhRU0tmQdon0FS5/AKHiQciU74u9zDKV2R9vbjpJmaJrv+yb mKUmjG1hLxbwblhXoOoavHf9moxrr/yffDqfZqFDj/2h91BCGpgPxZ3S17Y4gcDVtW4n VamO3sEsR9ZWrfedgaiCqpNuXDUvs5XEWJP8iIe7uGMQs2gPyv2vilsanjZWUwq5y8rb xIVx9S/U4QCwZB69CknBR5SADFV4R/PEeDbaAD9+ICotLe4GuYRfqiE03NdxNB5esgeQ 0jULKXsf8AOESsHyK+Opth5aoYys1nqVKXO8XGs+PgJXaNI9ew24+F4KOrjjRzJ70KF8 ob/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786727725; x=1787332525; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ixYtoj+XjtvI8L7Upds4AZfaN4qSfYVwO3/g8PBQNAw=; b=UBka2Be78qbDebNf1S+6CfVEfHd1R9iMiZ7wiE7ZwjgsxXxdm0atUEBMvo4OWUR9qO LgIQTZEVE24K/T0nE3V+/u39R6BaiPtpQLu1gNJ3sbHk9UJowCXlgIh9vg7O/WkgMxE5 6zlFsttPcyl6+UpH9lzRbJSeFiU7z8WGxEyR9O1y9gPvdseD7p29XfOxXvRKSaVlxYnD AZ0MZEM1LlZHSw/p4kzeYS9Rs3pMfPNpJ1oHsKJWucrYBozQhsBst8Vuaf8/1zWq5WtW /KSTXq0p4I/WN9kVQYwpJ7HiYLXcvxAovL36eT4D9D/1zhAGm8huHZBYZgWxvY8m3HDW yQrA== X-Forwarded-Encrypted: i=1; AHgh+RpoAJUFqdDFKYjkFzbUyvw6lnbsrfzI6/XRv57H+gnHHvl6MZu6glipKpLz3X4sfzudnpVuVakkMkd5Sfk=@vger.kernel.org X-Gm-Message-State: AOJu0YzjgNnFPYTiHVVTSzEMhdPIu2XPCKUNyXXIFcocATtgCxXgm36w DM65kIOYKmBLjOcZeN32Ugr1ZaEU1JmAcoGQuOGv1PL6O2SZRjOMZ6SL X-Gm-Gg: AR+sD10tTHi0zMvPYYxYNCUCXfaQruyXmSk323F0rOAw7KQavu1DKGJSoILH0bySkM9 NSKgIeaneonM7X7sXfuKFTOACs1Gcj+zBnAgYf4oUnwlmo9lf1Hi4vJNC+WnoiFreWYFJyNSfR0 /OOR4GfyDAJdOSZ+ocjJz5WddxnpVlvy4hi3au6y5GlsJlklqr1dJJI94PKC1GIaiPklKk+ZZDV Kf5RqU+irka5MOmKs3J07BJcnz9ADQZPjk8osnPKFyHewi5P6cuSMiPO7WbrsWvdpDz3pI9NrV2 4MteCVDd1mXxQ60CgW48uHvWbScuM2jYN3rKmBcjsFTPzxhrmTKqVX5sd1V9IHtqFskNiZCwn3f uJyhLqofIldzuyLlewEf15RfisUwk5IKrzJZGyJzoeDl0WWJwgWgKQOOWS4GWrDA0cN/nKdlKAm pUwP/aR51mdMUZGLhN/fkEHtohw3vGsH+Ny0lkrsXMKBjHhhEQeUwa8eGPmpJjUntHl1GMii/tI n2ucPXee6MNqEOIzG5mXxzwQbqiXMWeDb3VVcuMQiIAGxrL1/nB5sfM+RhTuqlBs4+TOUXBG4Wa yESEmzfQpuUiclVewFFZy8o3EII9mbzioQU+vSCdG62eWD/IcfSHvJJ7eKZcLaTstlnT3Fu3WCa Zc57e1Mnl3EmQKZP4OQ7+4Q8qpSX1o96lHvsxvjwZnlFPuR0v X-Received: by 2002:a17:903:1850:b0:2ca:f21a:a6c5 with SMTP id d9443c01a7336-2d3b0aeeb01mr94809315ad.1.1786727725569; Fri, 14 Aug 2026 10:15:25 -0700 (PDT) Received: from localhost.localdomain ([101.251.7.10]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-320ea2f787fsm6182234eec.20.2026.08.14.10.15.21 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 14 Aug 2026 10:15:24 -0700 (PDT) From: Laxman Acharya Padhya To: linux-bluetooth@vger.kernel.org Cc: marcel@holtmann.org, luiz.dentz@gmail.com, linux-kernel@vger.kernel.org, ali@iusegentoo.com, raghuram.hegde@intel.com, kiraank@gmail.com, kiran.k@intel.com, ravishankar.srivatsa@intel.com, amit.k.bag@intel.com Subject: [PATCH v2 3/3] Bluetooth: btintel: propagate version TLV parsing errors Date: Fri, 14 Aug 2026 23:00:03 +0545 Message-ID: <20260814171503.42684-4-acharyalaxman8848@gmail.com> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20260814171503.42684-1-acharyalaxman8848@gmail.com> References: <20260814171503.42684-1-acharyalaxman8848@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit btintel_read_version_tlv() ignores the parser return value, so setup continues with partially initialized version data after a malformed TLV causes parsing to stop. Return the parser error to the caller so an invalid response fails setup instead of being treated as successful. Keep this behavioral change separate from the bounds checks so it can be reverted independently if an existing controller sends malformed data. Assisted-by: Codex:gpt-5 sparse Signed-off-by: Laxman Acharya Padhya --- drivers/bluetooth/btintel.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c index c204e9a1cd0f..934775e449db 100644 --- a/drivers/bluetooth/btintel.c +++ b/drivers/bluetooth/btintel.c @@ -720,6 +720,7 @@ static int btintel_read_version_tlv(struct hci_dev *hdev, { struct sk_buff *skb; const u8 param[1] = { 0xFF }; + int err; if (!version) return -EINVAL; @@ -738,10 +739,10 @@ static int btintel_read_version_tlv(struct hci_dev *hdev, return -EIO; } - btintel_parse_version_tlv(hdev, version, skb); + err = btintel_parse_version_tlv(hdev, version, skb); kfree_skb(skb); - return 0; + return err; } /* ------- REGMAP IBT SUPPORT ------- */ -- 2.51.2