From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.migadu.com (out-143.mta1.migadu.com [95.215.58.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81A96490C0D for ; Fri, 14 Aug 2026 17:32:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.143 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786728765; cv=none; b=JYA52sHYU/C6doE7mQxq22Nj+2LrlBmfc/ExAm6Ah1CsCc7hKgi8DbcAcQRqWBp9wflcr3rf/Rge39TU4qZEccS3ZQFPARbguPHvSyXPG02Ps9iZra/usNhGEn6LGeSHISnPVNJEt9x5YC5rQI1L/Bemt7c2ngl3dLN+xDL6XxM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786728765; c=relaxed/simple; bh=3ENQ7a7ZVw1Jubs+Y/z29VuNIVqciMWe+bFwERZaRYk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=p/mpBGqqr8v7UM5cGyhUhY7VS1egWfXfr4hAn7Hb8zcrnxrIh5GUSd0pz9CO6HclB8Zxe5z5VO9zPI7ukBXewWvzH9am4mPlzjYBKNFHCofWHIEPwO6skHX3prgNwEeGrEV0QEqW0FAxna3IS+7eLDbYxLNomHJkm0WD3csHjVE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=WhVLc8aS; arc=none smtp.client-ip=95.215.58.143 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="WhVLc8aS" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=3ENQ7a7ZVw1Jubs+Y/z29VuNIVqciMWe+bFwERZaRYk=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1786728760; v=1; x=1787333560; b=WhVLc8aSP+JaFkIeenB2MCaCfXRBO+2Fr/IXBTfyiWG7flhrMBPrhSrPafwu+RgNdz9/DQgB w2LMV+P6WmMvuxKFd0ALtK0o9QwAetxKCdnwaOXgJBPDTiEVLeXey3yk2fDUFz1FTiMjhSPvqH8 pdXIRBy4jx75ZmOeECv1fdCE= X-Envelope-To: linux-kernel@vger.kernel.org Received: from .linux.dev (117.20.149.103) by smtp.migadu.com with ESMTPS id dd5d7441ddaad0d1; Fri, 14 Aug 2026 17:32:40 +0000 X-Migadu-Flow: FLOW_OUT From: Leon Hwang To: bpf@vger.kernel.org Cc: Alexei Starovoitov , Daniel Borkmann , John Fastabend , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , Ihor Solodrai , Quentin Monnet , Shuah Khan , Leon Hwang , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: [PATCH bpf-next 3/5] bpftool: Update comments about skel data maps Date: Sat, 15 Aug 2026 01:32:04 +0800 Message-ID: <20260814173206.93082-4-leon.hwang@linux.dev> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260814173206.93082-1-leon.hwang@linux.dev> References: <20260814173206.93082-1-leon.hwang@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Since is_skel_data() includes the non-memory-mapped percpu_array map, the "memory-mapped maps" in comments are incorrect for percpu data. Update "memory-mapped internal maps" to "skel data maps" for better explanation. Signed-off-by: Leon Hwang --- tools/bpf/bpftool/gen.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/bpf/bpftool/gen.c b/tools/bpf/bpftool/gen.c index a50540ef6521..e5e82255af24 100644 --- a/tools/bpf/bpftool/gen.c +++ b/tools/bpf/bpftool/gen.c @@ -303,7 +303,7 @@ static int codegen_datasecs(struct bpf_object *obj, const char *obj_name) return -errno; bpf_object__for_each_map(map, obj) { - /* only generate definitions for memory-mapped internal maps */ + /* only generate definitions for skel data maps */ if (!is_skel_data(map, map_ident, sizeof(map_ident))) continue; @@ -510,7 +510,7 @@ static size_t bpf_map_mmap_sz(const struct bpf_map *map) return map_sz; } -/* Emit type size asserts for all top-level fields in memory-mapped internal maps. */ +/* Emit type size asserts for all top-level fields in skel data maps. */ static void codegen_asserts(struct bpf_object *obj, const char *obj_name) { struct btf *btf = bpf_object__btf(obj); -- 2.55.0