From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE35D49505F for ; Fri, 14 Aug 2026 18:26:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786731997; cv=none; b=madWXKyUn7/kI0s6lsC/icxGVGB1urEdpzSaylQj3ow1rFpl0Mc2Yzt0v05zxopT+YiRAlPRnmxiXsShxKpu58IsEffi3SlcwhII2NTTKq3jvqbYKMxTYI7b9B5onTeNVHnbEgy9l+xntaZlTziEe6HSDfD9J2Bn2E5bzf+SkS0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786731997; c=relaxed/simple; bh=mydrn5/cs2rpyHWM3BEYePgDcRn2+lrny/8dmSL9bkQ=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=Bj+7grmVzKkYU+ND18SjkZ7xlgFTYR5rkVEqrq4dWwHtda9otiy7gx0tJ1QiZfVkf1SWxz3FT3dzsBe3OQyVbrSxlK+P9JJ8mxD9eJaD64qvdqOr2BM+tQIylF63154+FK420rnYT3T9pDxfUuQ19tNPng0GPcM8n1PApGQzLcM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ckrrj/Me; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ckrrj/Me" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AAD3D1F000E9; Fri, 14 Aug 2026 18:26:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786731995; bh=6H0lVRt/Lz8NJqTC89DqVCwMoG4u7K7dtDUcdcELjCQ=; h=Date:From:To:Cc:Subject:References; b=ckrrj/MenSUv5ri7P+Be9oPZSw6mosV4Fr0gQ/i1uYN4BCwCqS/QpAjpZ7tcGaCIh q5m/74Cm0D3NP0mQ8+b4nGkGRtwfnnFHcFMze3C0fld9Bd4xvXN9N5XFlVtRepxaJm HhyDALuzNvd4D5U2yiwQdDowmhE/5C7prilDUzfWTztIsmMOJPmVSVzBxjJrjXtHAp Oa503ZR/pDSJeWpSXlke6TbJgzLVBQKyYGp8o+WVvDcKTOcg4dcQokEUqWuvaJU4iu Wdop+oY47FlYxEs2SSRl/a/1Mw+faeb6/Scuw2En4edRC6joZ3h5Ko4TQDcqZeQfOE aMGKKHy4CKIxQ== Received: from rostedt by gandalf with local (Exim 4.99.4) (envelope-from ) id 1wuwcI-000000046wl-2kcy; Fri, 14 Aug 2026 14:26:54 -0400 Message-ID: <20260814182654.512791362@kernel.org> User-Agent: quilt/0.69 Date: Fri, 14 Aug 2026 14:26:20 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Anubhav Shelat Subject: [for-next][PATCH 1/2] eventfs: Define event fields before directory creation References: <20260814182619.668645822@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 From: Anubhav Shelat Move the event_define_fields() call in event_create_dir() before the eventfs directory creation. Previously, a failure after directory creation wouldn't clean up eventfs_inode because the error path didn't call eventfs_remove_dir(). This eliminates the need to clean up the eventfs directories if event_define_fields() fails. Link: https://patch.msgid.link/20260715135231.338535-3-ashelat@redhat.com Signed-off-by: Anubhav Shelat Signed-off-by: Steven Rostedt --- kernel/trace/trace_events.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c index c01b10b99f67..ea608519f4b1 100644 --- a/kernel/trace/trace_events.c +++ b/kernel/trace/trace_events.c @@ -3192,6 +3192,13 @@ event_create_dir(struct eventfs_inode *parent, struct trace_event_file *file) if (WARN_ON_ONCE(strcmp(call->class->system, TRACE_SYSTEM) == 0)) return -ENODEV; + ret = event_define_fields(call); + if (ret < 0) { + pr_warn("Could not initialize trace point events/%s\n", + trace_event_name(call)); + return ret; + } + e_events = event_subsystem_dir(tr, call->class->system, file, parent); if (!e_events) return -ENOMEM; @@ -3210,12 +3217,6 @@ event_create_dir(struct eventfs_inode *parent, struct trace_event_file *file) file->ei = ei; - ret = event_define_fields(call); - if (ret < 0) { - pr_warn("Could not initialize trace point events/%s\n", name); - return ret; - } - /* Gets decremented on freeing of the "enable" file */ event_file_get(file); -- 2.53.0