From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF92A349CF3 for ; Fri, 14 Aug 2026 21:01:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.69 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786741270; cv=none; b=myhpdoiKsEfIZu7mibVPTKNScS/ZvLjcWN4Uym5hrLwjgkcbG4tZ6vPKeEN1jlmX/0PEtQY+n+T8l4fEkLRMEq4TGaDwgguwoiCXIk0YIUKbroJm6dNzDfw1ZT1PGzu5hj0vDpUA2BGyZ0sQA764jjwXOkHytVP8Zn0UZfGhTmQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786741270; c=relaxed/simple; bh=M9BEDwEaTA9Aidy34tdCH0UUxPsZswww+McR6MmL6kI=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=rhAygIYqQBP5ganJQmTswufsv7i+MQq1GAD2zXUko7TrMu2PyINvnLS7mu8W2Lk19QsDjUCWWGGPs1w0nL3z97HevCY5WPUdvUpD89X+/jq7/n5sWm8sB70hx0Ri7PX8p0Bq1U9+bl0vu63gCfH02lux1LkxP5tPzK5rzVOWLQw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--tarunsahu.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=hpKTNwm9; arc=none smtp.client-ip=209.85.218.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--tarunsahu.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="hpKTNwm9" Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-c1f548718d0so154724566b.0 for ; Fri, 14 Aug 2026 14:01:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786741262; x=1787346062; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7b9OMXuv3ZP+H19/AmnDH9qKEt9RkVpbpVuxQpQ0/a8=; b=hpKTNwm9dU/zJVgXsBLp0Z8k5gXDaiaVyWwJWiAEAJI6QV1nHB6wB5lwwPcqdgFAqB MKyc1lJTGP2p0DlWFhsfimIRgdl59ixVS62ewjl6mvG5/DFqHCkassxv+uClJUr9GqaL GpD5SPadYPIQp6Aj7yReNAgYpB59ab3gPeOsiavM5ZzKBQZdd+fQCkDoIezwpyuh1+Ag lId281gMQN+NG5xxkPMRmPct5FRyen/6N+gaJittqTjrv9TuOFM3pxChRV3/GT61tmfR GLu0RwaQMx6oIc8h6dg82JuWWA5qMEWpWjqUwEDyEdAyxxfyplryiHKB0PvLjg0OvaoS 1SAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786741262; x=1787346062; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7b9OMXuv3ZP+H19/AmnDH9qKEt9RkVpbpVuxQpQ0/a8=; b=g2qIjzVOeG5cwDzdkvgIShzvMdQPI7kT3E/1NSoVUrIFVRsVB7N9DMXkta3YmLiD6Q IZX+m5e3lb960eW0lVY4PRoTXJaansxm5ox/3KhLgUM5iNXcqF0x+B1E0+/kJ273tQ2T QZaJYTnIP2zmxZYC2q2VZWN6ov2LoFAiSvs8P8OVloo3RZndRmoJium8W3xIeUNSPSoZ DKkkdsP0kPlWL3c/qM1Beg/Qrr5ZfSgloFcn3AxAOD2fxWNlzCzLWlaZx9r2xHLz8Pmx f7hv2XPFK54JRBj9AY4fn5Fh9duUI9JLd1xCUc4j+hjoAR0IKfx9ewosbMUuzjjqLbPG 3VPQ== X-Forwarded-Encrypted: i=1; AHgh+Rq8lN96a7dXjHN4LVgCPs+DXQ3coPyT21rDuJdSBIFSFVVkwPJ8kCKt7kA9aA4j7CBxPfW89ROJxbl1Q9w=@vger.kernel.org X-Gm-Message-State: AOJu0YzqXw+ONMpj+CfmoCxQi8x5VLu12R1KFyfHjEr9dXJVEEOO4W4b sognGiUBU8wO4Xl8U+slAVVFyR7EUMoXEXiTIX96K1/k80vJ6YDil4kiPhFVISa/FUSR9pZ/mcN 2U0XgEfTlqnJ9xWQkIw== X-Received: from ejcfz27.prod.google.com ([2002:a17:907:959b:b0:c09:e2fc:4344]) (user=tarunsahu job=prod-delivery.src-stubby-dispatcher) by 2002:a17:907:a606:b0:c1c:2007:298e with SMTP id a640c23a62f3a-c212a208e62mr387287766b.24.1786741261643; Fri, 14 Aug 2026 14:01:01 -0700 (PDT) Date: Fri, 14 Aug 2026 21:00:56 +0000 In-Reply-To: <20260814210057.4102768-1-tarunsahu@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260814210057.4102768-1-tarunsahu@google.com> X-Mailer: git-send-email 2.55.0.691.gc56d675ccc-goog Message-ID: <20260814210057.4102768-3-tarunsahu@google.com> Subject: [PATCH v3 2/3] firmware/edd: use kobject_put() on edd_device_register() failure From: Tarun Sahu To: helgaas@kernel.org, dmatlack@google.com, Nicholas Piggin , Greg Kroah-Hartman , sourabhjain@linux.ibm.com, "Christophe Leroy (CS GROUP)" , Pasha Tatashin , Russell King , radheys@amd.com, skhawaja@google.com, djeffery@redhat.com, Geoff Levand , Madhavan Srinivasan , Michael Ellerman Cc: linux-arm-kernel@lists.infradead.org, souravsgl@google.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, driver-core@lists.linux.dev, Tarun Sahu Content-Type: text/plain; charset="UTF-8" As per koject_init_and_add() function kernel document, even if this function returns error kobject_put must be used instead of kfree. When edd_device_register() fails after initializing the kobject with kobject_init_and_add(), calling kfree(edev) directly bypasses the kobject release callback (edd_release) and leaks the allocated kobject resources. Fix this by replacing direct kfree(edev) with kobject_put(&edev->kobj) on registration failure. Signed-off-by: Tarun Sahu Reviewed-by: Sourabh Jain --- drivers/firmware/edd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/edd.c b/drivers/firmware/edd.c index f980c5b56858..763e7b16d517 100644 --- a/drivers/firmware/edd.c +++ b/drivers/firmware/edd.c @@ -748,7 +748,7 @@ edd_init(void) rc = edd_device_register(edev, i); if (rc) { - kfree(edev); + kobject_put(&edev->kobj); goto out; } edd_devices[i] = edev; -- 2.55.0.691.gc56d675ccc-goog