From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 099D73BBA0A for ; Fri, 14 Aug 2026 22:05:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786745116; cv=none; b=KM1WLqi21GaL7+Xs2mxAEPDSEtQkDT1VEF2dtc8IrrFBgJmS64crCixRz8h3LcZyj51A6jY62XLOg4A84SFd/rCw10EcnFIYZSh1qA1O252EQulfcO/XmtRgucieYmCyLd81X2PJPRZdNTAXfPT5iKN+dFq11rhMLCKlpxm/vMA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786745116; c=relaxed/simple; bh=O67pmowHWgU9F4aYcvvzY0blvwu6WfZnDRzj7fLaGd8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=tKbS0WodP9Juet1xW/XmmyuYCSrYc8XDjCClopjNgne0DlXYU0l7Pd5sCtZRA5zJhOH5bhpJzouDU2ZiYFXj342LVQtDq6/NS+Daweib1WfrfAGcOZyYs3fWHCIt3sbdwQANSlNlvJNuVJcqgn8vNfiYcqSi+xMFGgbZR4ax//Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dt/JkCXe; arc=none smtp.client-ip=209.85.219.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dt/JkCXe" Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-8f256eaedf8so13566706d6.2 for ; Fri, 14 Aug 2026 15:05:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786745114; x=1787349914; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=+byDgTzEgx4Gr3ZSkskCbtI+EfBHPCCCfhKahAfUKes=; b=dt/JkCXeb4jMZ7ptoYn6JAe7wFpCpPmbR7hf9Q4CpOr94tcSererFirBGqS2Yqf6Ku 4EBcGR3B5mJMaV69RX+Y6mS+zdjHah/HWlXnu/FXjMnqgs5HAVLVVnW2PZp8Z3/ClJG3 4aYdgewtBZqEITYQNIHeiG5GjA+VOXFNKRj/tnJdBFLD7bZe8Mnk6Rt3hsxPFPUDEu2h 3BSo7GMV8nhuADwYaFHWHSObKXofwXN2Tt+fzWfHKZN+ZBj4WWakedO5giXmxaRXo/vZ OV7fbRLK9IxvVPvQAJNpBncAEK1TXzMsj/aCVMz7a2iwUInbiJvE+2oIv6mrYH9CbQWV 4V1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786745114; x=1787349914; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+byDgTzEgx4Gr3ZSkskCbtI+EfBHPCCCfhKahAfUKes=; b=lx79/DVItujZQlcsKRX1x84+w6u3B2qYaEPlGy2k3xOBrsboV6S5VHQT53ttP8TdeY eamtvcVIABcrTPVYBOVA2BPMDLxHvcMReb6sEvIl4+ZVIknmhd6sTsQ+46x/9bXB06Yw V+zj92xb1aP3S8FHWYWkbClkSwTZNSjiWr2cnwu8VAC4Co1HTDfxsJRpPZsqSVUUcTz0 PVGOvjxG0oarU70LWro5YaHmGcUSQP4sAyj+X79j2xbXKWbkYcSZWLVkFC+T9xVnxRfy 0W0FPokpUdneEtGRuWPgzig6o+qm71f79Al7nPVcOZXTUqUfDQ2zH36f1HQ+dxCFj7ze WD/A== X-Forwarded-Encrypted: i=1; AHgh+RqJDMADm9+FeJJGvMLv0aPg1D4D34beuSm/hKYPbH3dfO0Mw70pyDUsFd2R3q+cmFa9aYMODf+ftMIbMWQ=@vger.kernel.org X-Gm-Message-State: AOJu0YykC+lVAICr0EiUYGsfTA4Qei7WlaqmbDvHQOFiP84c+FdghNKn HYciZvc1O7YazuqYZFNGPJWZAieLwliHIkrX/X1Of6QjcGIRwwqIvlea X-Gm-Gg: AR+sD13XR6od4jQ7q8pUSj32Ddru5BeRIDBKQLhjv70Rf+iPsKG4Keg7+CTuHidqKuY h+fto6sqJnJOrlth2OkWHJ2ut63iNF7ipZPYeGVmmTW3OdFqUc3eijhflPp8qSCL1NbZRc/b2a7 By7ZOUxMgNRbAVQ1+XvSYyVctykiO3/lazvyXBITN4s98qpF/Y4gvQZ5i1JaFzItj0Vycag5EnQ 6dxysZtPjN7ReKV5QRmeMxIcVou4qW58Zim3WWHSNZgNpvcrk8r6qxXEj3rIkXmqdI0wUeAve3M XkFuO+e0Mzhoh8ovH1opXBvWXsbbn2aa2JPr7EskktQmWeLavV0w8OxSlhm3mN0D7s8C73ksNrq 6suN91XUobwTPToA6aGPKgBco11cxl1LB/UsnoONLcsUPB+763bbd2n96ecCTSjZ0xuhHRD78/P pcvMu9Jrjnu7jTObcyMHyShZAeH/kOl2T8oYyWaoWAZGHq5LsPlJhrVWLLQ9IFBAJJ3S6GIXp9a 2DPtGLtKj+dj0P5Xw== X-Received: by 2002:a05:6214:428a:b0:908:951f:415 with SMTP id 6a1803df08f44-90a91d350efmr118520916d6.13.1786745113943; Fri, 14 Aug 2026 15:05:13 -0700 (PDT) Received: from i4-l-hqh5357-03.ad.psu.edu ([130.203.139.71]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-90a9350678esm26867806d6.26.2026.08.14.15.05.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Aug 2026 15:05:13 -0700 (PDT) From: Shuangpeng Bai To: axboe@kernel.dk Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Shuangpeng Bai , stable@vger.kernel.org Subject: [PATCH] block: clear ia_ranges on sysfs registration failure Date: Fri, 14 Aug 2026 18:04:48 -0400 Message-ID: <20260814220448.4085032-1-shuangpeng.kernel@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit disk_register_independent_access_ranges() clears disk->ia_ranges when creating the top-level kobject fails. However, if adding one of the range kobjects fails, the cleanup drops the final reference to iars and frees it while disk->ia_ranges still points at it. A concurrent disk revalidation can wait for q->sysfs_lock and then call disk_unregister_independent_access_ranges(), which dereferences the stale pointer after registration releases the mutex. Clear disk->ia_ranges before dropping the kobject references on the child registration error path, matching the top-level error handling. Fixes: a2247f19ee1c ("block: Add independent access ranges support") Cc: stable@vger.kernel.org Signed-off-by: Shuangpeng Bai --- block/blk-ia-ranges.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/blk-ia-ranges.c b/block/blk-ia-ranges.c index 7be8b58893c9..2430e475a8e7 100644 --- a/block/blk-ia-ranges.c +++ b/block/blk-ia-ranges.c @@ -135,6 +135,7 @@ int disk_register_independent_access_ranges(struct gendisk *disk) &blk_ia_range_ktype, &iars->kobj, "%d", i); if (ret) { + disk->ia_ranges = NULL; while (--i >= 0) kobject_del(&iars->ia_range[i].kobj); kobject_del(&iars->kobj); -- 2.43.0