From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1D772264A3 for ; Sat, 15 Aug 2026 17:31:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786815066; cv=none; b=VtSbSzv/ofjZ7NAPkE0XJld20C11g6UsWL04LhUelMxD401lFmDX9M7Gltmcqc005P2kb4YLGhTqxbPTQyvdRO/QUybaaYDWSiGnyMwXKLeV4aAepQFipw8otdVxQNWX1V5zuo61cn6wXRDklGY4f5ROKW4EO4I6D+PnkNeddM4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786815066; c=relaxed/simple; bh=MVZDrr9AdB0Vo7KRedm1n4U4GInx5SVFnRzNS1+N+Zo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jm/I1hMb301i8oSUKBy1OB1vDrC0uVJmy6eR0dZ4j/mq968u47wrTc2xxLwRo4jiDymOl2szM8vGXRp/HQLhC4hfLx+aq4KQzu+GxhWiNBMSdEdItsHBj0AtcZlkQ8G3e8DeY7ZrZItAdvc8IUfTXCKTToPQvcbWrvqyu81B9SI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=o94U2NyR; arc=none smtp.client-ip=209.85.210.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="o94U2NyR" Received: by mail-ot1-f53.google.com with SMTP id 46e09a7af769-7eb34c17b96so1585475a34.2 for ; Sat, 15 Aug 2026 10:31:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786815063; x=1787419863; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9eBdlB/mya9lLTAlc5ou5OAcHoUR69Q2TaK5PmrsA1I=; b=o94U2NyRDzKPIpoHbnGbepgZbZBjGZ/q9mYgWHLbQJPaNHyVliLvwiub8GjkzFi8ZE OFIAflOdJf7BhlMYPXJJNesSzDU4yIcC1wnme9gojFmseDOBHgoNbm0JlN4qLMyI0fIA 1us9AsA3pGNY0NdtmcwgmtsWbM69cy7vEiws018CBquQf8MPHZpd2V70liM3YI/QpkWb nPzEeeKFrEXBomEeDb6m9lsBY4KWtJng+7NMYqn/aQDmbxVG59Mg8Vrx8c48/rbFLnlT jshcKrafyVFaqFji32uHqPUrO+8XaMR1Ex0t30mI1Phqjz7F1eUvinByIeI03XquVHyf G8wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786815063; x=1787419863; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=9eBdlB/mya9lLTAlc5ou5OAcHoUR69Q2TaK5PmrsA1I=; b=SPUxCxHassuzAfIOdctnP/37VPXkg+YoI1Tw1UN0WQtPzHRwHSA9Zc7xSzvzWTDka0 AnAPGBH9MH/sfaoJ2pvcLCfrj7eIL0x0oP3dHxuCwS3ZvJyPAMkoZIIccgIBbQ7qbTKO b9aKsdTn1SUQv7N8OPhCUCwenc7Lho2qsWHRps/d+N3xaXpGHY+V13JtajX0KavOmQAB ImTvp+VNidyxC/QsAfOSFEUXeBH5+1bFEu/i9rZQkqJUK5ssiyPLdaoaJrFMfYG4VFXx +MTfop8Do7mXlE/uE2YmfsYpK9BZPF4xf4CbbWL5lQ+Ts5RI36u8nEwPMrF357inG1i+ 5PmA== X-Forwarded-Encrypted: i=1; AHgh+RpW9wNKVv4oywIFUXfhJKKWpea16Pd6IcgSFEjMBYQn7DfbDN9xkN+ejGCpBlYwVOGuI51xU33soB0Yj4Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yxf9x282paGxAcaIgcgrehP3KxTLNj6ISA0DmpoqrSM3UQtmo5K bfR0gwJYrKFuBC4EsAz7koVBrlIRejhfVewUk5KqLsgxJ4X5Hf1sURRMBUQWnrfy X-Gm-Gg: AR+sD13S85ruMwexjGNwDTct7JTd/Co8ttXbU/JnPGXBJ3aaFXdg2MMNwP8T1vdZ6ma ziFawvC9SW01I69W/6gOiHmVOS+Dywz2/z/rOvM8v8u5eRX5nlFf9ZJC2U9kZ5We3FuY1eYspM+ izsvT2bqRpYPrGnRtI8t4iftdfJTUXlXWm71z3zz3iKSORr1sCJcuY2UkugyGeou6REoAKMeRFK O1qe37RPPNkRcm7hqjFhdmH6HsTaBT6E9aWoGlCYFD+syUCK59NTPDHYpkkWeia6RvuQXRTrcYw yBjmb6nytu/Ye7WWEBeY+xctCLnj9gR2bzbXaVOF6CxgQJaoHVvBHfe1+T2wVS8Qtonx4VImp0H vPVhjmebIeDMCvHgLB6/OoVNn8g9YmSOJrqtdEpoNnk66NyibnaOLoZo0e4dOEDxprXBkpFve4q 0xVd+6iuU4p5qccE5e2aqQLGgzEHLsgq7WbCZFLuHj7nJiDCp1h2/qkcX7LSAWhl+ZBJH9o8RWs iC02JLdzgqul/HOn5gc/U3CCStexsXVz4vfQUMaUmnOuZtVA6HXfo+I6BARTHG+5xJjmw2Age57 dExh3nM96scUJCzJmbc= X-Received: by 2002:a05:6820:198c:b0:6ac:a45e:ff84 with SMTP id 006d021491bc7-6b0d6178f68mr12492143eaf.13.1786815063400; Sat, 15 Aug 2026 10:31:03 -0700 (PDT) Received: from [192.168.0.245] (c-98-38-17-99.hsd1.co.comcast.net. [98.38.17.99]) by smtp.googlemail.com with ESMTPSA id 46e09a7af769-7f3e86686c4sm4029328a34.23.2026.08.15.10.31.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Aug 2026 10:31:02 -0700 (PDT) From: Jim Cromie Date: Sat, 15 Aug 2026 11:30:52 -0600 Subject: [PATCH 1/2] drm/nouveau: Fix NULL pointer dereferences in GETPARAM ioctl Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260815-null-fixes-v1-1-0df9dda951fb@gmail.com> References: <20260815-null-fixes-v1-0-0df9dda951fb@gmail.com> In-Reply-To: <20260815-null-fixes-v1-0-0df9dda951fb@gmail.com> To: Lyude Paul , Danilo Krummrich , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jim Cromie X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1786815060; l=2757; i=jim.cromie@gmail.com; s=20260203; h=from:subject:message-id; bh=MVZDrr9AdB0Vo7KRedm1n4U4GInx5SVFnRzNS1+N+Zo=; b=7UtxmLGZFzvMkY6BMZrEvXFUjeGPkc4RBlhqbpixxTBpEjYL4ZS4ob1Nv7UkTpsJorw7B6qKD 7bNy0uHZI5LBKqx/0worjGBZzN0LRsOe6yk1r3TwhKZosmYiYY6NdZF X-Developer-Key: i=jim.cromie@gmail.com; a=ed25519; pk=C6E5ODlPQo7ZBynATXH9wg7K6HxP0pIXyf4s38Qw0XE= When hardware or firmware initialization fails, the graphics engine (gr) or device functions may remain NULL. Attempting to access these during the GETPARAM ioctl (e.g., NOUVEAU_GETPARAM_GRAPH_UNITS) results in a kernel NULL pointer dereference, causing a crash when userspace (GNOME/Mesa) attempts to probe the device. Add safety checks for 'gr', 'gr->func', and 'nvkm_device->func' in the ioctl handler. Return -ENODEV to signal the missing hardware state to userspace, and use NV_ERROR_ONCE to provide diagnostic proof in the kernel log without risking a console flood. RFC: These crashes may not be repeatable, they happened while I was trying to build nouveau as a builtin module, with binary blobs in the kernel image, on a laptop with an encrypted disk. Gemini tells me this won't work, so I punted. Signed-off-by: Jim Cromie --- drivers/gpu/drm/nouveau/nouveau_abi16.c | 25 +++++++++++++++++++++---- 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_abi16.c b/drivers/gpu/drm/nouveau/nouveau_abi16.c index 291203121f0c..c9270c5b0fac 100644 --- a/drivers/gpu/drm/nouveau/nouveau_abi16.c +++ b/drivers/gpu/drm/nouveau/nouveau_abi16.c @@ -306,7 +306,12 @@ nouveau_abi16_ioctl_getparam(ABI16_IOCTL_ARGS) getparam->value = 1; break; case NOUVEAU_GETPARAM_GRAPH_UNITS: - getparam->value = nvkm_gr_units(gr); + if (gr && gr->func) { + getparam->value = nvkm_gr_units(gr); + } else { + NV_ERROR_ONCE(drm, "GETPARAM_GRAPH_UNITS: no gr engine or func\n"); + return -ENODEV; + } break; case NOUVEAU_GETPARAM_EXEC_PUSH_MAX: { int ib_max = getparam_dma_ib_max(device); @@ -315,11 +320,23 @@ nouveau_abi16_ioctl_getparam(ABI16_IOCTL_ARGS) break; } case NOUVEAU_GETPARAM_VRAM_BAR_SIZE: - getparam->value = nvkm_device->func->resource_size(nvkm_device, NVKM_BAR1_FB); + if (nvkm_device && nvkm_device->func && nvkm_device->func->resource_size) { + getparam->value = + nvkm_device->func->resource_size(nvkm_device, NVKM_BAR1_FB); + } else { + NV_ERROR_ONCE(drm, "GETPARAM_VRAM_BAR_SIZE: no device func\n"); + return -ENODEV; + } break; case NOUVEAU_GETPARAM_VRAM_USED: { - struct ttm_resource_manager *vram_mgr = ttm_manager_type(&drm->ttm.bdev, TTM_PL_VRAM); - getparam->value = (u64)ttm_resource_manager_usage(vram_mgr); + struct ttm_resource_manager *vram_mgr = + ttm_manager_type(&drm->ttm.bdev, TTM_PL_VRAM); + if (vram_mgr) { + getparam->value = (u64)ttm_resource_manager_usage(vram_mgr); + } else { + NV_ERROR_ONCE(drm, "GETPARAM_VRAM_USED: no vram mgr\n"); + return -ENODEV; + } break; } case NOUVEAU_GETPARAM_HAS_VMA_TILEMODE: -- 2.55.0