From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A38C427FB3 for ; Sat, 15 Aug 2026 17:31:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786815067; cv=none; b=eCZ55sp7jHRwtRCGvCTJVeQbTBzN/pnH1XjQ9GhZYWSgg9bvMCyeKrkEkH3QGl+6Yr8CeuC1pE0g67ujkgd7A3tFPdoRDHGKZqCV356l5zRolOJBlwNeaFTO/TgyGaD3TBR3kYJvEeUDYj1xC4fVttlnQ/ImsWvxmpzbutgI6Os= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786815067; c=relaxed/simple; bh=AYZ9MDfYP+/3hzlU1wrveigPwRkF/U6OUgZWgjhl2yY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uCYRpikQ8LQ8e9cKnArHCDd4f8rHtzCiaor0q3nslp3rORPQ2cxIYZcNp0pYSyhWyd8CEUEYg8erVHP29YJxD6Y8YdFveUsKe7Ym6VOeLu9mN0FEd+rgdfKaveRbyRX87WxFYMeAFQfe6frlBrT2jEdgzjj/zny7rXrOoX7qRKk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KU58UzzS; arc=none smtp.client-ip=209.85.210.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KU58UzzS" Received: by mail-ot1-f50.google.com with SMTP id 46e09a7af769-7f3f52143cdso524857a34.2 for ; Sat, 15 Aug 2026 10:31:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786815064; x=1787419864; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=caUxSmF4mOwDWDjpizi0YmdYhbjdvZBNYyy5yHj52EM=; b=KU58UzzSTkOaygm0JcV9WfVayvu0OLM1SgI8Z1xOdza9nmZEDabWc9K1RDPCd8tgJj iwOxo8Bf96J34U9d1Kpnbumcg6n9BsC49eBmz1VGnaAKNaJ/UNtFiqbQP7J1i/yhkpSK 5xsinwstv5YFpAm04GWFjvWvVFRor6dfMHOMSuh+tRICt/5ZRIP8UFlb1m6WUHr/kz5K eoTtcQTgLO3ONezbkC86HtWTJNO2RUbkPMv3JQTS9bc15XbU/eVc/cp9UML+rF6CVZFj hQf8H3b2RZiKuOb9+Rys5rLO5YU0VJYz9L5tQW4mFaUsVX1wSmRkiZVS8X4cjgmW686O 3U4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786815064; x=1787419864; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=caUxSmF4mOwDWDjpizi0YmdYhbjdvZBNYyy5yHj52EM=; b=Nq0bLmhFyXais1YEd14THWDKHUtPrY8jlROwKL5FfHELbRX4JIuUkJkEy5sG4VFFn8 /aA3E6RMFN0YnullyCqNbn6WjXcBuW6f8kAz0dkLS/Y8vZKycoPZuyVbtkhMsl5yPSPX JgPqc03oU24iLDOtVFhbFP52sh0yN7vLB7jSBYos90IHj2zxVWzgkyq+rtroeFaWjdmT gchO2QZGX4chndgqAWdHOtxocTa9QBQnM2I+3iee2hx2M7rB1JUCLJJ+JqGHaVkmHgr+ LUxJSX65yk1Rxwcot0NtQhDf6w8U9t7LMISAzZDoJyHjqMYwfcK6j1KEj5eAUp+MFNR3 Du7Q== X-Forwarded-Encrypted: i=1; AHgh+RqKCQtEUdLzILp98ga7hJlBvuHek/ACvtvG51T2UNxIJYwIG5aAwHparlXA3grqt+ynfz3w66TKz+Q7YBE=@vger.kernel.org X-Gm-Message-State: AOJu0Yza+7SyFEydCKK9lT42scacN9b1+mKe2sxOxW/OSwbkTBTksk98 sreCbZm4CEDV7xsmHPc+wi0A5U4gAzcLgW3KAM/Ufux+b3OS/j7xB3gMwiWzmkPa X-Gm-Gg: AR+sD13bSKPJZzUx8KympfBhvgTuipXqxOWBlhV+EkgSyfr2GAzB+f4NMFZtBn03VL+ aW2dYocPn8aS1aETJjoes2tlyty+Z0sbBkVpEkWwbjC6j/zyF8IyV5cbELUiZhfqUFqZgr/pD1R dHvvsGMm2oR7RoKeAtbvYYiJRb/5gX/PrQ+gSlAlMGIEA+944PRhGwjYuhqXED8scCpFusZxvrk xRr1K845HTHdZJ5kPrY3slwIxzeAqel6KSd6p4yW+oRy0QtdqsrPlq56PBJCE0nnJrBAgbVOcaI pgKppAuWEmnH3bqmnemXUs0fOlrf/YxAgiCMcAUVtBEMhtBnpQWsoIktUnsdzIC6mQXDRxYUNKZ EUgQLx70ZeLvm68ZEepu+OJGjKrDFEOZZ1ACWj5lLPaNiwJs9dbSPsBttUvhAg4bDHc4l+c48MV choTMYtFvfLRAcg9yUIb1Ssesbq1kPvNevpzibQkgeiSeaODo+SeFu9aZLQ0tl04Kt7b5fwdOZl SMMO15cwJ+ptQwNEOvNfULxs3RQpzknG57xXxaSU2kpKxmFSiq31Atl6qv96vseskjyo41eJPVg QNkFuatyANu0nIjR0Nw= X-Received: by 2002:a05:6830:4488:b0:7e9:e709:44f6 with SMTP id 46e09a7af769-7f3de679c0dmr12685842a34.12.1786815064517; Sat, 15 Aug 2026 10:31:04 -0700 (PDT) Received: from [192.168.0.245] (c-98-38-17-99.hsd1.co.comcast.net. [98.38.17.99]) by smtp.googlemail.com with ESMTPSA id 46e09a7af769-7f3e86686c4sm4029328a34.23.2026.08.15.10.31.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Aug 2026 10:31:04 -0700 (PDT) From: Jim Cromie Date: Sat, 15 Aug 2026 11:30:53 -0600 Subject: [PATCH 2/2] drm/nouveau: Fix NULL pointer dereference in GET_ZCULL_INFO ioctl Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260815-null-fixes-v1-2-0df9dda951fb@gmail.com> References: <20260815-null-fixes-v1-0-0df9dda951fb@gmail.com> In-Reply-To: <20260815-null-fixes-v1-0-0df9dda951fb@gmail.com> To: Lyude Paul , Danilo Krummrich , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jim Cromie X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1786815060; l=2253; i=jim.cromie@gmail.com; s=20260203; h=from:subject:message-id; bh=AYZ9MDfYP+/3hzlU1wrveigPwRkF/U6OUgZWgjhl2yY=; b=kzw5BbvnfnMPlkNH1/kbY9HreJCu8O+yyr+c0l0w1aWyb5VnBnAVDh3CzuzCH/TM8DT1w3wLy 7MHLUYfUez3CfHaoo5Zh8B8H8aU8XTsCV6QG5iNm++64EqxGhbst2cF X-Developer-Key: i=jim.cromie@gmail.com; a=ed25519; pk=C6E5ODlPQo7ZBynATXH9wg7K6HxP0pIXyf4s38Qw0XE= When graphics engine firmware fails to load or initialization aborts early, nvxx_gr(drm) returns NULL. Calling DRM_IOCTL_NOUVEAU_GET_ZCULL_INFO causes nouveau_abi16_ioctl_get_zcull_info() to dereference gr at offset 0xf0 without checking for NULL, triggering a kernel page fault. Validate that gr is non-NULL before inspecting gr->has_zcull_info. Signed-off-by: Jim Cromie --- Aug 14 09:21:52 frodo kernel: BUG: kernel NULL pointer dereference, address: 00000000000000f0 Aug 14 09:21:52 frodo kernel: #PF: error_code(0x0000) - not-present page Aug 14 09:21:52 frodo kernel: Oops: Oops: 0000 [#1] SMP NOPTI Aug 14 09:21:52 frodo kernel: RIP: 0010:nouveau_abi16_ioctl_get_zcull_info+0x17/0xa0 [nouveau] Aug 14 09:21:52 frodo kernel: Code: 00 00 00 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 f3 0f 1e fa 0f 1f 44 00 00 48 8b 47 40 48 8b 00 48 8b 80 70 02 00 00 <80> b8 f0 00 00 00 00 74 72 8b 90 c0 00 00 00 89 16 8b 90 c4 00 00 Aug 14 09:21:52 frodo kernel: Call Trace: Aug 14 09:21:52 frodo kernel: Aug 14 09:21:52 frodo kernel: drm_ioctl_kernel+0xae/0x100 Aug 14 09:21:52 frodo kernel: drm_ioctl+0x2e0/0x560 Aug 14 09:21:52 frodo kernel: ? __pfx_nouveau_abi16_ioctl_get_zcull_info+0x10/0x10 [nouveau] Aug 14 09:21:52 frodo kernel: nouveau_drm_ioctl+0x58/0xc0 [nouveau] Aug 14 09:21:52 frodo kernel: __x64_sys_ioctl+0xb9/0x100 Aug 14 09:21:52 frodo kernel: do_syscall_64+0xe2/0x560 Aug 14 09:21:52 frodo kernel: entry_SYSCALL_64_after_hwframe+0x76/0x7e Aug 14 09:21:52 frodo kernel: --- drivers/gpu/drm/nouveau/nouveau_abi16.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_abi16.c b/drivers/gpu/drm/nouveau/nouveau_abi16.c index c9270c5b0fac..f1026a716ff7 100644 --- a/drivers/gpu/drm/nouveau/nouveau_abi16.c +++ b/drivers/gpu/drm/nouveau/nouveau_abi16.c @@ -357,7 +357,7 @@ nouveau_abi16_ioctl_get_zcull_info(ABI16_IOCTL_ARGS) struct nvkm_gr *gr = nvxx_gr(drm); struct drm_nouveau_get_zcull_info *out = data; - if (gr->has_zcull_info) { + if (gr && gr->has_zcull_info) { const struct nvkm_gr_zcull_info *i = &gr->zcull_info; out->width_align_pixels = i->width_align_pixels; -- 2.55.0