From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CD463A873D for ; Sat, 15 Aug 2026 06:45:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786776325; cv=none; b=E7FMwNNVUMAEgyUw8MLD9BuRZj2wAJGa3uZsBBFaVsg3hvs0OnPkbuPc5q6JUogr49hVkt/ABh1fZXTNueC1y23rgcoBsG8be7x/xAWJf/eCtRaHka4Vundq1/jtpy965WDm1zs6nQHkAwQVRGYZhoPnycE84B4v3qRG4fc1nHo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786776325; c=relaxed/simple; bh=JkfU/qU3fOegS+X13WMrunVgNhji7i+aUn3ZP2pKttY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FphfVd88C6CQhtd2NbLF6cYbadJuSoNHQBQJpWsxWXEx9vOy3y9pIOHn3EHsQzVO7pJvJUrq7BpEBhVg3Wc1uXDLrxSMlDfhYMBk6GzHnIzffWJxCefCCCPME5OHQdMaW02bT3u3nH8PxksettomYtQPRQdOSG7A9b3+hvjWJqI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QeDGiFIY; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QeDGiFIY" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-38101f85591so2658474a91.1 for ; Fri, 14 Aug 2026 23:45:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786776313; x=1787381113; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=JkfU/qU3fOegS+X13WMrunVgNhji7i+aUn3ZP2pKttY=; b=QeDGiFIYmPfbvJlp/WNO1dp88FVd2+T5RZXJUraoBeITNcEYQX1x/hqF4JzV8trANw fgp9ffpEgiyHlWxv274Dx/ZOee8Do26iD5tcRomVe/94GOW+V/IAWj8rp5mltITrnbun kHhj1QMUcdLfKhmwVzAETwiQrfEernr2uNzWiy+40fxOEr7t44gXmCMjR9CeMwoB1MbV svf5u3UuItBrcPlz06xwFGBxUCKV+v7HQvifO6uMNba4HzIN1uwlun/tK5CtfQAdWQkz TxbsjRaDhhufzjX4mnsA4Vic+9v4ftoBYndorHD7lKrTnuvonH7oxj8OpaKnqDURMLJR RUIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786776313; x=1787381113; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=JkfU/qU3fOegS+X13WMrunVgNhji7i+aUn3ZP2pKttY=; b=kzk5SZc1yna2z1QZZWkOjZEWhPwvCxl6cnRNV0W7QmqAsn14bhWC+eWx51QIe7uD/P MtBRXeyMlhzqHcmhlJHIdlw14XpjPIf7qTUw8P9Y6oHVeUxVQfE37hzo8FMbMW2xCqMG AmxfZBH2TgtLaaH2GYL4rs1Gzvuo1FTHLHd6wZ7eaI5vcs2qonZR5ejZF8VcsH4YxIhE M+D8R7BxigQFbjAvKScqonnq2OkmCA2UQ6QRvQhjW9aBxUtBg4fcb8c4bdM+eT7H7F8I Yv9ZP0/mggCHhQjWnR/d3B9isnL+uRJ3De6qpfCDyvg3RtzROz/OPHTPY/vGcu32qfUl gH/w== X-Forwarded-Encrypted: i=1; AHgh+Rot9Mai6B3a9RDNjwI89xzwBBkNO9294OxUdsF4SX6VoA3bS9fKgi3by+RoIIzxIzFjKlzc+XLiRWv4eDA=@vger.kernel.org X-Gm-Message-State: AOJu0YyBNHg2/ufSx8DCDER4i4mMszW70sanmD9jb6ymh7RnjgkRZ+Yt CbIt02Y4EsSAMmv5I27v6nEE0wkyahCkTx4KcX+xIW8FbVlo1Kx5Wx0R X-Gm-Gg: AR+sD13Be56thTnCHwTn47RpLkZzVduGjm8YlTT1UAyMrbfLprMmjf+oIDQPi98AqpH UAOYk3JOFrhJCv00eZZin8nNll2Y7ECHUUBSaZHaYicWq+zUtlpGRrRT18R5Lfo+se4PjRqXnYI NlO+ekXoiUlib/Ax1ZTawVlKhCp9gsMR5bka+Q95KBmCVzJbRYwxUxyZ72eyPULMaO8wUQFlh1y XXhXie7CGQzNx3G0atNfkmNuE5ykcLSRmV6Rsih515nzIicTvb6XXPDTrPrTwkJ4LAakfG8F42+ JaSwb//B/qdovAlVdBd28J7O+xM2MsTUrXnj4njmU0qAJGmNcnhnekQmUVO3BEU1x2152ZckyCu wCsdsCEmkFnxZUkQq+7qLBoij4R3T7eOqrUUtSA1rNhsGayIce+y8OQlZrXZS94nMGU01SGc6Yw raDlcMJl86+xoj3kLTya/Qk7ZWHVszEco3llOyWQHZzOBMmDflzuC4DJFiF7dpBqWCHhvNUHTm7 M4= X-Received: by 2002:a17:90a:d407:b0:38e:4f42:d0d6 with SMTP id 98e67ed59e1d1-3933b09f4f3mr8871167a91.12.1786776313005; Fri, 14 Aug 2026 23:45:13 -0700 (PDT) Received: from localhost.localdomain ([203.175.14.199]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-394ebb888cbsm5254979a91.9.2026.08.14.23.45.10 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 14 Aug 2026 23:45:12 -0700 (PDT) From: Guanjie Chen To: wqu@suse.com Cc: clm@fb.com, dsterba@suse.com, fdmanana@suse.com, jk.chen1095@gmail.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] btrfs: free qgroup configuration when quota enable fails Date: Sat, 15 Aug 2026 14:44:59 +0800 Message-ID: <20260815064503.67385-1-jk.chen1095@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <7845cec2-adf1-408f-b7eb-019a5cd398f7@suse.com> References: <7845cec2-adf1-408f-b7eb-019a5cd398f7@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Qu, Thanks for the review. I agree the error path should be reversed, even though btrfs_free_qgroup_config() has defensive checks so it won't UAF. But this isn't a one-liner – maybe we can refactor the whole init/cleanup flow later and fix it properly. As for contributing: I know there's been lots of LLM noise lately, and I don't want to add to it. I've been studying btrfs for about 2~3 years now. For my next patch, would it help if I clearly explain the root cause, my reasoning, and the solution in the commit message or cover letter? I'd like to make review smoother. Thanks again for your time. Best, Guanjie