From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.migadu.com (out-119.mta1.migadu.com [95.215.58.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA39E1B3925 for ; Sat, 15 Aug 2026 09:01:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.119 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786784522; cv=none; b=Chz8IxC1bxxo95OkR210CEc7Jeok+2VWYLqlSSveYfY8E1JnFr7DMB+JWYxeC/27zEw7qIHsOIp3hsICojJHf+9uL+XBojFi/oKdk7okba4qGcvDAgvYEaJg8+yjLeXsN2UVP6HCp/9qi/hhexbg/z7YHTnA+wmq2pahuqRKDIA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786784522; c=relaxed/simple; bh=4h/PUBUV4AuDWrQ4qEuJPddJruaJRjGlnrLMgur4U1Q=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=DTITVC9S/PXuMBqrSJzSVHsuR/AtdpBQ8RT8bvZx5qu4e4DacVT0gWejHbAiffzEtqNWicqrgSWwvjQHKfep42yIktVhV7VJjcLwLuAmjRSzu1DcsePWVKrUPHiS3W8jLhstOqamxm4kkEgpD0bCU5GMcMx8ZIQq+Kd3Yoz5nvg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=hssI7nnh; arc=none smtp.client-ip=95.215.58.119 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="hssI7nnh" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=4h/PUBUV4AuDWrQ4qEuJPddJruaJRjGlnrLMgur4U1Q=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1786784516; v=1; x=1787389316; b=hssI7nnhsJ+sqi52RpDWF6/Lhssu8joFDWVVeOmZ+i13Wq/4cszcfkbmQER0nwr0xOAeQlVI eu2GkAHl5LeN5OC2fwjmqAXaZOepEYmITtarAIkY+tkJP1Gqo1ivWbFHqFNqtETuu1+lJ2+8hTW LNy8ZuEXxh/xUG5bs0TRSItk= X-Envelope-To: linux-kernel@vger.kernel.org Received: from fedora.fritz.box (62.216.208.217) by mta10.migadu.com with ESMTPS id 61ce3dde4468f97f; Sat, 15 Aug 2026 09:01:46 +0000 X-Migadu-Flow: FLOW_OUT From: Thorsten Blum To: "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Yury Norov , Arjan van de Ven , Jacob Pan Cc: Thorsten Blum , stable@vger.kernel.org, "Rafael J. Wysocki" , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] thermal: intel: powerclamp: Reject invalid window_size values Date: Sat, 15 Aug 2026 11:01:34 +0200 Message-ID: <20260815090136.88540-2-thorsten.blum@linux.dev> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1103; i=thorsten.blum@linux.dev; h=from:subject; bh=4h/PUBUV4AuDWrQ4qEuJPddJruaJRjGlnrLMgur4U1Q=; b=owGbwMvMwCUWt7pQ4caZUj3G02pJDFkNWh++z7G9Y7rwnUHUDTbBWPWd26u/qVooyIhJnzu/e Y1hcEx6RykLgxgXg6yYIsuDWT9m+JbWVG4yidgJM4eVCWQIAxenAEwkm5WRYfoSu5sCy5j0Fz/Z Mnm66hs+cf8zAscWWoU1ss2cfCXHcznDP5PdOtN8llRYNS5iL2uPevTjlslCiU8/n24WNPjF889 IkhMA X-Developer-Key: i=thorsten.blum@linux.dev; a=openpgp; fpr=1D60735E8AEF3BE473B69D84733678FD8DFEEAD4 Content-Transfer-Encoding: 8bit window_size_set() sets ret to -EINVAL if new_window_size is outside the valid range, but then falls through and still updates window_size to the clamped value. Return -EINVAL immediately and do not update window_size. Also drop the now-redundant clamp() call. Fixes: d6d71ee4a14a ("PM: Introduce Intel PowerClamp Driver") Cc: stable@vger.kernel.org Signed-off-by: Thorsten Blum --- drivers/thermal/intel/intel_powerclamp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/thermal/intel/intel_powerclamp.c b/drivers/thermal/intel/intel_powerclamp.c index bd7fd98dc310..8026651133d5 100644 --- a/drivers/thermal/intel/intel_powerclamp.c +++ b/drivers/thermal/intel/intel_powerclamp.c @@ -289,9 +289,10 @@ static int window_size_set(const char *arg, const struct kernel_param *kp) pr_err("Out of recommended window size %lu, between 2-10\n", new_window_size); ret = -EINVAL; + goto exit_win; } - window_size = clamp(new_window_size, 2ul, 10ul); + window_size = new_window_size; smp_mb(); exit_win: