From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE376376A01 for ; Sat, 15 Aug 2026 11:37:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786793835; cv=none; b=NG8JdrorkGIV8Ot2fuYbEX2zIx2aLoPMKPOI9dFcFnsBdY+xYQwM9jB2uDC4mxjkk9GloiwjzmBF89Mdq52OdYpza7UFCK+7DtCTuRiBa2orlBhdd99vlKaDY6E1/RkBIbdNHWGM4LeTxNI7LL/g2GHC+Qi6fvBxXf/M8zWPBU0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786793835; c=relaxed/simple; bh=XEgQqbiRXVxJ/FPzW15TI9nxEJBrjTusfFat44XoyWE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=gWkR3MYI2/fSfeGpzrIJ/qaBteoWtyYi9N/oeNye3x9gc8lrzgwb8gfFF+oSYs8nbAVDgIsn0+tuSqdgHEnFHsREPtNEi348wQ63RjR6HdV7eWVt3RZ5siMQcVp/ozWIst94hVsDPYwBYNNmgv9iKXyXXCrMszLhHvkptrSWCss= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=db5qj6aP; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="db5qj6aP" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-5b14d1f9315so1614277e87.2 for ; Sat, 15 Aug 2026 04:37:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786793832; x=1787398632; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=38svDrdDTH5LRcULGR4lU3k6r3z68I+cAJsCHwGxwYc=; b=db5qj6aPbqGKD2B0UQRnMKZ4gMa4BLXXMYTZDlEuR8J3rWrzv+tXCulEkpoa6LQeoq fKf8GFBbyAuYJH/nJtjvc2l/c10XbFjPmldYwYBmfLYwzWjgZbTfhJ/Lzeiz11kby+4/ 2sLommGsOwkHdKdy21ee4YqISHouR+8xdYj/yzKey2wg3r12OpfiBDwNk5w/AZk6yTz+ xaGkOVYNwncIbeFRJi4VmVtYLq0OAXjSQd8noqoHm3pgwB1SSVz0QLRP0jMhtF4/DLwW sHtWYyR/QU6+O5I8hbsxZ0YymtRodn7DVXLB0AhxHk/ojglmdHF3NVmcG1nOTB9bb5CN ErTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786793832; x=1787398632; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=38svDrdDTH5LRcULGR4lU3k6r3z68I+cAJsCHwGxwYc=; b=NPIiQNum+8MokjbnPLWZfsEGrDxZUj6HRBfGD00KSwtjBMJ3nVGnPxr68cvrtguQw2 7uvKz/3DoXxOLfim/apvgcxPFTms+zFjJfH+N/g6gIFxyRjbKj6FxQ+as+YP/tdO1Akl LUKaN37Jv++wXs/boXgii6z44ypCVRmcz4YnTafMWx5+Bi6OAvJVdAdTR61ddVwYpdWf 5pK4cE04idz9yDsUZ/zRLfS4b+s4RGASP+IxXrkcyA696HTb/AZfVU794KWqarTbbmrO 9QWvMlpAF5FNiVm+8fsN+OfzIO7BrUFlyoAxSo1rlpkYCLtfTXnte7vgv6to0WdzUapO h1Pg== X-Forwarded-Encrypted: i=1; AHgh+Rrw/yUeZK0IF8qX4HZwPR6a397NJZVlTzF85lIcW8rZnBZS6+TR3ARVUs9I+g//84Xq69j83sZrw1FZHn0=@vger.kernel.org X-Gm-Message-State: AOJu0YwhPqXtHlDeDgoJGEHNhmmQulctgJng6ExoM5Ck5y2QjoRY5Ob/ mQKSxmTSPVwUNiVMkW25xPudNPiev9kIJ9JhCP556GamMTTAnu3MyYdz X-Gm-Gg: AR+sD11ut4RQ3x4Lz85csR5VD+Awu2kr/ORHY9dcx6D+T9Eq2uXArZw/2LYRaKe3Vrd q+Jx2DofmRzrTPIqHPe9JVXRFUKa9wyGERkrfs1InAmrKldwIPPKRqlfQbcnzZUPXktyn/zq7sX 0u22SIOr7s5mSJOgo8I/wTybRLG+EwSpKfouEt94GOaJZ0Gtbq+eTWPUBhCaDKjyGMIQz9y8xdr 80yvoleB6sOcZdsRM3NJEC03ctKYJmai+ZIpRz53ht8FujiHHDbkctk6+wqW4z5JyxgdW63aMth LOaoVAPTpM1ueNvPiyXdZ6ZykorKib5392KESd4qmrl0cbgGbSbq0xT5u21vSOTWztui+IsJAKN OdegmMSqW4zDeGwDw9KJUAzWxSzhkEVmAC0O8b0ymPo8sOdV7q85aW1pIGqNr7PiUxPyelbm8WL EAHVUTNPHuuOu11A83fd8g+IViz2IVgxcuY16Bm8M7eECcu9FmzlhupPTDFSJgUI+4BoWfZ8Gnk 2Mi9k+fpoylWje/qgJd7r542qIzaI2chw== X-Received: by 2002:a05:6512:6683:20b0:5b4:5880:b50b with SMTP id 2adb3069b0e04-5b45910adf1mr1241869e87.4.1786793831594; Sat, 15 Aug 2026 04:37:11 -0700 (PDT) Received: from localhost (host-80-73-162-2.rev.as20985.net. [80.73.162.2]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b458c0a7fbsm1129279e87.71.2026.08.15.04.37.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Aug 2026 04:37:11 -0700 (PDT) From: Andrey Golovko To: Mark Brown Cc: Shenghao Ding , Kevin Lu , Baojun Xu , Sen Wang , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , "Holalu Yogendra, Niranjan" , Pierre-Louis Bossart , Charles Keepax , Vijendar Mukunda , Antoine Monnet , Robin Everaars , Ville Saarinen , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] ASoC: tas2783-sdw: do not cache read-only Controls Date: Sat, 15 Aug 2026 14:45:00 +0300 Message-ID: <20260815112500.4362-1-andrey.golovko@gmail.com> In-Reply-To: References: <20260814094000.22118-1-andrey.golovko@gmail.com> <20260814094000.22118-3-andrey.golovko@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Fri, Aug 14, 2026 at 04:13:42PM +0100, Mark Brown wrote: > Does this work for multibyte reads? The regmap has val_size set to 8 > but some of the read only registers are multibyte. For SoundWire > val_bits doesn't really matter so you should just be able to set that to > 32. It does not, thank you. Twenty of the Controls in the list are wider than one byte, and with val_bits = 8 the MBQ layer refuses each of them before anything reaches the bus, so the patch on its own would replace an answer from the cache with -EINVAL. The widening is a patch of its own because the calibration write relied on the old width, so I have sent both as v3 with it in front, against for-7.3: https://lore.kernel.org/linux-sound/20260815112000.4180-1-andrey.golovko@gmail.com/ The cover letter has the list of the multi-byte Controls and what the two patches were measured to do on the machine here. One thing I noticed while checking the sizes, unrelated to this series: FU21 0x10 and UDMPU23 0x06 are in the read-only list but appear nowhere in tas2783_sdca_mbq_size(), which returns 0 for them, so tas2783_readable_register() refuses them and they are unreachable through the regmap in either direction. Harmless as it stands, nothing touches them, but the size callback looks incomplete rather than deliberate. I can add them, or leave that to TI along with the rest of the reg_defaults questions I owe them a mail about. Andrey