From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C945A2DFF3F for ; Sat, 15 Aug 2026 12:19:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786796394; cv=none; b=TiNKDsyQdU9+CGV4/PQCDt/LHDgx0yCsQIUBtHgi2whO+pjOeabBCBGf2mL5Vq75FyUh0l5BMBIjPOIukSokaLvjQleUxbJ/KAxDL0KXTWNMIem3Jf7PSKruzZNk1rdz4gmR5EwbFHxg5yVSdGFFt2qsiTmzfVSD56f4pb6KorA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786796394; c=relaxed/simple; bh=7i+/3TcBf6avYUiAp4t6U4j/bmQDZJteti4icqAN1sY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=DH7JT1HYrm8dnTKF/MRUhc8n0ohUl5rUKvNuHTHrlIVUiz1qOfftG/kUTdv2E+lBwTXpcFGcw9dLrn+ALelnBLpDW7xUErhBOOg5rQz4eM+fnregEWsTyuzXtTQi6H7Lt31tceVU/KQOnz1omyoFoeb6tBT4Mo64ffHkGfvizPw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kWzhidFL; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kWzhidFL" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2cf452def93so23776825ad.1 for ; Sat, 15 Aug 2026 05:19:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786796392; x=1787401192; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=fYKiND/4yRTYGLH8sZB7cPGenJ7H4gCyioObMoQH0I0=; b=kWzhidFLmMgaDCGcDG1JUonkBoxggbfivZFkgumycA2MHtvsdUC+vx/T38QZMBDVrv Kww3tEBcA1tWA6hnpIw17E3BKUrx4RmmwXP5UorFHKhYIFkCuzXK3BZqK8tGGWnGjjTt /VRNaaPmYsBie9Sacvj6KVbIbCX6xy7KYAdF48q0S2bgf51CwD/R/iQcK6ahtnuMKL6n amUnh6Q0IDKXVJoTHPqLFbVcUn7+9Wy7ElE2V31fwapg9zX8CHbtOlpiGlCdjY7ENsO0 kEoHZDvNtrH8LTs/SKAGg9edwlwoQ2lbz1DE1n6EaoXmJcXv4kSVCeaW1IPcsjMdHJ/B zweQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786796392; x=1787401192; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fYKiND/4yRTYGLH8sZB7cPGenJ7H4gCyioObMoQH0I0=; b=MZiUGgNLPhpHW9fsA+P+iepxRu2Ghk+cLbN+mTiKlkxq0Rw8IDzy6nEmkYkLod+nVV +Hg6kGMewHP6jhybWWQLqziGF6nhuJ0wXqpw3Pc0BIfoxYnPUfKU0fwFtpeKhwyTtKTs ojDdKqUEvftBFUyUzCBYeuPqYMK7EV5+SG3l5ciLW2HpSVPo7CxpT74jTuTpGbUAyY3d ynRc7BY3lBM1NO02zFdl7kZHqgJpv6Y0JxfR+Uf8fYmFu+pQB2lPq8pIChnsqm3nZnFQ LNAPpYUsFXfxDdJEL4G0wWhO08MSNtCe9+xDVGZMb9SijsXYZb0b4E2JuospR66uNG3M +/gg== X-Forwarded-Encrypted: i=1; AHgh+RpxKOS/iZ62SKj7C4nDQmzqt+6CZtBC9VlWHeIFKJF2n595qKuq0EEERjes4tfmLydEeJ8g2fUtrVDZE/U=@vger.kernel.org X-Gm-Message-State: AOJu0YwCsMWWPu3HTisr3VEpKwmsVwB35ZH/paemCjFB+Ab22hfnzkLL 2Z1RP0QPwWHbftUfOt03EjELCbLayNKWfEHdT5CUMKf83ZqgHBsMLu/T X-Gm-Gg: AR+sD13VXJyhEb0nvSd34aWcQ/V5OsrWNcH54atlKAZIVtZ0jRIouBTAPnX7+NqZbGD vTiPpzC3ezN+QJmaXATqZJ/71rNK+FMz3hO7vcs7IDvlrKjW5VaWBt8MILkjudWC9Ib1GOQUmv/ rzm+adypVbJfZstvReiVMxv4OkvsQPSi/4kxFsv5oy3vbzvSA6l1RgsJjhucV5BwG8D6NO1lajW Jib7wigoSM37NhxRc8+mnCkDJhMqk2/YT/JJztpdBgRwVVyPxCwpiNUmi0hRK+4c6UBOHULiUGg SEx50LmZd76rhKq5H4ibOgnkvtzf7gQO0QM/w83izFCWMax5dxFb0dOnvlKHchp6nrJCsj+cth3 K8XVwzfwsbDnKiyeGYkVyM8kkndrqBRBRtgA4X9h7m4UJlxmQc43qhmXMUPNKSJv0foZGSZp0ce 5ei02eYmwAszL5WEkzQPSsJ71GtSzNMpk5yJXe9l6/cAIxjPJXjS4+qBUKW6/kmEzf/++kqOKhd dVQWNYIYozQbILF5ZTL1j2U6Q== X-Received: by 2002:a17:903:1a0d:b0:2d2:72b6:556b with SMTP id d9443c01a7336-2d37f7b7ca7mr220930955ad.13.1786796391866; Sat, 15 Aug 2026 05:19:51 -0700 (PDT) Received: from jets-psd.. ([2401:4900:c309:67d5:3081:64c9:1433:3be0]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-320c6be7f6fsm16961474eec.0.2026.08.15.05.19.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Aug 2026 05:19:51 -0700 (PDT) From: Preetam Sundar Das To: basavaraj.natikar@amd.com, jikos@kernel.org, bentiss@kernel.org Cc: sandeep.singh@amd.com, Nehal-bakulchandra.Shah@amd.com, skhan@linuxfoundation.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Preetam Sundar Das , syzbot+4eadd4dfe9e66522bae8@syzkaller.appspotmail.com Subject: [PATCH] HID: amd_sfh: Validate BAR 2 as memory-mapped I/O in probe Date: Sat, 15 Aug 2026 17:49:38 +0530 Message-ID: <20260815121938.1337631-1-daspreetam4@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Syzbot reported a page fault in amd_mp2_pci_probe(). The fuzzer creates a malicious PCI device where BAR 2 is defined as an I/O port rather than a memory-mapped I/O (MMIO) region. The driver previously assumed BAR 2 would always be MMIO and blindly passed the I/O port address to readl(), causing a fatal page fault when the CPU attempted to read from restricted memory. Fix this by explicitly checking the PCI resource flags after waking the device. If BAR 2 is not an IORESOURCE_MEM region, safely reject the device with -EINVAL to prevent the panic. Fixes: 4f567b9f8141 ("SFH: PCIe driver to add support of AMD sensor fusion hub") Reported-by: syzbot+4eadd4dfe9e66522bae8@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?id=227a9acbe565367eb7a1277b47115df8706d9a12 Signed-off-by: Preetam Sundar Das --- drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c index 4b81cebdc335..aef105a81570 100644 --- a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c +++ b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c @@ -451,6 +451,9 @@ static int amd_mp2_pci_probe(struct pci_dev *pdev, const struct pci_device_id *i if (rc) return rc; + if (!(pci_resource_flags(pdev, 2) & IORESOURCE_MEM)) + return -EINVAL; + rc = pcim_iomap_regions(pdev, BIT(2), DRIVER_NAME); if (rc) return rc; -- 2.43.0