From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FF0942378F for ; Sat, 15 Aug 2026 18:12:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786817576; cv=none; b=j1JSIEy97tQdTczBhOBdXEZxQOE9yPNhNwFK60Z9aSs+LZfMM5QraXipPH8aWq9XZeL25w6ohqScLP5VXi5W1Z8Vx6UkpVRAyFjqAUTaYRfKDmN9n3TmvcSlV8oFOkuuPieQP7qtqU4w8uhbYxA8q3yd3tEbf9ozppGEMp3Ia6k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786817576; c=relaxed/simple; bh=g/8fGhqkCV7RQstwEmzMAoWTNxRnB/a8B7+vfAI/r7I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Jv1viKQz6b+6dug/Lo6+ScjUvc3jZ5wkLtmb9eJpeDHhkX4HO2AUIWvRMMLf6HIeVc5d9MRQpFf9GohnXxYi2HaqaBHFK+0os+Ero/1pUcIyMPrrt39jfFYyy/HQpY5aUvlSC8i+uc2gpDk7NAiMhlaJX+jdzIHszdEFQMNH9ZU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QOlgOvj+; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QOlgOvj+" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2cc61541f8cso38948225ad.0 for ; Sat, 15 Aug 2026 11:12:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786817568; x=1787422368; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Uq/zXomRaUtmPVU0X/7Fe7/2pJ+viXdEE1hutqkzih4=; b=QOlgOvj+whoo5+ZxgIL1l86V/C6PeXlWEPKfaD/ynydtTue1vPvXIjwkmm3KYi5pg1 Kf74xnr4RE7DVn2kgCk1M4802tAMKT5PhikJdUv9iLSP2Waf5zF4NAhuest46wqmtsta ZbLaGIgYuqMzuoOtnrejqYNb7SBkBsNywvo3VdImF6o4vEltAnyzVbZgfjSA9NiN6+mw wZCu+Fe+UmWxGPeOzcvzfd4vt8ZrT/8lzrhyodezjMwfpDej1U5vVrZeKdcwUjU+Ygaz N1NQ5g296iyrWSCFEMb5qSzDnoKsve8Qzw9X7SKXSRaGOLvk1hmkGVOaiPdPpo/z0vpk 3g1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786817568; x=1787422368; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Uq/zXomRaUtmPVU0X/7Fe7/2pJ+viXdEE1hutqkzih4=; b=PNAIZeOfmS+9oEN3MaqYWRFE8QCKuducoUXtUJ3z1+CiPtBqqw3r88Vnh+LBPUHkIr Bvsc0NAClkvZte1GthezsHwrUs4OdXRY/4Muz4KyuMwm5g5Ft1yELI5cUIz2O+y3yCl4 cWCw1L8DlDqKV0t5wzJJiccVqeydpxp3b240nAtqhb4NK1t+2vdvdsNj+AHRa0z2AJAx IrPQ/S4LHmGlineo/evqa3CkN0U/T5pQFqTITp84szNDyCrU1gtlLFTPsNd8FlsmwTPW /JT8h4OYuW/NZUWw0lrogG408UetxfeGYYABO3W4cexTcH1OPgDbIB7HlMtBuGERYSLl n8Rw== X-Forwarded-Encrypted: i=1; AHgh+RqkWBUU2B+0TKhA9Zw68WS2pWWCJGs/dc5QgAl4GEGe3n+ZDB83spuDc13u9+HkiBhxxZu2le9oO740Hlk=@vger.kernel.org X-Gm-Message-State: AOJu0Yxdc4x/KfWbN745aHL4E1UL1q08Ve8R7356NKHPDvXwwy6lkrZP s1q76LsQxlqI6wO65+qEmYor5X7WvyxurUGQ2avX7COUx+UDkwwqKfcp X-Gm-Gg: AR+sD12SX8LcT9UwwtYV8bMs9O2TEw2CjV5YQkfo+z0tJM/lMb4NcdpEvVoNfm7Vu8Q a2b0cPwicQ6rraXr5rzjGmWjLbQdHgOaamXcFGCfhKOJNu370n70rpbCPEqexO0bKMxuJRDCqpC PK/L6t0LLBpf/Es8YOW+FDBK/BFLfetOKggynH/LgdUtp25gmg7UVBsbwH03CIXlVjioFcfHQ12 CH7+HijchXGtwMAvHbqDBNfbbNMZ7zJArl535dS/H895otirUoLLBMizTareDYPL/8xR9q4Gyfd gTpoSU2XxkRXjEbt3D1VqZC+ZmU9OQ6XzC6sLBNKW9QA1tlhrUeNrxI9i0geuyavNWPp/E6mSXs Oc+ccaqALyNe1NIbDVUzenWhHzSs2LWKxde/we6kQOoXA3rbp55aH0Hv20bpBkt1+sjmIkRLI+C wJDbiUaoj8w69vf7k84d29yI4XusavtlkafEkTbgIbngrFzIsZaxsyJvwrgpgUXubzLcPQyxQkQ kUsXS3yS7SzvZsohibNaFYNtPU= X-Received: by 2002:a17:90b:1b43:b0:38e:9ca8:e99 with SMTP id 98e67ed59e1d1-3933af8b5d7mr10385225a91.5.1786817568272; Sat, 15 Aug 2026 11:12:48 -0700 (PDT) Received: from localhost.localdomain ([240a:4280:4800:6ace:25e8:2607:e94d:caaf]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-394eb7539d3sm7304254a91.15.2026.08.15.11.12.39 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 15 Aug 2026 11:12:46 -0700 (PDT) From: Liu Zhenlong To: andi.shyti@kernel.org, chris.packham@alliedtelesis.co.nz, jochen@scram.de, maddy@linux.ibm.com, vz@mleia.com, piotr.wojtaszczyk@timesys.com Cc: mpe@ellerman.id.uk, npiggin@gmail.com, chleroy@kernel.org, grant.likely@secretlab.ca, neelegup@linux.vnet.ibm.com, benh@kernel.crashing.org, wsa@kernel.org, stigge@antcom.de, linux-i2c@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Liu Zhenlong , stable@vger.kernel.org Subject: [PATCH 1/5] i2c: mpc: fix device_node refcount leak in fsl_i2c_probe()/fsl_i2c_remove() Date: Sun, 16 Aug 2026 02:12:00 +0800 Message-ID: <20260815181204.2321-2-dragonliu2018@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260815181204.2321-1-dragonliu2018@gmail.com> References: <20260815181204.2321-1-dragonliu2018@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit fsl_i2c_probe() calls of_node_get() to take an extra reference on the platform device's of_node when assigning it to the adapter device, but neither the probe error path nor fsl_i2c_remove() drops it. device_release() does not call of_node_put() and i2c_adapter_dev_release() only completes a struct, so the extra reference is never released, leaking the device_node on every probe failure and every adapter removal. Add the matching of_node_put() to both paths. In the probe error path, i2c_add_numbered_adapter() failure does not run i2c_del_adapter(), so of_node_put(i2c->adap.dev.of_node) is safe. In fsl_i2c_remove(), i2c_del_adapter() clears adap->dev with memset() at the end (commit bd4bc3dbded9 ("i2c: Clear i2c_adapter.dev on adapter removal")), which zeroes adap->dev.of_node before of_node_put() runs, turning it into a no-op. Cache the pointer before calling i2c_del_adapter(), the same approach used in i2c-mux (i2c_mux_del_adapters) and mtd (commit 56570bdad5e3 ("mtd: core: Fix refcount error in del_mtd_device()")). Compile-tested with gcc-powerpc-linux-gnu on pmac32 defconfig; no hardware available for runtime testing. Fixes: 9fd049927ccb ("of/i2c: Generalize OF support") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-5 Signed-off-by: Liu Zhenlong --- drivers/i2c/busses/i2c-mpc.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c index a21fa45bd64c..8182f7dc3d0f 100644 --- a/drivers/i2c/busses/i2c-mpc.c +++ b/drivers/i2c/busses/i2c-mpc.c @@ -867,8 +867,10 @@ static int fsl_i2c_probe(struct platform_device *op) i2c_set_adapdata(&i2c->adap, i2c); result = i2c_add_numbered_adapter(&i2c->adap); - if (result) + if (result) { + of_node_put(i2c->adap.dev.of_node); return result; + } return 0; }; @@ -876,8 +878,10 @@ static int fsl_i2c_probe(struct platform_device *op) static void fsl_i2c_remove(struct platform_device *op) { struct mpc_i2c *i2c = platform_get_drvdata(op); + struct device_node *node = i2c->adap.dev.of_node; i2c_del_adapter(&i2c->adap); + of_node_put(node); }; static int __maybe_unused mpc_i2c_suspend(struct device *dev) -- 2.55.0