From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f53.google.com (mail-yx1-f53.google.com [74.125.224.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CC463C0628 for ; Sat, 15 Aug 2026 18:28:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786818513; cv=none; b=SLay/jiKElqhcBTTwHCQabxdRuxBLTxCSECulBmmDD0/PxOe+g4u6/vriH75zo4H9MWBsOm7VgSg0VjXnrv9l5LuAOwXOhdlKST8eIN8JYkmV5x9ROF8U5td6nS3L4AX1WN0QcUuAC0TMaWRHdg3xPsRF/YzZ1bhxPCKY/EJlng= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786818513; c=relaxed/simple; bh=AglfuJjYGVuU1/b1mszIc81oX/HIQ6PLpq8iRJ8r/CI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=InYffQzq5Gi11dpmfiwdh2mt7cQWJOV/GUzAiRaUCkVVxG7JVQQ5Nc1Ze3QsUECzl7FY7Hwhb0BJAh5NmxZfnzMhygXXE9Wpdgq0v9dIDfz5q3L6cGIEhhPtohT36M4uGhCGJhu8dbp2mBRcvAMwNTVTH1mCuQn32xbP5+viC0o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hcXiNt5w; arc=none smtp.client-ip=74.125.224.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hcXiNt5w" Received: by mail-yx1-f53.google.com with SMTP id 956f58d0204a3-66c70e2904dso2357442d50.1 for ; Sat, 15 Aug 2026 11:28:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786818511; x=1787423311; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LVhZeEwCh3t3Qz3apXzpM8jvwUwGQcQC73T/JHuxtFs=; b=hcXiNt5wQuSelF39f0m7tPBPQ0vXMla8hI+1tjCe2xffahGCnF6rtfPR62jr/HUbuC VcwJT176mXvz6jJmZsEfJKwzRs0jZQYP5wESykGIJ7HZk3CAESIH6hCMeTVBwwCL3/Jf JM09/LIcHRTC7YCjEfMrELqcy0azM627XuUpis9enMakJNAy39tx4ZRhwA74QCkPu6dB 0sGJyvUEzjdP2ogZtX/fAAG/UF3HnzN2UhUoqMeO4UXMqmQC6JttiNLB/xvp4iG+zeJ8 GwaJin/O0OW60vnyRbCf1LPTsY3PxfJIPjdYhHDQkfrrcZeNYkyoPK4bPj8nrnVUKM8u rnPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786818511; x=1787423311; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=LVhZeEwCh3t3Qz3apXzpM8jvwUwGQcQC73T/JHuxtFs=; b=DaS1m0A9ZNUUAswlYHcGNtghbqU8Ox+KFcSd3S2VliQ7GZNyRrEn9wJnBbnhhid89i UhbqJcWtCg3TkBq4bQVZMaPyZOMd8F2GoWvHVvQgTGrRPcjMAdT/4B03zZ3qzRXX+bkt XhRsLK1C0DY8Q/mvrDd2Ax7nWpyRQkSFXcm9QEuWcngRXMbbMT8YJZ4/A0p3a4djAj/S qKuaBFpICA2jMXiOsWcNQxQXnphVyoDTiMRHLPM3EJxPBWKoX2ieb/vJfie2fkqBSisr F33HOpFFXi27uYsOesBozpjrjCRy9eSQBlbc4MRqZH/ZcTT6Rgvc99fle2lnRrsddj2P KekA== X-Forwarded-Encrypted: i=1; AHgh+RqsQhPVtv8BRvUVVYqBzbIH8gLH/Je4Wpyhg3gev+eEYZQIUIah0hGOOF8qOMMLZ4XxGyU9Y7kJfYsaGJQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwLUQoEqNFGNLafXqYgTPjkNhbADhGUMUi7rmDvV8P9/KwArgBC jKrVedyo2doM8H2cAJ7AtuNxUtL5QegzmeeOqgRWBJ+gF8fxXM5iUVQ= X-Gm-Gg: AR+sD10uKoThyc7V6Sv8LoTxrQln7a6wHXKCX9UnWJB4Yq8+xMLJKa2uVfxbwyq4+Hx gt1sw8gkpuQ3tcm+MYxcSJ1zdZWK3n4yA2tcJWxJbnrJ7UQiiRb2eM4G32ZZ+q9mfqXUsFQNDoJ oci6n5+E/a8k27YipLLZHvQOq+y/4ZGc2LFOj3juOLohu0MZLnMnw8fjZmKkHTEFi28NYcKJ0RW F5M8fWMt8PWsvgqEenyDYOgKn6bbiD2kBrgKWJmR0Wa/dzxu7GFrdJpiwx57IZhkAkb1rsQrnO3 qSGwpXpWsnXpfZUrFhDtWD2pWI9BqP2XsW90eksmaD6VDTNsFmHGTAqO40Irpo5X1aonY8Db1bT PoEbJBiUEAJS5aMgbpWNq2gO7KDY3u9v7HkKUUmmmiUuPFeg+FLtluaramlkP7UroPQSiawuHH1 JzE93CGQmRnfJ2lqm7brGIVpz3kJTiWCjTWnV7cMdru0+Z1thm11DscDm9XpF1JS3scLOhJvJ/5 3oRkrKYmCxljz5Z3O4= X-Received: by 2002:a05:690e:1c09:b0:66b:2d5b:9fe1 with SMTP id 956f58d0204a3-66c72d04491mr6346023d50.45.1786818511332; Sat, 15 Aug 2026 11:28:31 -0700 (PDT) Received: from daffodil.tailc06997.ts.net ([163.152.162.75]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-66c75c5dd24sm2598154d50.6.2026.08.15.11.28.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Aug 2026 11:28:30 -0700 (PDT) From: Arka Mondal To: jic23@kernel.org, Michael.Hennerich@analog.com, nuno.sa@analog.com Cc: andy@kernel.org, andriy.shevchenko@intel.com, dlechner@baylibre.com, rohitsarkar5398@gmail.com, venkat.prashanth2498@gmail.com, linux@analog.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Arka Mondal Subject: [PATCH v2 3/3] iio: gyro: adis16136: fix unprotected debugfs reads Date: Sun, 16 Aug 2026 03:27:26 +0900 Message-ID: <20260815182726.11796-4-arkamondalofficial@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260815182726.11796-1-arkamondalofficial@gmail.com> References: <20260815182726.11796-1-arkamondalofficial@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The serial_number file operations are open coded and never call debugfs_file_get(), which debugfs_create_file_unsafe() requires. debugfs_remove_recursive() therefore does not wait for a read in progress, and unbind frees the iio_dev underneath it. Use debugfs_create_file() instead. Fixes: 9aaea09b4cbd ("gyro:adis16136: fix debugfs_simple_attr.cocci warnings") Signed-off-by: Arka Mondal Reviewed-by: Andy Shevchenko --- Notes: Compile tested only; no relevant hardware available. drivers/iio/gyro/adis16136.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/gyro/adis16136.c b/drivers/iio/gyro/adis16136.c index 369c7428e1ef..adcf54b67a28 100644 --- a/drivers/iio/gyro/adis16136.c +++ b/drivers/iio/gyro/adis16136.c @@ -145,7 +145,7 @@ static int adis16136_debugfs_init(struct iio_dev *indio_dev) struct adis16136 *adis16136 = iio_priv(indio_dev); struct dentry *d = iio_get_debugfs_dentry(indio_dev); - debugfs_create_file_unsafe("serial_number", 0400, + debugfs_create_file("serial_number", 0400, d, adis16136, &adis16136_serial_fops); debugfs_create_file_unsafe("product_id", 0400, d, adis16136, &adis16136_product_id_fops); -- 2.55.0