From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4DDF332907 for ; Sat, 15 Aug 2026 19:10:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786821055; cv=none; b=cpy9DjAvnuEZ4e5iIjQ+j+ecn1lFzHpODehxQ6S9SNFj8IYX0jmQJTpyHyg1n8OtpJ/D3rGxo1Y+/aruWlSlvD7MEIFrplabeTtX/yby7su1DKlXR2xBGddZDARCzDd+eRib40mhVEBVNLf2yBikyvv1KxPewA1mTWXci4qooNE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786821055; c=relaxed/simple; bh=QE32OR0oQXdgtMaLWm4cpyPJcvVdIS2aGpfxMpDhJ3Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=mGPTXSVBbVpdAD8f9YAin2g4X0rm2rbSi9mg/uPtaUAe/1O7f1Fu+VQ4Nbi8HO4XcuEwL16Y1dESCWAFbeZLLpV2nAaw4hp95OxZ57gnl8tJZYq5ORTjxRV7RUejLevCstSgPi0OM6IJbZz8UD0Ekxt5vRaSoG8bsMSxd/Dy67I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GxCPUxdM; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GxCPUxdM" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2caced6038eso23783475ad.0 for ; Sat, 15 Aug 2026 12:10:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786821053; x=1787425853; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=dHmrTvziEMKVC+8ZKVEtuspT+lYTSpcVmcl9KWItzjw=; b=GxCPUxdMTxwnBcaUgc/ekxG7B1b2dMVWPH7MjTonMW1eh/ncYDcF8jrIo2Z4CopvBg yXDTbajMnEjp3pWFvRUuokUQxn+DNuuUKECC7b9y1WR0CWlhHVjuOSiPBfe3wS3sOGlm HeoWuLx2XZ/VnRgA/xuMBt2DW0FE23LnIEVIf6BfhQMPTJUVeBJoF5tLZZRgpA4ltSQB BYtNAFMfGxMr7EKE2TTnOz+V5VSHq4W3nOGJ03Ve9Pynsx20dk7Flf1h0VOvjhS18IIt Ta3+4UvQj3e4UXS3sgu7wZF1eNndWXyUPGiiVnru5171yLUXHN2Enegh0jc8B0Q+n+5j aAvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786821053; x=1787425853; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dHmrTvziEMKVC+8ZKVEtuspT+lYTSpcVmcl9KWItzjw=; b=PWum9WdhCAPnyMkivO7+QqFcejnD5o0ePG+dG61Rz2Ks6AUb6A5PAlv3Yj4ieMoQC6 2Tb/ARoo8jmOpB9rkUmEP2HedIowFg7FfRFPV74QWuhFs2sk8x5fxQnvCtcdituXO6Ag yZyQ8AK5Rxdq/J2G0SVRObYZnWGgO/uXVsrTf9woRjvvwR95LoJEcrD+4eNqjXzd2Qad yHW9bnUR9Eyi3kMBVGxfypSDJejKm3WuF5ONthrfYFNAaKpMVc1Ymccx8vcoUI2Q2S2H 6pwvajKlAOnxSWFfj5JDXwr8ZnLn+hyTGGKIm20eoUbVYFNyPIkCGkjQzuzmUhIooEWO N9HA== X-Forwarded-Encrypted: i=1; AHgh+RrOwvp+D3nIVor5IG+ktF0E5T5KhZ7F+xuIDQNH1wh8SuXG6a/qZnxmyKJCfq/bZ6OmKK6BAB/F5apj3Qc=@vger.kernel.org X-Gm-Message-State: AOJu0YxJDoMiuCLT+HFjKswLgWKqtj6q8+lxSKO+VXyIvSy8GIHTg3hn kJ9Q6Ii4nFGOE4BbRep8+Mcld+BhVOj8P1oM0h2AkZZvthbdyuGi3c8n X-Gm-Gg: AR+sD11Oyqp+zHoALiNSNpgUIfc29f1u+Edrcq5uv3To0Mk+JBhySP3mHIJo4zZ+lID mTaZZhuuVmcoHYhh/pzdr+l8thoFU/4Y3R90aYAYw91m5riNBHL7Zrwo7M0GnX1u1yTKA6TnhoF LbW2tnkETn5PksSwjnzonciSlID0QC511LtnBkvyL/YzA71aHVpiMW4eNy+2hPl2u4TgmXh+H3t cLMeZwCTLJTUSWeWLzen9va6hZUnAFqG/GWfOmPF/EuZCxsCIzk8X6jPcxJopx8yamH8ueMSRR4 6pUYqKwt2UAB8kBbP01bUwBLizAVrZ7aMZ2c/Q4IrL2pQc7bb5SG/xVn9gGw6w3ZWqZL1jufLEt rk1W6jnuXOldX64z6IwHlOSYyHGAYyUwZWVMWAa8KbP/G8cYGmHq3JB6hkG7pikkvKqe5wEmNkO /6bdwVnJXSqiI3FoQLnhVQfAJOVezx6x0uUiE7hzhkBrX0llpk7n0eLA== X-Received: by 2002:a17:903:1aa3:b0:2cc:89ce:2f07 with SMTP id d9443c01a7336-2d3afdacd25mr133307965ad.1.1786821052989; Sat, 15 Aug 2026 12:10:52 -0700 (PDT) Received: from bloom.localdomain ([2604:3d09:178e:e100::6868]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d3aeb880a9sm20403305ad.64.2026.08.15.12.10.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Aug 2026 12:10:51 -0700 (PDT) From: Ivy Lopez To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ivy Lopez Subject: [PATCH] staging: rtl8723bs: cast EEPROM_DEFAULT_DIFF to s8 Date: Sat, 15 Aug 2026 13:10:30 -0600 Message-ID: <20260815191030.24989-1-skunkolee@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit EEPROM_DEFAULT_DIFF is defined as the bare integer literal 0xFE (254) but is only ever assigned into s8 (signed char) fields used to store signed TX power calibration offsets. The implicit truncation to -2 is intentional. BW20/BW40/CCK/OFDM_Diff fields elsewhere in the same file already sign-extend 4-bit values into 8-bit signed offsets by hand, so -2 is consistent with that existing pattern but the untyped macro doesn't communicate this, and triggers -Wconversion at every one of its 8 use sites in rtl8723b_hal_init.c. Cast the macro to s8 at its definition so the sign truncation is explicit and documented in one place instead of relying on implicit conversion at each call site. No functional change. Signed-off-by: Ivy Lopez --- drivers/staging/rtl8723bs/include/hal_pg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/include/hal_pg.h b/drivers/staging/rtl8723bs/include/hal_pg.h index 7cb9c441fc01..7f1f004ab817 100644 --- a/drivers/staging/rtl8723bs/include/hal_pg.h +++ b/drivers/staging/rtl8723bs/include/hal_pg.h @@ -40,7 +40,7 @@ #define EEPROM_RF_BT_SETTING_8723B 0xC3 #define EEPROM_VERSION_8723B 0xC4 #define EEPROM_CustomID_8723B 0xC5 -#define EEPROM_DEFAULT_DIFF 0XFE +#define EEPROM_DEFAULT_DIFF ((s8)0XFE) /* RTL8723BS */ #define EEPROM_MAC_ADDR_8723BS 0x11A -- 2.55.0