From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51BD564AA4 for ; Sat, 15 Aug 2026 21:08:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786828107; cv=none; b=YBBB/qLOuNsVxRlPcZ9te5vX3zsAlyc01X5AmigQGIUJZNG9B9Q2q6WlxZvFtYyArrjnNXacBn1wApRwADGJNpsIUz+Wy8IZgVSz/VCLZ0CmNuvsyFMphg3H5YEwhxazfIyGHbxVW14cw0snBwUqEut1Xe13VzK/8Uhc/YuChDw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786828107; c=relaxed/simple; bh=XKOEVoyTfwUoCmcAmKQ1YP13jKBU61CswwSJSCo7nqs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Zt30xJ9r0FCx1vzRrxlYSe8/ejSnr4UdHPmuNa8dPUTV5/CBLjbtiDe/mjJNDMaTn53r/RNAelxSYEqEmzSWMB8It7aERbf4v1H0UqG4nbKgze6kuLfohlE21kbBB22AtqXN1boQW5howHqCDb6XhqyY/GdLdXUrZK+75qcHaps= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rsV4UEuA; arc=none smtp.client-ip=209.85.208.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rsV4UEuA" Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-39c74c469e8so13876121fa.0 for ; Sat, 15 Aug 2026 14:08:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786828104; x=1787432904; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XKOEVoyTfwUoCmcAmKQ1YP13jKBU61CswwSJSCo7nqs=; b=rsV4UEuAC7b+UFmjkXc8X63Idg0oIQ5cpKow1SXn49JM2BsStk99Y5t9+L68G9eol+ n8xQ9NVQ+FfbBD9/GJlyV3QK5b6OF5GfvzPV1LlcHAWQaP6oX5A3o9CNwGXSBbiaYjis n3uo59GcgVYfhOC/F0YMNip+Ct5Ep0yQhEJcg6nt4BVEmmMr28ugCOFKpH5B5U1gkikT dcOtaeLtKbwI5AKkXhf7j94TXMSwOFMgZTjB8m9Y/dg6k93B/rt139r7fkyieXBeI8bY EPuT/EWbqyOiAvMRL0AJRwRfhfH7UNU7YRXYMZ6A5DUTIMJ/W5n5B6FZqmhUmLFnvGkf PzrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786828104; x=1787432904; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=XKOEVoyTfwUoCmcAmKQ1YP13jKBU61CswwSJSCo7nqs=; b=V4AMUmAuPYZAsVEY5Akxxtspa4iJyCpIR8OlI52pNS+ow4M7cta5vonGLskDPe2r2J axwr50HIXVNlm+9j22+JPL7v43U7gcKtz8W0X5QrdRTEizd5lUxTUQX0zZ1WpcSsTXFG 9ife4PjAbPJ2kDGVm0kzhiDSowCd43oWINipe0EyzVFJxOxa5m924yAKDHBVYn74TVwT vEsH8wnZpi6N4cOFkdlklbLEFyLYHvvMyqtsunDFcSo1HiQm2LjBs4GkxEDxc+t1DUB7 hquQS1Ra9VKJv0qYLFrBOEAN1hTOW0lUKTlgpZ1kxHq/5UtYHgsuO6b7sgm+ewaiLv9n 8sHQ== X-Forwarded-Encrypted: i=1; AHgh+Rq9THubVOzWMjDaXyHqtNuq2+nnKfdHJLlQDhUExmAh/7dvrXBZHeFn4KFfwF6aATvOrSIcW896N+RvPRs=@vger.kernel.org X-Gm-Message-State: AOJu0YzAT/ts5SnTVQL8Zk/4DZ3+YSDTRUoRGJLWQ0YemxIZ9Exyaost QuXNSdUlxFCARqPFun/ozFl3s0JLccZ7E9/4PRt5QNtV8Ge2xnSlD3MCQJo3Xw== X-Gm-Gg: AR+sD12BYn5gTZ25RWA1D+sg/HX7DdsWo3JOagyT0n3vG4JVeYuLEJCI94vr2+rsi+G a7pJV6BnvEoSJHDmjZ6lpJu5SjmCLnJDdJvNKXo385uXVd9EIu0sQfrNf3YVNV4/YMiDyqUq8RZ 6ZrS35I3WWYQuCBVR+l3t2C4qLkgrypWHKeaHCTs1d1P6o/TGkwriEdNteb751yK8kGd8egw5MJ gvAJgyiOpK09JhFtGMmkhiMJq9Od8sMsPxKQomzxk7efKL/PQUEWk51EumnItTro22nsgU0Zs2X +5hAjMHPRmyAzh4uABS6g/xwQmy+DPjn3abGfaqGh2Pwyp5EcSiAEB1JcI6D46z82MwMgf6Rssh tNadKOOtP/SD6EL94dh/8eglrkrWHRqvQTn3DTQCkNSGygif7TiymUZWq7BROr9XEpfyI1Ir4vF dpcNsiH7rubxGshXOt2/vg/LafOdlJ9sjLLL69wYMVjJzEoL2gpXhUdaMO1ecoaINOAZvqZx297 CHW+KEAvdw2N56HtUkg1mAt2lyy+nU2A7NmstXE5CTkf5NTL79eUtKkhyVIb3FK03KVTwW07Qmr PI+UsmWVirQ= X-Received: by 2002:a05:651c:2227:b0:39d:b5b9:f0f4 with SMTP id 38308e7fff4ca-3a14a041594mr5940271fa.10.1786828104142; Sat, 15 Aug 2026 14:08:24 -0700 (PDT) Received: from localhost.localdomain ([46.205.206.103]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3a130872f84sm12958501fa.1.2026.08.15.14.08.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Aug 2026 14:08:22 -0700 (PDT) From: Oleh Kuzhylnyi To: m13940358460@163.com Cc: dmitry.torokhov@gmail.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: touch screen - cst816x: fix gesture handling Date: Sat, 15 Aug 2026 23:08:20 +0200 Message-ID: <20260815210820.585452-1-kuzhylol@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260815021821.2896-1-m13940358460@163.com> References: <20260815021821.2896-1-m13940358460@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Sat, 15 Aug 2026 02:18:21 +0800, Jianing Li wrote: > The controller reports 0x05 for single click and 0x0b for double > click, while the binding only defines keycode mappings for the four > swipe gestures and long press. cst816x_gest_idx() currently maps every > other nonzero gesture to the long-press slot, so unsupported gesture > IDs can be reported using the long-press keycode. Officially, the driver and DT bindings do not configure or support the Double Click (0x0b) gesture. While the hardware may support it, the driver does not enable or map it. We shouldn't handle gestures outside of those documented in the DT bindings, unless the goal is specifically to ignore noise on the I2C bus. I re-tested the original driver on physical hardware (Raspberry Pi 4b with a CST816S display module) with debug logs enabled, and I confirmed that no gesture codes outside of those defined in the DT bindings are emitted. Best Regards, Oleh