From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB47713777E; Sat, 15 Aug 2026 20:21:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786825281; cv=none; b=Cf4ZRA/AmomTFK8W+nHEikdswJqu54HmX3Zb2eOPGcDl9G7tNHk2x/CO+jC3DIStRBnuhtC9sPUXnCjSDMTTbyMmOCzsEHFOdbXGylR5N/+E0DKY4M8TG26zKqF3x9eSlIEBlIOdCjVLKdA4YNnPdJVx5315Ot9xoYxCRy5/LOs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786825281; c=relaxed/simple; bh=CUUaHm++j6JB8fkZSt20cqmWpNkC2EoxOHs/QXSt1r0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GOG8NpSHihssLcR92Cu0lJTRJn65HU7TgP0ZTqTdeur/pHqou8u8BGM4s48z+wl6n+ChUQaH0htag5Wj/gtN7fKWApUNmnqbfZur2stVoPDCCs9449Uma79negh1p05EK5eAD9EjEAEZJ160jWJ1Plk1B990cUeweq5cIdvIavQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PgI2+awQ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PgI2+awQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB8DF1F000E9; Sat, 15 Aug 2026 20:21:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786825280; bh=DUZK5oZHYfkFD/KDpKFgfqbD2te7mdVjl+Lqbp4laZI=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=PgI2+awQfL+rCNhn8ulFmjoK7Y4tRAdozhgPvO/cftsu9ygluVwHXUS9FgqtUy9j5 klM245tjM0OmIhf/PqCzXdV9PjrhziSDayDUGN/o6K0p9HfhiMAALpOsSKjCioWrl9 y7h8KeIL9Enar82T3uKrsCzwqH81yii0w9RcHnI967Q5iK68ZECaXQJCLA0Y2hjSqD QeZd5unDirwpTAFW2JcKenux5pO8mRlIFFXGgSJTeJRIUx6SM2MW9FoVkrUfX7uoAq 2GHCCRnyG/JOal8M9LDx6tMHqMsXizHrIuyIGD8tWK0mbrLKi7gdYJnedx2/76YWeo 78SASbeLYHBeA== Date: Sat, 15 Aug 2026 21:21:13 +0100 From: Jonathan Cameron To: Varshini Rajendran Cc: , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v6 07/17] iio: adc: at91-sama5d2_adc: adapt the driver for sama7d65 Message-ID: <20260815212113.65e60919@jic23-huawei> In-Reply-To: <20260806074024.531259-8-varshini.rajendran@microchip.com> References: <20260806074024.531259-1-varshini.rajendran@microchip.com> <20260806074024.531259-8-varshini.rajendran@microchip.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 6 Aug 2026 13:10:14 +0530 Varshini Rajendran wrote: > Add support for sama7d65 ADC. The differences are highlighted with the > compatible. The calibration data layout is the main difference. > > Update Kconfig help text to mention SAMA7 SoC family support. > > Signed-off-by: Varshini Rajendran The Sashiko feedback on this one is interesting. https://sashiko.dev/#/patchset/20260806074024.531259-1-varshini.rajendran%40microchip.com The timestamp in the chan_spec array isn't the last one - the timestamp comes after it which is going to break in various unhelpful ways - as iio_push_to_buffers_with_timestamp() requires the timestamp to be the last scan index. in at91_adc_trigger_handler_nodma() there is a comment saying that it can only be used with voltage channels. That's fine but if they aren't useful, why are the scan_index values not -1 which is how we hide those interfaces for channels for which buffered capture is not supported. Given you have the hardware set up, can you check if the scan_elements/*_en is there for the temp channel and that for cases where it is enabled, we get an error in the buffer preenable callback? So I think it's a false positive but fair enough given the current user interfaces seems likely to be rather odd. Please sanity check all this. One other thing inline. Jonathan > --- > drivers/iio/adc/Kconfig | 2 +- > drivers/iio/adc/at91-sama5d2_adc.c | 30 ++++++++++++++++++++++++++++++ > 2 files changed, 31 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig > index 3755a81c1efd..85b443853a08 100644 > --- a/drivers/iio/adc/Kconfig > +++ b/drivers/iio/adc/Kconfig > @@ -647,7 +647,7 @@ config AT91_SAMA5D2_ADC > select IIO_TRIGGERED_BUFFER > help > Say yes here to build support for Atmel SAMA5D2 ADC which is > - available on SAMA5D2 SoC family. > + available on SAMA5D2 and SAMA7 SoC families. > > To compile this driver as a module, choose M here: the module will be > called at91-sama5d2_adc. > diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c > index 3e9feb824a66..c1e5139a058c 100644 > --- a/drivers/iio/adc/at91-sama5d2_adc.c > +++ b/drivers/iio/adc/at91-sama5d2_adc.c > @@ -528,6 +528,15 @@ static const struct at91_adc_temp_calib_layout sama7g5_temp_calib = { > .p1_scale = { .numerator = 1000, .denominator = 1 }, > }; > > +static const struct at91_adc_temp_calib_layout sama7d65_temp_calib = { > + .tag_idx = 1, > + .p1_idx = 3, > + .p4_idx = 2, > + .p6_idx = 5, > + .min_len = 11, > + .p1_scale = { .numerator = 1, .denominator = 1000 }, > +}; > + > /* Temperature sensor calibration - Vtemp voltage sensitivity to temperature. */ > #define AT91_ADC_TS_VTEMP_DT (2080U) > > @@ -766,6 +775,24 @@ static const struct at91_adc_platform sama7g5_platform = { > .temp_calib_layout = &sama7g5_temp_calib, > }; > > +static const struct at91_adc_platform sama7d65_platform = { > + .layout = &sama7g5_layout, > + .adc_channels = &at91_sama7g5_adc_channels, > + .nr_channels = AT91_SAMA7G5_SINGLE_CHAN_CNT + > + AT91_SAMA7G5_DIFF_CHAN_CNT + > + AT91_SAMA7G5_TEMP_CHAN_CNT, > + .max_channels = ARRAY_SIZE(at91_sama7g5_adc_channels), > + .max_index = AT91_SAMA7G5_MAX_CHAN_IDX, > + .hw_trig_cnt = AT91_SAMA7G5_HW_TRIG_CNT, > + .osr_mask = GENMASK(18, 16), > + .oversampling_avail = { 1, 4, 16, 64, 256 }, > + .oversampling_avail_no = 5, > + .chan_realbits = 16, > + .temp_sensor = true, > + .temp_chan = AT91_SAMA7G5_ADC_TEMP_CHANNEL, Is this ever used? > + .temp_calib_layout = &sama7d65_temp_calib, > +}; > + > static int at91_adc_chan_xlate(struct iio_dev *indio_dev, int chan) > { > int i; > @@ -2632,6 +2659,9 @@ static const struct of_device_id at91_adc_dt_match[] = { > }, { > .compatible = "microchip,sama7g5-adc", > .data = &sama7g5_platform, > + }, { > + .compatible = "microchip,sama7d65-adc", > + .data = &sama7d65_platform, > }, { > /* sentinel */ > }