From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f48.google.com (mail-oa1-f48.google.com [209.85.160.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A78E134676F for ; Mon, 17 Aug 2026 00:00:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786924839; cv=none; b=QYO8YezipGtPVJRznoDkpJivpfPM2etfhCdXMAleJg4jgPCT6klUm2MXVANjgSjW8OM6Lz8yZ+DhWHwMeqjqUOikd5H7wQowr9jVEVD5hbHx/mrYZQG4zY8CXPON/ZhIYZEViqI46wMEbqCImsgUQ9Neqw4rtOv1UE775Pn9g3U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786924839; c=relaxed/simple; bh=R4LaImY/2T66WrlPaQnoTaMqE3LDAYsVdXsxUsoQMts=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QZzZC0hazilTPayZ1054dB4+I4D/nM284LWupfPS8BAh1aVaOTKU9dDAbTKyzJGp6neXMFtunD7cI7IFeL1itt9kusGrhRRDuG8nZTY0S8GwPeWVUzkElfV+UDbx73eJuEzS3HcT4AFDO6ZGpZsim54XN3qpiix1pDf+eMTRWrs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=r3CPhCiX; arc=none smtp.client-ip=209.85.160.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="r3CPhCiX" Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-448cf99c133so2961934fac.1 for ; Sun, 16 Aug 2026 17:00:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786924836; x=1787529636; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NGDW8YHqJRyxuOShb3YiQbckQHmyOYQ8jIzHmdrCgnM=; b=r3CPhCiXXkR0suOT1mSnrs188I3B2ZXVUdkNH+syl4ysJ61KamnbTLe/lqpGDOSrqP 4i+8NVL4+EuFDqX9wYCv7A6HzixdbmLWEIqugcJrSR/L0pAvjOleyECmziaznfCrc1HT C/SFEHO3w0VpS8lxHGk6OtQCt1wQsnbfWsYhc5Mkq5AA6AwyZwMObaASnl//3o+2N2O/ IaYL4TgcXqutHPJYfnrUkNF12/12eIJ9ev7Zo8xddB6N/bgT/KBaCimdwTQ3F950Bckb BvjPIPo+IthecXfZJEeDSaclTamHU7ak68F9+Jvy08AEwUiz1k+BA48ZxJXq2qV+i3dy pQbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786924836; x=1787529636; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=NGDW8YHqJRyxuOShb3YiQbckQHmyOYQ8jIzHmdrCgnM=; b=AlRHEoLZ3hn5xESFrXXS0i/qhMWlNWvwjrwczywP20zU3vShgoImYUokg2XqnIVLBo 1RTlvIjHfNx1o64kiLy2Cogy9vAd2uLXk15N4KPv76FZXY2WZ2jLozMM1JTegsDcFMdO AcJNdpIrbI9j4pwyR2pszr8EsDZW+0+pGZ2D3B/aeMDxwIK24tt0ZBDVVRdE1dzouPh9 d03QkNtXRT1cS6euxD1kz2qgNIQpHr65cIZLf5LD3eqODkXbwjJDag2Q8ENn42NU7o5J Am+W4JeZBqvc8UD+bzwt38fxPi7hLMSDUN8Jg+CImoxiQscbHt3PszjUj7StsN9oXfEg qrTg== X-Forwarded-Encrypted: i=1; AHgh+RroaiMOEf1+ptDPtZz+xy5fiBX0RmzkUhi6IT9QKlvn+EfijYpQM06TislUGsWpwr6KThbUEY4pRFXM0f0=@vger.kernel.org X-Gm-Message-State: AOJu0YzZM7D8B18p3fNHCmOSkuj57zrlTDH0ihkdWN2pFLVWsYwN6BmM cQCk8SOh0A0BUPRvoOUk82hdlK83DOjPttJNQh12Q4A7CK4H6m7mPpEU X-Gm-Gg: AR+sD12QeXYqfC8dCgVzMHNO3hGlmK1n9q/Y2D9g1RM9jFHnwsSkCJRONHUlOmCWYeS Pn2CffnwBY6Uc9IshTgRKOOMOzmwY0LB8CIZ2JBFevx6+D53AubschISPxwdXDGZEjJwSHSeb3R e7P00RvLZv4LznwdXUF8hdMPdy3iopTOGw/pYowxFTdxJ/xsrFofTZE8zNLNZIMyUJ5VYO5/EpT PXTxyzrLbPaGtJomDUkt1F2RkrX+uMFGfqdYWI9ynQT/vMvwSr9KHgEe0JdO/nimtnzdIQ2fA9X +1Hb7WAcLyGQh1trYsOcvlATStac3i9GNdA3iF52VWljb0aB+Pn9qFaMPyID2FUR54QLeLzUa7G xU/4wpHJgeN4AvZyaAB35uY8AkbhiKptXEH3uNbmHeAZbOMo7o+MILOYCXV1N5I9OOZ1KIkvxfC fWapvgHknF9Fvs5qfgHFzlVL2stZnALfjmbcdM6Mt85zDthMINY4bT1+FhjGKPp/Wbh+m7x/NVl V9hJqXP5VxJ83/WEkTfrl1B8C4C8RsNpq5OADp3Nj4Khlw42ExKmRm6J9EE5Y/KcadAIrxoZffp g04b4pwjauQVjH6m7V1Qx4EGwPnq4OdFtA1fQ18u+s3CAV0Kh5idzCcp5QDK/HrqI7dDWTNSbYb XL3DcOZBB3H0XEso3 X-Received: by 2002:a05:6808:10ca:b0:4ab:25f0:1a8d with SMTP id 5614622812f47-4b240453a64mr13286027b6e.16.1786924836477; Sun, 16 Aug 2026 17:00:36 -0700 (PDT) Received: from [127.0.1.1] (184-96-154-59.hlrn.qwest.net. [184.96.154.59]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4b2714dc18asm2556802b6e.17.2026.08.16.17.00.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Aug 2026 17:00:35 -0700 (PDT) From: James Hilliard Date: Sun, 16 Aug 2026 18:00:28 -0600 Subject: [PATCH net-next v2 1/4] of: property: skip links without a consumer node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260816-submit-phy-package-fwdevlink-v1-v2-1-23e55dd59fad@gmail.com> References: <20260816-submit-phy-package-fwdevlink-v1-v2-0-23e55dd59fad@gmail.com> In-Reply-To: <20260816-submit-phy-package-fwdevlink-v1-v2-0-23e55dd59fad@gmail.com> To: Rob Herring , Saravana Kannan , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Andrew Lunn , Christian Marangi , "David S. Miller" , Heiner Kallweit , Russell King , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, driver-core@lists.linux.dev, netdev@vger.kernel.org, James Hilliard X-Mailer: b4 0.15.2 Supplier bindings can map a property node to the device node which consumes the referenced resource. The remote-endpoint binding uses of_graph_get_port_parent(), which can return NULL for a malformed graph node without its expected parents. of_link_property() currently passes that NULL node through to fwnode_link_add(), which dereferences the consumer while adding the link. Only create the link when the binding resolved a consumer node. A malformed graph property then creates no dependency instead of crashing while fw_devlink parses the tree. Fixes: f7514a663016 ("of: property: fw_devlink: Add support for remote-endpoint") Signed-off-by: James Hilliard --- drivers/of/property.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/of/property.c b/drivers/of/property.c index 72cf12907de0..38c0c7dc428a 100644 --- a/drivers/of/property.c +++ b/drivers/of/property.c @@ -1620,7 +1620,9 @@ static int of_link_property(struct device_node *con_np, const char *prop_name) matched = true; i++; - of_link_to_phandle(con_dev_np, phandle, s->fwlink_flags); + if (con_dev_np) + of_link_to_phandle(con_dev_np, phandle, + s->fwlink_flags); of_node_put(phandle); } s++; -- 2.53.0