From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 590F633FE0A for ; Sun, 16 Aug 2026 01:21:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786843282; cv=none; b=jW0Z0g1pJ5ivgHppoFvj+X+SKYfyzXhfvTtIebiao3FvSs9zPCzC3cY5zEfFVQnC38hvKaMBAC0lJuVelZmy0JBdVNthLqfi931ZfZ3210zxDPp+jx2rrcS8VhzfmWyDaow44+DLl+RJJ4m4BDBNhlpVYAjq/7ArNV6twFnJAnc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786843282; c=relaxed/simple; bh=Gen9hwbb5IzqFoip7jeIVRTXtpYL4kYgrsAnLhvo1OA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=D3v4qY8bSKyQDTnDQbtj0WonM11ZrpVF74WWSpqVJrT76fGGi0ZkLqwyQFm9Z19RTKFyx3lo8SkHTBg7mk2nUX2DXNdPRbR/PI40Kp9lSevG6iqpP1lNLPZONRCJnkdjS1u3qcLkD2ROqUo+EVc7L+RXlOCgDXAVcGN+C6xfwhs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=czBQ/w41; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="czBQ/w41" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-495590dde14so28975355e9.0 for ; Sat, 15 Aug 2026 18:21:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786843279; x=1787448079; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ZxQftwL2PECJ4SpESVyGEcp2FdWssPfyBN4bxwXPtrQ=; b=czBQ/w41rPrfdhEgTGwVExUj4ebWs06JJCopyhkGf7UeixJLyFbKxkyHn0UT14HgTY RipN5lVnVObDGwOaA9ehgHKEi5/SKd3N66BOmBBoqYvyNJFF4yfuz6XEFiV2Lwww8faZ 6Ir4ewRoAJCTCwvWt/rQJ3APdUgmUmQMSkSZsfUnIobRnFPnYAZBr44D+mdf4iHt8FZr NTssM39Qh5Ist4QyWz1v/MUHYechX9B2N4DZETuZJlm9qblBDxOxzv9WCxCH+KNTlt6n dDzacIDqrN4A9VhYhv3S7cAkuqQmxYxWrZfrMfe2dJVOgX4dRWUnmjihupnXPKQVHwhn 4H7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786843279; x=1787448079; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZxQftwL2PECJ4SpESVyGEcp2FdWssPfyBN4bxwXPtrQ=; b=VfmRopQAbhKTqiEIFKlpHKhHuSqg3DFFuCy1Y69649U6/6vAd329l2jcd2DnwIuQwi G2EPWRZDcP90X4KoG0j+XP6MdDKX3NsKEIzJEN6Vf2/bolq7ukZQXwCB9qsj4ikRtXFI SKl0RfHUdSOKLJXk9qsFLcGwwH5lf7m7FbhKma9+MMW+aVX6BmnVCEB3x5yC8l5/bMZf QWA9zbA1DL6GKyBVE5SYXbhByzBJhJRYlFwqzIxDvDxJyI1cv0fKtt/98hozFajqpwJt PoSgPSYUVLrJIxJOIcz1+JzArraG6fbQi2CoWxjIF8GtofKWpxVh4CNI09Mf9xWb7FFb MC5w== X-Forwarded-Encrypted: i=1; AHgh+RokqltUyjDgVgg5wswBJFxN+cKpUCSUyIQBz5t64geivkw2RMJ193d5Wov1J+Vjfvlh0WxH0JhU4u544Jg=@vger.kernel.org X-Gm-Message-State: AOJu0YznViFEt3/6St+ZSO9nNwdyqb8ysuX/YnccuRx2WVvxZkBTWrV4 AHVesWYYASG+t2fMXB9tuLqvD82+Q6XN7alRqrwzRgxzvaUtmuWx/Ilv X-Gm-Gg: AR+sD13p40oBEIQFmePU+BTztIQtTuRltODsDH2ZJejES7q9rb0xCTRcuRIcG5FE1+W MmTeSuoKKP0ms73EZyxfuZKpcIXUsFG2LRRQJQO3/n0IqeCxtKEExFZn5DUwBHr04DpqzvsyfOX xi+E8yIYTjoYZmWoG5wLsSw3wRyl3zDraPgXnltN9LQ3X5qB1jt1myWCwWH5X+nfSs6ZsaSu/yY KrziYAT+bg/uL87EH0byAEYOq9H8yFHV9+USH5HcsgiSKfhSXzJQ9Uc1P3EyuuM4HH9ZqB/2A5Z Yd8xMvc9l5OVCXA2rHTI22yB6cFtFctF388awKiDUcQjwUWxeNMum/SitqXodCIoJ4GaME0MYaz 8X7ZtTYJnz8Ewr4ErChzpfIJUrvbHsGYNXFYwaw7r5eLsfArpn64o6Btl5sfYF+AbsSFFU+6g63 byEGZQtP0gSWJiK0Ooj20PRIm0Doyk/rZsOPG7E8uTVZLu8sGaKvHIB5AvY4LalTDXb6WLvGtn X-Received: by 2002:a05:600c:4e14:b0:499:7e2b:8e5 with SMTP id 5b1f17b1804b1-4998793ffe7mr247502565e9.5.1786843279382; Sat, 15 Aug 2026 18:21:19 -0700 (PDT) Received: from unicorn.lan.internal ([2a0d:3341:b894:4600:78e4:e92e:b052:d281]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499961767f5sm923525e9.9.2026.08.15.18.21.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Aug 2026 18:21:18 -0700 (PDT) From: ooonea To: =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= Cc: Jamal Hadi Salim , Jiri Pirko , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , cake@lists.bufferbloat.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net] net/sched: sch_cake: fix autorate reconfiguration throttling Date: Sun, 16 Aug 2026 03:21:09 +0200 Message-ID: <20260816012109.2865223-1-ooonea@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit CAKE's autorate-ingress path intends to limit shaper reconfiguration to once per 250 ms, but last_reconfig_time is only checked and never updated. Since the field stays zero, every qualifying capacity-estimate window can call cake_reconfigure(), causing avoidable rate churn and scheduler work under bursty traffic. Store the current timestamp when autorate actually reconfigures the qdisc so the guard enforces the intended interval. Fixes: 7298de9cd725 ("sch_cake: Add ingress mode") Assisted-by: Codex:gpt-5.5 Signed-off-by: ooonea --- net/sched/sch_cake.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c index f25f60978..dc9326702 100644 --- a/net/sched/sch_cake.c +++ b/net/sched/sch_cake.c @@ -1907,6 +1907,7 @@ static s32 cake_enqueue(struct sk_buff *skb, struct Qdisc *sch, ktime_add_ms(q->last_reconfig_time, 250))) { q->config->rate_bps = (q->avg_peak_bandwidth * 15) >> 4; + q->last_reconfig_time = now; cake_reconfigure(sch); } } base-commit: 24ef02f934eeb48830cff6b739abc3c62b1d107b -- 2.54.0